[{"id":14687,"web_url":"https://patchwork.libcamera.org/comment/14687/","msgid":"","date":"2021-01-22T10:53:06","subject":"Re: [libcamera-devel] [PATCH v2 2/6] pipeline: raspberrypi: Set the\n\tISP Output1 to 1/4 resolution if unused","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the revised version of this patch.\n\nOn Fri, 22 Jan 2021 at 09:25, Naushir Patuck wrote:\n>\n> In preparation for fast colour denoise, set the low resolution ISP\n> output stream (Output1) to a 1/4 resolution of the application requested\n> stream (Output0). This only happens if the application has not requested\n> an additional YUV or RGB stream.\n>\n> We also constrain this 1/4 resolution to at most 1200 pixels in the\n> largest dimension to avoid being too taxing on memory usage and system\n> bandwidth.\n>\n> Also switch the default StreamRole::VideoRecording to YUV420 to allow\n> fast colour denoise to run.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> .../pipeline/raspberrypi/raspberrypi.cpp | 32 ++++++++++++++++++-\n> 1 file changed, 31 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 7e92f7669126..a0d3ac7ce49f 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -496,7 +496,7 @@ CameraConfiguration *PipelineHandlerRPi::generateConfiguration(Camera *camera,\n>\n> case StreamRole::VideoRecording:\n> fmts = data->isp_[Isp::Output0].dev()->formats();\n> - pixelFormat = formats::NV12;\n> + pixelFormat = formats::YUV420;\n> size = { 1920, 1080 };\n> bufferCount = 4;\n> outCount++;\n> @@ -608,6 +608,7 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> * StreamConfiguration appropriately.\n> */\n> V4L2DeviceFormat format;\n> + bool output1Set = false;\n> for (unsigned i = 0; i < config->size(); i++) {\n> StreamConfiguration &cfg = config->at(i);\n>\n> @@ -632,6 +633,9 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> format.size = cfg.size;\n> format.fourcc = fourcc;\n>\n> + LOG(RPI, Info) << \"Setting \" << stream->name() << \" to a resolution of \"\n> + << format.toString();\n> +\n> ret = stream->dev()->setFormat(&format);\n> if (ret)\n> return -EINVAL;\n> @@ -645,6 +649,32 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n>\n> cfg.setStream(stream);\n> stream->setExternal(true);\n> +\n> + if (i != maxIndex)\n> + output1Set = true;\n> + }\n> +\n> + /*\n> + * If ISP::Output1 stream has not been requested by the application, we\n> + * set it up for internal use now. This second stream will be used for\n> + * fast colour denoise, and must be a quarter resolution of the ISP::Output0\n> + * stream. However, also limit the maximum size to 1200 pixels in the\n> + * larger dimension, just to avoid being wasteful with buffer allocations\n> + * and memory bandwidth.\n> + */\n> + if (!output1Set) {\n> + V4L2DeviceFormat output1Format = format;\n> + constexpr unsigned int maxDimensions = 1200;\n> + const Size limit = Size(maxDimensions, maxDimensions).boundedToAspectRatio(format.size);\n> +\n> + output1Format.size = (format.size / 2).boundedTo(limit).alignedDownTo(2, 2);\n\nYes, doesn't it look lovely now!\n\nReviewed-by: David Plowman \n\nThanks\nDavid\n\n> +\n> + LOG(RPI, Info) << \"Setting ISP Output1 (internal) to a resolution of \"\n> + << output1Format.toString();\n> +\n> + ret = data->isp_[Isp::Output1].dev()->setFormat(&output1Format);\n> + if (ret)\n> + return -EINVAL;\n> }\n>\n> /* ISP statistics output format. */\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75192C0F2A\n\tfor ;\n\tFri, 22 Jan 2021 10:53:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1E356823B;\n\tFri, 22 Jan 2021 11:53:18 +0100 (CET)","from mail-ot1-x333.google.com (mail-ot1-x333.google.com\n\t[IPv6:2607:f8b0:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 227E368232\n\tfor ;\n\tFri, 22 Jan 2021 11:53:18 +0100 (CET)","by mail-ot1-x333.google.com with SMTP id s2so2459141otp.5\n\tfor ;\n\tFri, 22 Jan 2021 02:53:18 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"gbNHdK0O\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=ZTiopsV/uocc8eDHkc/MTRUQv4MTyNYXpe5i41HGY7w=;\n\tb=gbNHdK0OpVXTA55CiUZUHUJkUQho4F7tNjbMcUfsWEeUoYIF1jqyRKNNZ6p9ENNbtO\n\tsB6jlbDnPvZAGHsb7tVJAazDMZEMQUVxeCZ9NU2HvlIvN9QBp81fEhnRBk37Ah0pJFvg\n\tgywY9DoC5e9pP8W/4YLIEDaAXsIdnA5tQdbebcsAdPcKeW24x5a3e4QqlkCXEAxWVshz\n\tc9Vi1FOZGrJXplQQQT26YlJODcly3my45+nYcx45kafDcgFTdj6/5OJaOzd7JsHM8ngk\n\tYHwEWWEu1LNxK1PuhVDgvoJ/t0UGoobML7s52ZWwLBnOrhJM3VsncEkZ3pROBVZIKzJU\n\tc+LA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=ZTiopsV/uocc8eDHkc/MTRUQv4MTyNYXpe5i41HGY7w=;\n\tb=Vbdo8izK+my/F5H9Z077oPe0eRBV3DSf41KQfEh3oV5rS67IrLigKOqgZK+jrHcgZ9\n\tbMNHhefpEQGppnyB8Z+CT9+BDPDO/v85Jl5Y2ihzSPXcnBAlhxHQPUGELcTpBuMiyjrB\n\t5l9hrxoNwNKmPOmTKGrbmG0jwPPiKFqToVK24vVjf5djIjcqrMoWK49P4ibLDJH/LTx1\n\tc7+60ZkBijUu+Y4owQPm1hfUdUXuHYvQwnUE2DMLkRXn2+6vQBBCEztlnGnfYgfYJ+9r\n\tHdsZ6L1Jvqfsi0YqcNc/x7PNsOnlbrlGiYafCRHghUcpA84EhaY9ceedw8cs2VbUJnRF\n\tfmVQ==","X-Gm-Message-State":"AOAM533ARQtGp/BsGtZnJhUemwFuKHXgU+Os5973yaQFHnK4hP9FxKcQ\n\tlLLxXgMWxW5/XSZo7q1wVJagwN4fDsL2RiCoyAFLNw==","X-Google-Smtp-Source":"ABdhPJyra/hcTG4z77TpRbu5m3NFTFiTFBd3rgb7XWKXQ7xaJAqZ/hFsx9RoTEnOws+GBMeTBJacLSjQ7bPRtTtK7So=","X-Received":"by 2002:a05:6830:1e7b:: with SMTP id\n\tm27mr2637257otr.317.1611312796966; \n\tFri, 22 Jan 2021 02:53:16 -0800 (PST)","MIME-Version":"1.0","References":"<20210122092537.708375-1-naush@raspberrypi.com>\n\t<20210122092537.708375-3-naush@raspberrypi.com>","In-Reply-To":"<20210122092537.708375-3-naush@raspberrypi.com>","From":"David Plowman ","Date":"Fri, 22 Jan 2021 10:53:06 +0000","Message-ID":"","To":"Naushir Patuck ","Subject":"Re: [libcamera-devel] [PATCH v2 2/6] pipeline: raspberrypi: Set the\n\tISP Output1 to 1/4 resolution if unused","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14692,"web_url":"https://patchwork.libcamera.org/comment/14692/","msgid":"","date":"2021-01-22T11:42:56","subject":"Re: [libcamera-devel] [PATCH v2 2/6] pipeline: raspberrypi: Set the\n\tISP Output1 to 1/4 resolution if unused","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 22/01/2021 09:25, Naushir Patuck wrote:\n> In preparation for fast colour denoise, set the low resolution ISP\n> output stream (Output1) to a 1/4 resolution of the application requested\n> stream (Output0). This only happens if the application has not requested\n> an additional YUV or RGB stream.\n> \n> We also constrain this 1/4 resolution to at most 1200 pixels in the\n> largest dimension to avoid being too taxing on memory usage and system\n> bandwidth.\n> \n> Also switch the default StreamRole::VideoRecording to YUV420 to allow\n> fast colour denoise to run.\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> .../pipeline/raspberrypi/raspberrypi.cpp | 32 ++++++++++++++++++-\n> 1 file changed, 31 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 7e92f7669126..a0d3ac7ce49f 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -496,7 +496,7 @@ CameraConfiguration *PipelineHandlerRPi::generateConfiguration(Camera *camera,\n> \n> \t\tcase StreamRole::VideoRecording:\n> \t\t\tfmts = data->isp_[Isp::Output0].dev()->formats();\n> -\t\t\tpixelFormat = formats::NV12;\n> +\t\t\tpixelFormat = formats::YUV420;\n> \t\t\tsize = { 1920, 1080 };\n> \t\t\tbufferCount = 4;\n> \t\t\toutCount++;\n> @@ -608,6 +608,7 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> \t * StreamConfiguration appropriately.\n> \t */\n> \tV4L2DeviceFormat format;\n> +\tbool output1Set = false;\n> \tfor (unsigned i = 0; i < config->size(); i++) {\n> \t\tStreamConfiguration &cfg = config->at(i);\n> \n> @@ -632,6 +633,9 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> \t\tformat.size = cfg.size;\n> \t\tformat.fourcc = fourcc;\n> \n> +\t\tLOG(RPI, Info) << \"Setting \" << stream->name() << \" to a resolution of \"\n> +\t\t\t << format.toString();\n> +\n> \t\tret = stream->dev()->setFormat(&format);\n> \t\tif (ret)\n> \t\t\treturn -EINVAL;\n> @@ -645,6 +649,32 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> \n> \t\tcfg.setStream(stream);\n> \t\tstream->setExternal(true);\n> +\n> +\t\tif (i != maxIndex)\n> +\t\t\toutput1Set = true;\n> +\t}\n> +\n> +\t/*\n> +\t * If ISP::Output1 stream has not been requested by the application, we\n> +\t * set it up for internal use now. This second stream will be used for\n> +\t * fast colour denoise, and must be a quarter resolution of the ISP::Output0\n> +\t * stream. However, also limit the maximum size to 1200 pixels in the\n> +\t * larger dimension, just to avoid being wasteful with buffer allocations\n> +\t * and memory bandwidth.\n> +\t */\n> +\tif (!output1Set) {\n> +\t\tV4L2DeviceFormat output1Format = format;\n> +\t\tconstexpr unsigned int maxDimensions = 1200;\n> +\t\tconst Size limit = Size(maxDimensions, maxDimensions).boundedToAspectRatio(format.size);\n> +\n> +\t\toutput1Format.size = (format.size / 2).boundedTo(limit).alignedDownTo(2, 2);\n> +\n> +\t\tLOG(RPI, Info) << \"Setting ISP Output1 (internal) to a resolution of \"\n> +\t\t\t << output1Format.toString();\n> +\n> +\t\tret = data->isp_[Isp::Output1].dev()->setFormat(&output1Format);\n> +\t\tif (ret)\n\nShould there be a print here if this happens? Or is it never really\ngoing to happen?\n\nOtherwise:\n\nReviewed-by: Kieran Bingham \n\n> +\t\t\treturn -EINVAL;\n> \t}\n> \n> \t/* ISP statistics output format. */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 484A3BD808\n\tfor ;\n\tFri, 22 Jan 2021 11:43:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A3F9E68245;\n\tFri, 22 Jan 2021 12:43:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A19B2681D8\n\tfor ;\n\tFri, 22 Jan 2021 12:42:59 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D9CD4FB;\n\tFri, 22 Jan 2021 12:42:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AyOKlRY7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611315779;\n\tbh=geiBRfnQqVlNY5opWzB+1HtUxQsZ6Xssy1d+8X/k7Ok=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=AyOKlRY7/vgtwLWGpBAdnSG/Q7In1WrerPxhvhRHXcL63zeIBeSZ/tHCySgahd9eh\n\tnuuNNyrT46yDDxjlaYpAidsuHH/HQqCjnEmwP9PPJlWVMKjuv4ZZ8wkbDrxLKwVQjZ\n\trsOi2IJ8S/Ri3vo2G0LJa6JkJaVPxH0/OJ//HS0s=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210122092537.708375-1-naush@raspberrypi.com>\n\t<20210122092537.708375-3-naush@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 22 Jan 2021 11:42:56 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210122092537.708375-3-naush@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 2/6] pipeline: raspberrypi: Set the\n\tISP Output1 to 1/4 resolution if unused","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14698,"web_url":"https://patchwork.libcamera.org/comment/14698/","msgid":"","date":"2021-01-22T11:59:03","subject":"Re: [libcamera-devel] [PATCH v2 2/6] pipeline: raspberrypi: Set the\n\tISP Output1 to 1/4 resolution if unused","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Kieran,\n\nThank you for your review feedback.\n\nOn Fri, 22 Jan 2021 at 11:42, Kieran Bingham <\nkieran.bingham@ideasonboard.com> wrote:\n\n> Hi Naush,\n>\n> On 22/01/2021 09:25, Naushir Patuck wrote:\n> > In preparation for fast colour denoise, set the low resolution ISP\n> > output stream (Output1) to a 1/4 resolution of the application requested\n> > stream (Output0). This only happens if the application has not requested\n> > an additional YUV or RGB stream.\n> >\n> > We also constrain this 1/4 resolution to at most 1200 pixels in the\n> > largest dimension to avoid being too taxing on memory usage and system\n> > bandwidth.\n> >\n> > Also switch the default StreamRole::VideoRecording to YUV420 to allow\n> > fast colour denoise to run.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > .../pipeline/raspberrypi/raspberrypi.cpp | 32 ++++++++++++++++++-\n> > 1 file changed, 31 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > index 7e92f7669126..a0d3ac7ce49f 100644\n> > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > @@ -496,7 +496,7 @@ CameraConfiguration\n> *PipelineHandlerRPi::generateConfiguration(Camera *camera,\n> >\n> > case StreamRole::VideoRecording:\n> > fmts = data->isp_[Isp::Output0].dev()->formats();\n> > - pixelFormat = formats::NV12;\n> > + pixelFormat = formats::YUV420;\n> > size = { 1920, 1080 };\n> > bufferCount = 4;\n> > outCount++;\n> > @@ -608,6 +608,7 @@ int PipelineHandlerRPi::configure(Camera *camera,\n> CameraConfiguration *config)\n> > * StreamConfiguration appropriately.\n> > */\n> > V4L2DeviceFormat format;\n> > + bool output1Set = false;\n> > for (unsigned i = 0; i < config->size(); i++) {\n> > StreamConfiguration &cfg = config->at(i);\n> >\n> > @@ -632,6 +633,9 @@ int PipelineHandlerRPi::configure(Camera *camera,\n> CameraConfiguration *config)\n> > format.size = cfg.size;\n> > format.fourcc = fourcc;\n> >\n> > + LOG(RPI, Info) << \"Setting \" << stream->name() << \" to a\n> resolution of \"\n> > + << format.toString();\n> > +\n> > ret = stream->dev()->setFormat(&format);\n> > if (ret)\n> > return -EINVAL;\n> > @@ -645,6 +649,32 @@ int PipelineHandlerRPi::configure(Camera *camera,\n> CameraConfiguration *config)\n> >\n> > cfg.setStream(stream);\n> > stream->setExternal(true);\n> > +\n> > + if (i != maxIndex)\n> > + output1Set = true;\n> > + }\n> > +\n> > + /*\n> > + * If ISP::Output1 stream has not been requested by the\n> application, we\n> > + * set it up for internal use now. This second stream will be used\n> for\n> > + * fast colour denoise, and must be a quarter resolution of the\n> ISP::Output0\n> > + * stream. However, also limit the maximum size to 1200 pixels in\n> the\n> > + * larger dimension, just to avoid being wasteful with buffer\n> allocations\n> > + * and memory bandwidth.\n> > + */\n> > + if (!output1Set) {\n> > + V4L2DeviceFormat output1Format = format;\n> > + constexpr unsigned int maxDimensions = 1200;\n> > + const Size limit = Size(maxDimensions,\n> maxDimensions).boundedToAspectRatio(format.size);\n> > +\n> > + output1Format.size = (format.size /\n> 2).boundedTo(limit).alignedDownTo(2, 2);\n> > +\n> > + LOG(RPI, Info) << \"Setting ISP Output1 (internal) to a\n> resolution of \"\n> > + << output1Format.toString();\n> > +\n> > + ret =\n> data->isp_[Isp::Output1].dev()->setFormat(&output1Format);\n> > + if (ret)\n>\n> Should there be a print here if this happens? Or is it never really\n> going to happen?\n>\n\nIt is possible to have this so I can add a log message (like for the\nprevious case).\n\nRegards,\nNaush\n\n\n> Otherwise:\n>\n> Reviewed-by: Kieran Bingham \n>\n> > + return -EINVAL;\n> > }\n> >\n> > /* ISP statistics output format. */\n> >\n>\n> --\n> Regards\n> --\n> Kieran\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A800BD808\n\tfor ;\n\tFri, 22 Jan 2021 11:59:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C9FB868251;\n\tFri, 22 Jan 2021 12:59:22 +0100 (CET)","from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC6FE68248\n\tfor ;\n\tFri, 22 Jan 2021 12:59:20 +0100 (CET)","by mail-lj1-x22b.google.com with SMTP id u11so6159823ljo.13\n\tfor ;\n\tFri, 22 Jan 2021 03:59:20 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"GyW34OwV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=ia1nuViP8A5YuGCFigTh2RbCGUKyh3QQ8Kwg5ObbDlE=;\n\tb=GyW34OwVfUly307hKxesmXn1jbic9c7DB5qKCXUd9/OEwTmZ4huPR86ryl1JDB5WVS\n\tV54CdhvATjcnjo2h6r7vMO91FEh990nOJSKPmKtlALwysSaT0seK18E87RYLRpbCcxyM\n\tjHd9m94eNIOH4uKjW/jzUWVcCtJRzDEbtXK7JRuvoUXG8ci7jVRPbq4rdPS/sA73J7ks\n\tiaxA+x/gMlhcyv6z/v7BbBVRk9IC/O0A5yfTpz4TkzveT+Drz7+UpR0TvqZ++61ikbfa\n\tUOHJB1tK/PHjGvm2NfrZDPptUFN+WgAZ7bXeqa1B/nWIo/DtE0/gcW7yb5YwbX87ddAm\n\ttgYQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=ia1nuViP8A5YuGCFigTh2RbCGUKyh3QQ8Kwg5ObbDlE=;\n\tb=iT92gmH23nJWLYIyGCsgkFOJx20NTM7ZbuPteZW6rvrggzpMV+iLudpIzJCglTt3eD\n\thgs6CLbDxtRk2tIGHFkd7Ih314bcvvFrYrpARV8tQ+xGR3XGWamHijJyX3d/tr2u68Lr\n\t1tF+c/R8SBUifc69ikP8b1IAbWIVENE7GtStNJk7NsSipFpDZluODoglPoVGZmGwypAP\n\tHVXR4qnzNR6MVQ9GA9XbZRvbKRe6vrg15pxuzOUhW8inw5JOpCG8Hc8b61u/0mFwjRbR\n\tqmBifSHmQeC2SSzSyL9WQgSJ+8pgPlFYvmG9zpQSnCKc57lf3atuN7TcyEUJDLqcYJt6\n\tXcwA==","X-Gm-Message-State":"AOAM532SStznsWqKeWYXs1kaRFiYIBULRiGwOIi2C/5xhvUYRgTWS08O\n\trkOwQrSiUZ8u26Y0KgDM6cxKSPR1mZCY3Xt3OR3lNdPrTSU=","X-Google-Smtp-Source":"ABdhPJyGWqfdSJ7PYK1+HdDzy9+fy3mQy1ghc99JYK7w3euA1HhBFYLx/xToSGQfTrDH8zkOLf99rIqnmxU+KeTxkis=","X-Received":"by 2002:a2e:3215:: with SMTP id y21mr2120814ljy.48.1611316760114;\n\tFri, 22 Jan 2021 03:59:20 -0800 (PST)","MIME-Version":"1.0","References":"<20210122092537.708375-1-naush@raspberrypi.com>\n\t<20210122092537.708375-3-naush@raspberrypi.com>\n\t","In-Reply-To":"","From":"Naushir Patuck ","Date":"Fri, 22 Jan 2021 11:59:03 +0000","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [PATCH v2 2/6] pipeline: raspberrypi: Set the\n\tISP Output1 to 1/4 resolution if unused","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============5742677890473873936==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]