[{"id":14691,"web_url":"https://patchwork.libcamera.org/comment/14691/","msgid":"","date":"2021-01-22T11:38:55","subject":"Re: [libcamera-devel] [PATCH v2 1/6] pipeline: raspberrypi:\n\tRefactor stream configuration routine","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 22/01/2021 09:25, Naushir Patuck wrote:\n> Refactor the high/low resolution stream format and output selection\n> routine. This change is in preparation of adding 1/4 resolution output\n> for fast colour denoise.\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n> ---\n> .../pipeline/raspberrypi/raspberrypi.cpp | 57 ++++++-------------\n> 1 file changed, 16 insertions(+), 41 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 524cc960dd37..7e92f7669126 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -624,52 +624,27 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> \t\t\tcontinue;\n> \t\t}\n> \n> -\t\tif (i == maxIndex) {\n> -\t\t\t/* ISP main output format. */\n> -\t\t\tV4L2VideoDevice *dev = data->isp_[Isp::Output0].dev();\n> -\t\t\tV4L2PixelFormat fourcc = dev->toV4L2PixelFormat(cfg.pixelFormat);\n> -\t\t\tformat.size = cfg.size;\n> -\t\t\tformat.fourcc = fourcc;\n> -\n> -\t\t\tret = dev->setFormat(&format);\n> -\t\t\tif (ret)\n> -\t\t\t\treturn -EINVAL;\n> -\n> -\t\t\tif (format.size != cfg.size || format.fourcc != fourcc) {\n> -\t\t\t\tLOG(RPI, Error)\n> -\t\t\t\t\t<< \"Failed to set format on ISP capture0 device: \"\n> -\t\t\t\t\t<< format.toString();\n> -\t\t\t\treturn -EINVAL;\n> -\t\t\t}\n> -\n> -\t\t\tcfg.setStream(&data->isp_[Isp::Output0]);\n> -\t\t\tdata->isp_[Isp::Output0].setExternal(true);\n> -\t\t}\n> +\t\t/* The largest resolution gets routed to the ISP Output 0 node. */\n> +\t\tRPi::Stream *stream = (i == maxIndex) ? &data->isp_[Isp::Output0] :\n> +\t\t\t\t\t\t\t&data->isp_[Isp::Output1];\n\nOnly minor, I think Laurent usually prefers the : below the ? in that style.\n\n\n\n> \n> -\t\t/*\n> -\t\t * ISP second output format. This fallthrough means that if a\n> -\t\t * second output stream has not been configured, we simply use\n> -\t\t * the Output0 configuration.\n> -\t\t */\n> -\t\tV4L2VideoDevice *dev = data->isp_[Isp::Output1].dev();\n> -\t\tformat.fourcc = dev->toV4L2PixelFormat(cfg.pixelFormat);\n> +\t\tV4L2PixelFormat fourcc = stream->dev()->toV4L2PixelFormat(cfg.pixelFormat);\n> \t\tformat.size = cfg.size;\n> +\t\tformat.fourcc = fourcc;\n> \n> -\t\tret = dev->setFormat(&format);\n> -\t\tif (ret) {\n> +\t\tret = stream->dev()->setFormat(&format);\n> +\t\tif (ret)\n> +\t\t\treturn -EINVAL;\n> +\n> +\t\tif (format.size != cfg.size || format.fourcc != fourcc) {\n> \t\t\tLOG(RPI, Error)\n> -\t\t\t\t<< \"Failed to set format on ISP capture1 device: \"\n> -\t\t\t\t<< format.toString();\n> -\t\t\treturn ret;\n> -\t\t}\n> -\t\t/*\n> -\t\t * If we have not yet provided a stream for this config, it\n> -\t\t * means this is to be routed from Output1.\n> -\t\t */\n> -\t\tif (!cfg.stream()) {\n> -\t\t\tcfg.setStream(&data->isp_[Isp::Output1]);\n> -\t\t\tdata->isp_[Isp::Output1].setExternal(true);\n> +\t\t\t\t<< \"Failed to set format on \" << stream->name()\n> +\t\t\t\t<< \" to \" << format.toString();\n\nisn't format.toString() going to report what was set by setFormat(&format)?\n\n(i.e. it's not going to be the correct format that requested to be set 'to'.\n\n\n\n\n> +\t\t\treturn -EINVAL;\n> \t\t}\n> +\n> +\t\tcfg.setStream(stream);\n> +\t\tstream->setExternal(true);\n> \t}\n> \n> \t/* ISP statistics output format. */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 724B0C0F2A\n\tfor ;\n\tFri, 22 Jan 2021 11:39:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 03E926823E;\n\tFri, 22 Jan 2021 12:39:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1424681D8\n\tfor ;\n\tFri, 22 Jan 2021 12:38:57 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E09D4FB;\n\tFri, 22 Jan 2021 12:38:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iLiqLp0v\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611315537;\n\tbh=vcBvn3cPLwWREN+J42uyXSiT3r10deco+SxWs/ysg2o=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=iLiqLp0vZho6mDxZ0IcxKncBZW5vXcFHsdHlZLi5B/OpIa60WmxmgeUuvxjaknNvL\n\tuLPsv5es2T7h1xCNUa9EFtquO6zAa52ZPol0vGKpUj7YcAxGTLqjDcQ0MkACfeEYS0\n\tiqsNqoBlfZtzgiHlf/KE1upox8rUt5RIJmcTwjXo=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210122092537.708375-1-naush@raspberrypi.com>\n\t<20210122092537.708375-2-naush@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 22 Jan 2021 11:38:55 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210122092537.708375-2-naush@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 1/6] pipeline: raspberrypi:\n\tRefactor stream configuration routine","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14696,"web_url":"https://patchwork.libcamera.org/comment/14696/","msgid":"","date":"2021-01-22T11:57:26","subject":"Re: [libcamera-devel] [PATCH v2 1/6] pipeline: raspberrypi:\n\tRefactor stream configuration routine","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Kieran,\n\nThank you for your review feedback:\n\nOn Fri, 22 Jan 2021 at 11:38, Kieran Bingham <\nkieran.bingham@ideasonboard.com> wrote:\n\n> Hi Naush,\n>\n> On 22/01/2021 09:25, Naushir Patuck wrote:\n> > Refactor the high/low resolution stream format and output selection\n> > routine. This change is in preparation of adding 1/4 resolution output\n> > for fast colour denoise.\n> >\n> > Signed-off-by: Naushir Patuck \n> > Reviewed-by: David Plowman \n> > ---\n> > .../pipeline/raspberrypi/raspberrypi.cpp | 57 ++++++-------------\n> > 1 file changed, 16 insertions(+), 41 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > index 524cc960dd37..7e92f7669126 100644\n> > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > @@ -624,52 +624,27 @@ int PipelineHandlerRPi::configure(Camera *camera,\n> CameraConfiguration *config)\n> > continue;\n> > }\n> >\n> > - if (i == maxIndex) {\n> > - /* ISP main output format. */\n> > - V4L2VideoDevice *dev =\n> data->isp_[Isp::Output0].dev();\n> > - V4L2PixelFormat fourcc =\n> dev->toV4L2PixelFormat(cfg.pixelFormat);\n> > - format.size = cfg.size;\n> > - format.fourcc = fourcc;\n> > -\n> > - ret = dev->setFormat(&format);\n> > - if (ret)\n> > - return -EINVAL;\n> > -\n> > - if (format.size != cfg.size || format.fourcc !=\n> fourcc) {\n> > - LOG(RPI, Error)\n> > - << \"Failed to set format on ISP\n> capture0 device: \"\n> > - << format.toString();\n> > - return -EINVAL;\n> > - }\n> > -\n> > - cfg.setStream(&data->isp_[Isp::Output0]);\n> > - data->isp_[Isp::Output0].setExternal(true);\n> > - }\n> > + /* The largest resolution gets routed to the ISP Output 0\n> node. */\n> > + RPi::Stream *stream = (i == maxIndex) ?\n> &data->isp_[Isp::Output0] :\n> > +\n> &data->isp_[Isp::Output1];\n>\n> Only minor, I think Laurent usually prefers the : below the ? in that\n> style.\n>\n\nAck.\n\n\n>\n>\n>\n> >\n> > - /*\n> > - * ISP second output format. This fallthrough means that\n> if a\n> > - * second output stream has not been configured, we simply\n> use\n> > - * the Output0 configuration.\n> > - */\n> > - V4L2VideoDevice *dev = data->isp_[Isp::Output1].dev();\n> > - format.fourcc = dev->toV4L2PixelFormat(cfg.pixelFormat);\n> > + V4L2PixelFormat fourcc =\n> stream->dev()->toV4L2PixelFormat(cfg.pixelFormat);\n> > format.size = cfg.size;\n> > + format.fourcc = fourcc;\n> >\n> > - ret = dev->setFormat(&format);\n> > - if (ret) {\n> > + ret = stream->dev()->setFormat(&format);\n> > + if (ret)\n> > + return -EINVAL;\n> > +\n> > + if (format.size != cfg.size || format.fourcc != fourcc) {\n> > LOG(RPI, Error)\n> > - << \"Failed to set format on ISP capture1\n> device: \"\n> > - << format.toString();\n> > - return ret;\n> > - }\n> > - /*\n> > - * If we have not yet provided a stream for this config, it\n> > - * means this is to be routed from Output1.\n> > - */\n> > - if (!cfg.stream()) {\n> > - cfg.setStream(&data->isp_[Isp::Output1]);\n> > - data->isp_[Isp::Output1].setExternal(true);\n> > + << \"Failed to set format on \" <<\n> stream->name()\n> > + << \" to \" << format.toString();\n>\n> isn't format.toString() going to report what was set by setFormat(&format)?\n>\n> (i.e. it's not going to be the correct format that requested to be set\n> 'to'.\n>\n\nYes, you are right. I ought to change the message text to \"Failed to get\nrequested format, returned: \" ... as I log the requested format earlier.\n\nRegards,\nNaush\n\n\n>\n>\n>\n>\n> > + return -EINVAL;\n> > }\n> > +\n> > + cfg.setStream(stream);\n> > + stream->setExternal(true);\n> > }\n> >\n> > /* ISP statistics output format. */\n> >\n>\n> --\n> Regards\n> --\n> Kieran\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4B3A3BD808\n\tfor ;\n\tFri, 22 Jan 2021 11:57:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C46F46824C;\n\tFri, 22 Jan 2021 12:57:44 +0100 (CET)","from mail-lf1-x133.google.com (mail-lf1-x133.google.com\n\t[IPv6:2a00:1450:4864:20::133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 32DAA681D8\n\tfor ;\n\tFri, 22 Jan 2021 12:57:44 +0100 (CET)","by mail-lf1-x133.google.com with SMTP id o10so7118340lfl.13\n\tfor ;\n\tFri, 22 Jan 2021 03:57:44 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"lGE9u65b\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=VvvWpkYHYUqr9s4MZJHShwWkfKvrJTy0KlLVYSiASiQ=;\n\tb=lGE9u65bOij4Z0Dg4WliI3rpdQ4KfUBXXPfRyo56Ky6F4TTx/5FPz45SjJXAzaYYLx\n\tCdkpD2owz689VVHfNW4PQqXB4/b1ZLn2h7rb62RBMu8Ma7TmoQ2ia/Fg8XTNBrB4V6vB\n\tCrGa3eq2KZeH1Dzg2ANAOS9IXT7waTB443Gz4xE4nbp8K3jppZ3ZK1n99mkWzje2XyRZ\n\t+clNk+6vw25/LkRJWkNrz52WDMzjxnBPbX5Ef73jnEEOAxdR5U37TJaX+0uz8Kfa5eie\n\tr0/z4LE1R3PziqP9FYMkSTtJJ90d14ZY8lnaxZeJt+lE0/sk+NVWJa6geNDgr4bEg5fd\n\t7zOQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=VvvWpkYHYUqr9s4MZJHShwWkfKvrJTy0KlLVYSiASiQ=;\n\tb=nOsg4Gn1TXoHQ5b1e9G+6xXOQl88hATOO532NSGQuFKmhppkj15cANkYz5Efim8530\n\tRQJrwYAGQvwdfFp9MOWmz8+FmWWclN8t+MpIA7i1eBjpMez7bvSBmsz3scrUtTsi9FLT\n\tIDC5EUf6NPwwV6AEhZjWqXW1YcmnWr5Df3or9BueD6vpwGq6d1CaR1v7E2Io7wkC+Oon\n\trcO2XuN4GV/VzHNHauy6msb5UIYAby0HSueekmIoGpf9W4uefK75yTvq8j9nFHIOV/HW\n\tdffVg+d6Xpm+uuHrx+SgVWg/VGyeYlAzfLdtKdW2/pctjaq1LjL3l4M2Oba6P7E70sD8\n\trR3A==","X-Gm-Message-State":"AOAM5313+xAuO++d/bhGwJYfSfkUjQLXo9m7oK61neBylZ/iFoDDtWxX\n\tSMoJoZDhd1kKgpLOyVnlBnO13Bpd5rgR6nflGpghQg==","X-Google-Smtp-Source":"ABdhPJzzH3JeH19ydaXv242lxDQmkhO5sWAy6a/vuOGb4IuLnamATClGHCWlipuDpCJ3fyA3LWoDCaeYPSYVUzZqOMw=","X-Received":"by 2002:a19:6b0e:: with SMTP id d14mr750897lfa.210.1611316663371;\n\tFri, 22 Jan 2021 03:57:43 -0800 (PST)","MIME-Version":"1.0","References":"<20210122092537.708375-1-naush@raspberrypi.com>\n\t<20210122092537.708375-2-naush@raspberrypi.com>\n\t","In-Reply-To":"","From":"Naushir Patuck ","Date":"Fri, 22 Jan 2021 11:57:26 +0000","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [PATCH v2 1/6] pipeline: raspberrypi:\n\tRefactor stream configuration routine","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============2311507377576116873==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]