[{"id":14675,"web_url":"https://patchwork.libcamera.org/comment/14675/","msgid":"","date":"2021-01-21T21:39:56","subject":"Re: [libcamera-devel] [PATCH 7/7] android: camera_metadata: Remove\n\toutdated comment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Jan 21, 2021 at 05:53:05PM +0100, Jacopo Mondi wrote:\n> The comment was moot, as the translation of Android's settings\n> to libcamera controls is already implemented in a dedicated function.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\nVery nice cleanup overall, it's much nicer to read.\n\n> ---\n> src/android/camera_device.cpp | 7 +------\n> 1 file changed, 1 insertion(+), 6 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index d185fdf7fb2f..f9af038412b1 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1629,12 +1629,7 @@ int CameraDevice::processControls(Camera3RequestDescriptor *descriptor)\n> \tif (!settings.isValid())\n> \t\treturn 0;\n> \n> -\t/*\n> -\t * Translate the Android controls to libcamera.\n> -\t *\n> -\t * \\todo As soon as more controls are handled, this part should be\n> -\t * broken out to a dedicated function.\n> -\t */\n> +\t/* Translate the Android request settings to libcamera controls. */\n> \tcamera_metadata_ro_entry_t entry;\n> \tbool found = settings.getEntry(ANDROID_SCALER_CROP_REGION, &entry);\n> \tif (found) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BFE6EC0F2A\n\tfor ;\n\tThu, 21 Jan 2021 21:40:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 79F9E68228;\n\tThu, 21 Jan 2021 22:40:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D579768223\n\tfor ;\n\tThu, 21 Jan 2021 22:40:14 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 78C3050E;\n\tThu, 21 Jan 2021 22:40:14 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hj0XnNdi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611265214;\n\tbh=yyFtkJ/4BMlTNVf7y6WNLbn9sav7IPL9/4AxJJpLdAs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hj0XnNdiXCbihhFbNGJ5AcBf1aNc7FCGUzZCy6qv+XUxHi7BjJ0S5GVwMX7hEVxBJ\n\txtAdhOtJw17G9fsBdDK0zoPMjYub4zwnO9VoPQeRvLALGr6lJBMksh/j33gVWejy9+\n\t3jaXGYIGYF5Rmd0W+Vem5gVMPsMF7GgM7BUwjgzU=","Date":"Thu, 21 Jan 2021 23:39:56 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210121165305.367801-1-jacopo@jmondi.org>\n\t<20210121165305.367801-8-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210121165305.367801-8-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 7/7] android: camera_metadata: Remove\n\toutdated comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14682,"web_url":"https://patchwork.libcamera.org/comment/14682/","msgid":"<20210122043904.GI1943@pyrite.rasen.tech>","date":"2021-01-22T04:39:04","subject":"Re: [libcamera-devel] [PATCH 7/7] android: camera_metadata: Remove\n\toutdated comment","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Thu, Jan 21, 2021 at 05:53:05PM +0100, Jacopo Mondi wrote:\n> The comment was moot, as the translation of Android's settings\n> to libcamera controls is already implemented in a dedicated function.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/android/camera_device.cpp | 7 +------\n> 1 file changed, 1 insertion(+), 6 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index d185fdf7fb2f..f9af038412b1 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1629,12 +1629,7 @@ int CameraDevice::processControls(Camera3RequestDescriptor *descriptor)\n> \tif (!settings.isValid())\n> \t\treturn 0;\n> \n> -\t/*\n> -\t * Translate the Android controls to libcamera.\n> -\t *\n> -\t * \\todo As soon as more controls are handled, this part should be\n> -\t * broken out to a dedicated function.\n> -\t */\n> +\t/* Translate the Android request settings to libcamera controls. */\n> \tcamera_metadata_ro_entry_t entry;\n> \tbool found = settings.getEntry(ANDROID_SCALER_CROP_REGION, &entry);\n> \tif (found) {\n> -- \n> 2.29.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1570C0F2A\n\tfor ;\n\tFri, 22 Jan 2021 04:39:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4973D6822B;\n\tFri, 22 Jan 2021 05:39:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B0F368212\n\tfor ;\n\tFri, 22 Jan 2021 05:39:12 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A03BC50E;\n\tFri, 22 Jan 2021 05:39:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U7vNqjb2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611290351;\n\tbh=NK1jX0amO0Vw2PzS5dtUHUeEvbyRRbSaEthm9VURvkU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=U7vNqjb2fx8bAcpQj4cW4hGzBPBn6E6wN4yTRrQzfEcvdvFAywxQzpekMyIQzZ/o3\n\tkrgGJw8sml+e407ul2Yw5N06MEEpgPM6ebzO/mIArcPZ5dxOX7KpJByCKMKcyBFivL\n\tA6FLJzt1FFznDtAwVfHiet30sPZ93W9dFPZ5UqS4=","Date":"Fri, 22 Jan 2021 13:39:04 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20210122043904.GI1943@pyrite.rasen.tech>","References":"<20210121165305.367801-1-jacopo@jmondi.org>\n\t<20210121165305.367801-8-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210121165305.367801-8-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 7/7] android: camera_metadata: Remove\n\toutdated comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]