{"id":10935,"url":"https://patchwork.libcamera.org/api/patches/10935/?format=json","web_url":"https://patchwork.libcamera.org/patch/10935/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210121165305.367801-8-jacopo@jmondi.org>","date":"2021-01-21T16:53:05","name":"[libcamera-devel,7/7] android: camera_metadata: Remove outdated comment","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e9a79f8f98fee83dcacb36e472d48576bb486050","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/10935/mbox/","series":[{"id":1593,"url":"https://patchwork.libcamera.org/api/series/1593/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1593","date":"2021-01-21T16:52:58","name":"android: camera device and metadata improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/1593/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10935/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10935/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2ADCBD808\n\tfor ;\n\tThu, 21 Jan 2021 16:53:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 774B668211;\n\tThu, 21 Jan 2021 17:53:04 +0100 (CET)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC11868215\n\tfor ;\n\tThu, 21 Jan 2021 17:52:59 +0100 (CET)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 645D61C0015;\n\tThu, 21 Jan 2021 16:52:59 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org,\n\tPaul Elder ","Date":"Thu, 21 Jan 2021 17:53:05 +0100","Message-Id":"<20210121165305.367801-8-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20210121165305.367801-1-jacopo@jmondi.org>","References":"<20210121165305.367801-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 7/7] android: camera_metadata: Remove\n\toutdated comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The comment was moot, as the translation of Android's settings\nto libcamera controls is already implemented in a dedicated function.\n\nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 7 +------\n 1 file changed, 1 insertion(+), 6 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex d185fdf7fb2f..f9af038412b1 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1629,12 +1629,7 @@ int CameraDevice::processControls(Camera3RequestDescriptor *descriptor)\n \tif (!settings.isValid())\n \t\treturn 0;\n \n-\t/*\n-\t * Translate the Android controls to libcamera.\n-\t *\n-\t * \\todo As soon as more controls are handled, this part should be\n-\t * broken out to a dedicated function.\n-\t */\n+\t/* Translate the Android request settings to libcamera controls. */\n \tcamera_metadata_ro_entry_t entry;\n \tbool found = settings.getEntry(ANDROID_SCALER_CROP_REGION, &entry);\n \tif (found) {\n","prefixes":["libcamera-devel","7/7"]}