[{"id":14672,"web_url":"https://patchwork.libcamera.org/comment/14672/","msgid":"","date":"2021-01-21T21:36:31","subject":"Re: [libcamera-devel] [PATCH 4/7] android: camera_metadata: Add\n\tdefaul constructor","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Jan 21, 2021 at 05:53:02PM +0100, Jacopo Mondi wrote:\n> Add a default constructor that initializes a non valid CameraMetadata\n> to allow embedding instances of the class in other types.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_metadata.cpp | 5 +++++\n> src/android/camera_metadata.h | 1 +\n> 2 files changed, 6 insertions(+)\n> \n> diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\n> index 8e36e758d231..6f1bcdbe274a 100644\n> --- a/src/android/camera_metadata.cpp\n> +++ b/src/android/camera_metadata.cpp\n> @@ -13,6 +13,11 @@ using namespace libcamera;\n> \n> LOG_DEFINE_CATEGORY(CameraMetadata)\n> \n> +CameraMetadata::CameraMetadata()\n> +\t: metadata_(nullptr), valid_(false)\n> +{\n> +}\n> +\n> CameraMetadata::CameraMetadata(size_t entryCapacity, size_t dataCapacity)\n> {\n> \tmetadata_ = allocate_camera_metadata(entryCapacity, dataCapacity);\n> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> index 720b760d44da..d653e2f0f502 100644\n> --- a/src/android/camera_metadata.h\n> +++ b/src/android/camera_metadata.h\n> @@ -14,6 +14,7 @@\n> class CameraMetadata\n> {\n> public:\n> +\tCameraMetadata();\n> \tCameraMetadata(size_t entryCapacity, size_t dataCapacity);\n> \tCameraMetadata(const camera_metadata_t *metadata);\n> \tCameraMetadata(const CameraMetadata &other);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 369B6BD808\n\tfor ;\n\tThu, 21 Jan 2021 21:36:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 038CA68220;\n\tThu, 21 Jan 2021 22:36:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 745FB68220\n\tfor ;\n\tThu, 21 Jan 2021 22:36:49 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0C97650E;\n\tThu, 21 Jan 2021 22:36:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hGDddtIB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611265009;\n\tbh=Zm6OF0OOwTr6cTrvPig3bDFvLIfiFnUCb/GK6U2l9/A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hGDddtIBGwyaOMMEPuqvALWJGLFHi9TFMSwJzpENpuP70HT36/SOAjlgddDfVcMmB\n\tOmNTzxmZdNdvcB1LD1TCoD/+DMZ00GuWYxDmd1w4HD262B+eVrbuhFWchKjsYej3yg\n\ty9G1MlnsmMYC8+RK0ruzFcztt0qhIQ2v7JEWDfZE=","Date":"Thu, 21 Jan 2021 23:36:31 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210121165305.367801-1-jacopo@jmondi.org>\n\t<20210121165305.367801-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210121165305.367801-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 4/7] android: camera_metadata: Add\n\tdefaul constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14679,"web_url":"https://patchwork.libcamera.org/comment/14679/","msgid":"<20210122035807.GF1943@pyrite.rasen.tech>","date":"2021-01-22T03:58:07","subject":"Re: [libcamera-devel] [PATCH 4/7] android: camera_metadata: Add\n\tdefaul constructor","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Thu, Jan 21, 2021 at 05:53:02PM +0100, Jacopo Mondi wrote:\n> Add a default constructor that initializes a non valid CameraMetadata\n> to allow embedding instances of the class in other types.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/android/camera_metadata.cpp | 5 +++++\n> src/android/camera_metadata.h | 1 +\n> 2 files changed, 6 insertions(+)\n> \n> diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\n> index 8e36e758d231..6f1bcdbe274a 100644\n> --- a/src/android/camera_metadata.cpp\n> +++ b/src/android/camera_metadata.cpp\n> @@ -13,6 +13,11 @@ using namespace libcamera;\n> \n> LOG_DEFINE_CATEGORY(CameraMetadata)\n> \n> +CameraMetadata::CameraMetadata()\n> +\t: metadata_(nullptr), valid_(false)\n> +{\n> +}\n> +\n> CameraMetadata::CameraMetadata(size_t entryCapacity, size_t dataCapacity)\n> {\n> \tmetadata_ = allocate_camera_metadata(entryCapacity, dataCapacity);\n> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> index 720b760d44da..d653e2f0f502 100644\n> --- a/src/android/camera_metadata.h\n> +++ b/src/android/camera_metadata.h\n> @@ -14,6 +14,7 @@\n> class CameraMetadata\n> {\n> public:\n> +\tCameraMetadata();\n> \tCameraMetadata(size_t entryCapacity, size_t dataCapacity);\n> \tCameraMetadata(const camera_metadata_t *metadata);\n> \tCameraMetadata(const CameraMetadata &other);\n> -- \n> 2.29.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 510A0BD808\n\tfor ;\n\tFri, 22 Jan 2021 03:58:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB77E68227;\n\tFri, 22 Jan 2021 04:58:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 81EE568212\n\tfor ;\n\tFri, 22 Jan 2021 04:58:15 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D870650E;\n\tFri, 22 Jan 2021 04:58:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WlFcGwi7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611287895;\n\tbh=6mQrKdBa7b0V4EUmaeXmVpsO5IqGF14RnLmOqvBlBp0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WlFcGwi7JnYsdmoC+WPDJLghXoPYmgKhGoHi+1K9TFPOB57mPMLtvkC0Zlp5AunHa\n\tJKQckYFEkEjd7BGbDm55edr+JEvpOyQt+fLoz+Tf4VuyYDdhsb1jM2H9O21ayoJrJC\n\tljcO1zjK65JAqHKc6iTbc2SYdJ85FKtSSGq8lHBw=","Date":"Fri, 22 Jan 2021 12:58:07 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20210122035807.GF1943@pyrite.rasen.tech>","References":"<20210121165305.367801-1-jacopo@jmondi.org>\n\t<20210121165305.367801-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210121165305.367801-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 4/7] android: camera_metadata: Add\n\tdefaul constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]