[{"id":14644,"web_url":"https://patchwork.libcamera.org/comment/14644/","msgid":"<20210121113608.wnfcxixw2gdqdkmm@uno.localdomain>","date":"2021-01-21T11:36:08","subject":"Re: [libcamera-devel] [PATCH v2 7/9] android: camera_device: Use\n\tCameraMetadata wrapper in processControls","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Thu, Jan 21, 2021 at 07:15:47PM +0900, Paul Elder wrote:\n> Use the CameraMetadata wrapper to access android request settings\n> instead of accessing camera_metadata_t directly.\n>\n> Signed-off-by: Paul Elder \n>\n> ---\n> New in v2\n> ---\n> src/android/camera_device.cpp | 8 +++-----\n> 1 file changed, 3 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 16d5b472..49af221b 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1639,12 +1639,10 @@ int CameraDevice::processControls(camera3_capture_request_t *camera3Request,\n> \t * \\todo As soon as more controls are handled, this part should be\n> \t * broke out to a dedicated function.\n> \t */\n> -\tconst camera_metadata_t *camera3Settings = camera3Request->settings;\n> +\tCameraMetadata camera3Settings(camera3Request->settings);\n\nI think it is very unfortunate that we clone a full metadata pack just\nto inspect it. In [8/9] you clone the metadata at processRequest\nbeginning, and you should be able to re-use it here.\n\nThe settings shall actually be cloned in the Camera3RequestDescriptor\nconstructor, as it can be made to accept the full\ncamera3_capture_request_t.\n\nI have an implementation of that which I was waiting to rebase on your\nCameraMetadata change. What do you think if I break out your [2/9] and\nhandle the conversion here ? It should be rather quick and if we\nfast-track it you can remove it from your series (I keep thinking you\nshould have broke out the Camera3RequestDescriptor change in 6/9 from\nthe handling of JPEG related metadata)\n\nThanks\n j\n\n> \tcamera_metadata_ro_entry_t entry;\n> -\tint ret = find_camera_metadata_ro_entry(camera3Settings,\n> -\t\t\t\t\t\tANDROID_SCALER_CROP_REGION,\n> -\t\t\t\t\t\t&entry);\n> -\tif (!ret) {\n> +\tint ret = camera3Settings.getEntry(ANDROID_SCALER_CROP_REGION, &entry);\n> +\tif (ret) {\n> \t\tconst int32_t *data = entry.data.i32;\n> \t\tRectangle cropRegion = { data[0], data[1],\n> \t\t\t\t\t static_cast(data[2]),\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 28DECC0F2A\n\tfor ;\n\tThu, 21 Jan 2021 11:35:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BD7BE681C3;\n\tThu, 21 Jan 2021 12:35:51 +0100 (CET)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C63B968193\n\tfor ;\n\tThu, 21 Jan 2021 12:35:50 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 3F544E000A;\n\tThu, 21 Jan 2021 11:35:49 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Thu, 21 Jan 2021 12:36:08 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20210121113608.wnfcxixw2gdqdkmm@uno.localdomain>","References":"<20210121101549.134574-1-paul.elder@ideasonboard.com>\n\t<20210121101549.134574-8-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210121101549.134574-8-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 7/9] android: camera_device: Use\n\tCameraMetadata wrapper in processControls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14645,"web_url":"https://patchwork.libcamera.org/comment/14645/","msgid":"<20210121114143.5zdruuamswj3chvn@uno.localdomain>","date":"2021-01-21T11:41:43","subject":"Re: [libcamera-devel] [PATCH v2 7/9] android: camera_device: Use\n\tCameraMetadata wrapper in processControls","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Thu, Jan 21, 2021 at 12:36:08PM +0100, Jacopo Mondi wrote:\n> Hi Paul,\n>\n> On Thu, Jan 21, 2021 at 07:15:47PM +0900, Paul Elder wrote:\n> > Use the CameraMetadata wrapper to access android request settings\n> > instead of accessing camera_metadata_t directly.\n> >\n> > Signed-off-by: Paul Elder \n> >\n> > ---\n> > New in v2\n> > ---\n> > src/android/camera_device.cpp | 8 +++-----\n> > 1 file changed, 3 insertions(+), 5 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 16d5b472..49af221b 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -1639,12 +1639,10 @@ int CameraDevice::processControls(camera3_capture_request_t *camera3Request,\n> > \t * \\todo As soon as more controls are handled, this part should be\n> > \t * broke out to a dedicated function.\n> > \t */\n> > -\tconst camera_metadata_t *camera3Settings = camera3Request->settings;\n> > +\tCameraMetadata camera3Settings(camera3Request->settings);\n>\n> I think it is very unfortunate that we clone a full metadata pack just\n> to inspect it. In [8/9] you clone the metadata at processRequest\n> beginning, and you should be able to re-use it here.\n>\n> The settings shall actually be cloned in the Camera3RequestDescriptor\n> constructor, as it can be made to accept the full\n> camera3_capture_request_t.\n>\n> I have an implementation of that which I was waiting to rebase on your\n> CameraMetadata change. What do you think if I break out your [2/9] and\n> handle the conversion here ? It should be rather quick and if we\n> fast-track it you can remove it from your series (I keep thinking you\n> should have broke out the Camera3RequestDescriptor change in 6/9 from\n\nSorry, I mean [8/9] not 6/9\n\n> the handling of JPEG related metadata)\n>\n> Thanks\n> j\n>\n> > \tcamera_metadata_ro_entry_t entry;\n> > -\tint ret = find_camera_metadata_ro_entry(camera3Settings,\n> > -\t\t\t\t\t\tANDROID_SCALER_CROP_REGION,\n> > -\t\t\t\t\t\t&entry);\n> > -\tif (!ret) {\n> > +\tint ret = camera3Settings.getEntry(ANDROID_SCALER_CROP_REGION, &entry);\n> > +\tif (ret) {\n> > \t\tconst int32_t *data = entry.data.i32;\n> > \t\tRectangle cropRegion = { data[0], data[1],\n> > \t\t\t\t\t static_cast(data[2]),\n> > --\n> > 2.27.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8C2ABD808\n\tfor ;\n\tThu, 21 Jan 2021 11:41:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5045C681C8;\n\tThu, 21 Jan 2021 12:41:26 +0100 (CET)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5283A68193\n\tfor ;\n\tThu, 21 Jan 2021 12:41:25 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D952BC000B;\n\tThu, 21 Jan 2021 11:41:24 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Thu, 21 Jan 2021 12:41:43 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20210121114143.5zdruuamswj3chvn@uno.localdomain>","References":"<20210121101549.134574-1-paul.elder@ideasonboard.com>\n\t<20210121101549.134574-8-paul.elder@ideasonboard.com>\n\t<20210121113608.wnfcxixw2gdqdkmm@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210121113608.wnfcxixw2gdqdkmm@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v2 7/9] android: camera_device: Use\n\tCameraMetadata wrapper in processControls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14661,"web_url":"https://patchwork.libcamera.org/comment/14661/","msgid":"","date":"2021-01-21T19:47:14","subject":"Re: [libcamera-devel] [PATCH v2 7/9] android: camera_device: Use\n\tCameraMetadata wrapper in processControls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo and Paul,\n\nOn Thu, Jan 21, 2021 at 12:36:08PM +0100, Jacopo Mondi wrote:\n> On Thu, Jan 21, 2021 at 07:15:47PM +0900, Paul Elder wrote:\n> > Use the CameraMetadata wrapper to access android request settings\n> > instead of accessing camera_metadata_t directly.\n\nThis describes what the patch does, but should also tell why.\n\n> > Signed-off-by: Paul Elder \n> >\n> > ---\n> > New in v2\n> > ---\n> > src/android/camera_device.cpp | 8 +++-----\n> > 1 file changed, 3 insertions(+), 5 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 16d5b472..49af221b 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -1639,12 +1639,10 @@ int CameraDevice::processControls(camera3_capture_request_t *camera3Request,\n> > \t * \\todo As soon as more controls are handled, this part should be\n> > \t * broke out to a dedicated function.\n> > \t */\n> > -\tconst camera_metadata_t *camera3Settings = camera3Request->settings;\n> > +\tCameraMetadata camera3Settings(camera3Request->settings);\n> \n> I think it is very unfortunate that we clone a full metadata pack just\n> to inspect it. In [8/9] you clone the metadata at processRequest\n> beginning, and you should be able to re-use it here.\n> \n> The settings shall actually be cloned in the Camera3RequestDescriptor\n> constructor, as it can be made to accept the full\n> camera3_capture_request_t.\n\nI like that, it will simplify the constructor of\nCamera3RequestDescriptor to call it with just\n\n\tCamera3RequestDescriptor(camera_.get(), camera3Request)\n\n> I have an implementation of that which I was waiting to rebase on your\n> CameraMetadata change. What do you think if I break out your [2/9] and\n> handle the conversion here ? It should be rather quick and if we\n> fast-track it you can remove it from your series (I keep thinking you\n> should have broke out the Camera3RequestDescriptor change in 6/9 from\n> the handling of JPEG related metadata)\n\nSounds good to me ! Thanks Jacopo for helping.\n\n> > \tcamera_metadata_ro_entry_t entry;\n> > -\tint ret = find_camera_metadata_ro_entry(camera3Settings,\n> > -\t\t\t\t\t\tANDROID_SCALER_CROP_REGION,\n> > -\t\t\t\t\t\t&entry);\n> > -\tif (!ret) {\n> > +\tint ret = camera3Settings.getEntry(ANDROID_SCALER_CROP_REGION, &entry);\n> > +\tif (ret) {\n> > \t\tconst int32_t *data = entry.data.i32;\n> > \t\tRectangle cropRegion = { data[0], data[1],\n> > \t\t\t\t\t static_cast(data[2]),","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4550EC0F2A\n\tfor ;\n\tThu, 21 Jan 2021 19:47:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA5D968210;\n\tThu, 21 Jan 2021 20:47:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 374E168204\n\tfor ;\n\tThu, 21 Jan 2021 20:47:33 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AA9FA50E;\n\tThu, 21 Jan 2021 20:47:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M/RvqMK8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611258452;\n\tbh=HfjrTXqffJdUst7e5hUZkNiFwaoyC4F/jKhuQMnsrno=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=M/RvqMK8iCaaMiDjauDv3IrLLpj1KKA3cLF1fFl3Osw8zHa/7LoXDgOFEeh7oqCKl\n\tTID2OsRcgoQ1r0fNQ/e4OlLrsf9hqRSGjZdpKdHPTub3jElaH4vjyGbYOEM00DspOF\n\tQN6MMcOFIW81YqNInS8/7SWbv3lSGIqc4aJv0mPI=","Date":"Thu, 21 Jan 2021 21:47:14 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210121101549.134574-1-paul.elder@ideasonboard.com>\n\t<20210121101549.134574-8-paul.elder@ideasonboard.com>\n\t<20210121113608.wnfcxixw2gdqdkmm@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210121113608.wnfcxixw2gdqdkmm@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v2 7/9] android: camera_device: Use\n\tCameraMetadata wrapper in processControls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]