[{"id":14643,"web_url":"https://patchwork.libcamera.org/comment/14643/","msgid":"<20210121112335.zjdbeujnkim6wz5t@uno.localdomain>","date":"2021-01-21T11:23:35","subject":"Re: [libcamera-devel] [PATCH v2 2/9] android: CameraMetadata: Add\n\tcopy constructor and getEntry","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Thu, Jan 21, 2021 at 07:15:42PM +0900, Paul Elder wrote:\n> Add a copy constructor and assigment operator to CameraMetadata, as well\n> a constructor from camera_metadata_t. Also add a function getEntry to\n> allow getting metadata entries from CameraMetadata. This allows us to\n> use CameraMetadata for reading from camera_metadata_t.\n>\n> Signed-off-by: Paul Elder \n>\n> ---\n> Changes in v2:\n> - getEntry returns bool instead of int\n> ---\n> src/android/camera_metadata.cpp | 34 +++++++++++++++++++++++++++++++++\n> src/android/camera_metadata.h | 5 +++++\n> 2 files changed, 39 insertions(+)\n>\n> diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\n> index edea48fe..3b98d25c 100644\n> --- a/src/android/camera_metadata.cpp\n> +++ b/src/android/camera_metadata.cpp\n> @@ -19,12 +19,46 @@ CameraMetadata::CameraMetadata(size_t entryCapacity, size_t dataCapacity)\n> \tvalid_ = metadata_ != nullptr;\n> }\n>\n> +CameraMetadata::CameraMetadata(const camera_metadata_t *metadata)\n> +{\n> +\tmetadata_ = clone_camera_metadata(metadata);\n> +\tvalid_ = metadata_ != nullptr;\n> +}\n> +\n> +CameraMetadata::CameraMetadata(const CameraMetadata &other)\n> +{\n\nThis can probably simply be:\n\nCameraMetadata::CameraMetadata(const CameraMetadata &other)\n : CameraMetadata(other.get())\n{\n}\n\n> +\tmetadata_ = clone_camera_metadata(other.get());\n> +\tvalid_ = metadata_ != nullptr;\n> +}\n> +\n> CameraMetadata::~CameraMetadata()\n> {\n> \tif (metadata_)\n> \t\tfree_camera_metadata(metadata_);\n> }\n>\n> +CameraMetadata &CameraMetadata::operator=(const CameraMetadata &other)\n> +{\n> +\tif (this == &other)\n> +\t\treturn *this;\n\nDo copy assignments need to protect agains this unlikely case ?\n\nAll minors:\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> +\n> +\tif (metadata_)\n> +\t\tfree_camera_metadata(metadata_);\n> +\n> +\tmetadata_ = clone_camera_metadata(other.get());\n> +\tvalid_ = metadata_ != nullptr;\n> +\n> +\treturn *this;\n> +}\n> +\n> +bool CameraMetadata::getEntry(uint32_t tag, camera_metadata_ro_entry_t *entry) const\n> +{\n> +\tif (find_camera_metadata_ro_entry(metadata_, tag, entry))\n> +\t\treturn false;\n> +\n> +\treturn true;\n> +}\n> +\n> bool CameraMetadata::addEntry(uint32_t tag, const void *data, size_t count)\n> {\n> \tif (!valid_)\n> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> index 9d047b1b..720b760d 100644\n> --- a/src/android/camera_metadata.h\n> +++ b/src/android/camera_metadata.h\n> @@ -15,9 +15,14 @@ class CameraMetadata\n> {\n> public:\n> \tCameraMetadata(size_t entryCapacity, size_t dataCapacity);\n> +\tCameraMetadata(const camera_metadata_t *metadata);\n> +\tCameraMetadata(const CameraMetadata &other);\n> \t~CameraMetadata();\n>\n> +\tCameraMetadata &operator=(const CameraMetadata &other);\n> +\n> \tbool isValid() const { return valid_; }\n> +\tbool getEntry(uint32_t tag, camera_metadata_ro_entry_t *entry) const;\n> \tbool addEntry(uint32_t tag, const void *data, size_t data_count);\n> \tbool updateEntry(uint32_t tag, const void *data, size_t data_count);\n>\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26F74BD808\n\tfor ;\n\tThu, 21 Jan 2021 11:23:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A51D7681C8;\n\tThu, 21 Jan 2021 12:23:18 +0100 (CET)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC6E768193\n\tfor ;\n\tThu, 21 Jan 2021 12:23:17 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 6AB751C0026;\n\tThu, 21 Jan 2021 11:23:17 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Thu, 21 Jan 2021 12:23:35 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20210121112335.zjdbeujnkim6wz5t@uno.localdomain>","References":"<20210121101549.134574-1-paul.elder@ideasonboard.com>\n\t<20210121101549.134574-3-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210121101549.134574-3-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/9] android: CameraMetadata: Add\n\tcopy constructor and getEntry","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14664,"web_url":"https://patchwork.libcamera.org/comment/14664/","msgid":"","date":"2021-01-21T20:28:36","subject":"Re: [libcamera-devel] [PATCH v2 2/9] android: CameraMetadata: Add\n\tcopy constructor and getEntry","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Thu, Jan 21, 2021 at 12:23:35PM +0100, Jacopo Mondi wrote:\n> On Thu, Jan 21, 2021 at 07:15:42PM +0900, Paul Elder wrote:\n> > Add a copy constructor and assigment operator to CameraMetadata, as well\n> > a constructor from camera_metadata_t. Also add a function getEntry to\n> > allow getting metadata entries from CameraMetadata. This allows us to\n> > use CameraMetadata for reading from camera_metadata_t.\n> >\n> > Signed-off-by: Paul Elder \n> >\n> > ---\n> > Changes in v2:\n> > - getEntry returns bool instead of int\n> > ---\n> > src/android/camera_metadata.cpp | 34 +++++++++++++++++++++++++++++++++\n> > src/android/camera_metadata.h | 5 +++++\n> > 2 files changed, 39 insertions(+)\n> >\n> > diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\n> > index edea48fe..3b98d25c 100644\n> > --- a/src/android/camera_metadata.cpp\n> > +++ b/src/android/camera_metadata.cpp\n> > @@ -19,12 +19,46 @@ CameraMetadata::CameraMetadata(size_t entryCapacity, size_t dataCapacity)\n> > \tvalid_ = metadata_ != nullptr;\n> > }\n> >\n> > +CameraMetadata::CameraMetadata(const camera_metadata_t *metadata)\n> > +{\n> > +\tmetadata_ = clone_camera_metadata(metadata);\n> > +\tvalid_ = metadata_ != nullptr;\n> > +}\n> > +\n> > +CameraMetadata::CameraMetadata(const CameraMetadata &other)\n> > +{\n> \n> This can probably simply be:\n> \n> CameraMetadata::CameraMetadata(const CameraMetadata &other)\n> : CameraMetadata(other.get())\n> {\n> }\n> \n> > +\tmetadata_ = clone_camera_metadata(other.get());\n> > +\tvalid_ = metadata_ != nullptr;\n> > +}\n> > +\n> > CameraMetadata::~CameraMetadata()\n> > {\n> > \tif (metadata_)\n> > \t\tfree_camera_metadata(metadata_);\n> > }\n> >\n> > +CameraMetadata &CameraMetadata::operator=(const CameraMetadata &other)\n> > +{\n> > +\tif (this == &other)\n> > +\t\treturn *this;\n> \n> Do copy assignments need to protect agains this unlikely case ?\n\nI had never considered this case. It's unlikely undeed, but handled in\nhttps://en.cppreference.com/w/cpp/language/copy_assignment, it seems a\ngood idea to play safe.\n\nReviewed-by: Laurent Pinchart \n\n\n> All minors:\n> Reviewed-by: Jacopo Mondi \n> \n> > +\n> > +\tif (metadata_)\n> > +\t\tfree_camera_metadata(metadata_);\n> > +\n> > +\tmetadata_ = clone_camera_metadata(other.get());\n> > +\tvalid_ = metadata_ != nullptr;\n> > +\n> > +\treturn *this;\n> > +}\n> > +\n> > +bool CameraMetadata::getEntry(uint32_t tag, camera_metadata_ro_entry_t *entry) const\n> > +{\n> > +\tif (find_camera_metadata_ro_entry(metadata_, tag, entry))\n> > +\t\treturn false;\n> > +\n> > +\treturn true;\n> > +}\n> > +\n> > bool CameraMetadata::addEntry(uint32_t tag, const void *data, size_t count)\n> > {\n> > \tif (!valid_)\n> > diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> > index 9d047b1b..720b760d 100644\n> > --- a/src/android/camera_metadata.h\n> > +++ b/src/android/camera_metadata.h\n> > @@ -15,9 +15,14 @@ class CameraMetadata\n> > {\n> > public:\n> > \tCameraMetadata(size_t entryCapacity, size_t dataCapacity);\n> > +\tCameraMetadata(const camera_metadata_t *metadata);\n> > +\tCameraMetadata(const CameraMetadata &other);\n> > \t~CameraMetadata();\n> >\n> > +\tCameraMetadata &operator=(const CameraMetadata &other);\n> > +\n> > \tbool isValid() const { return valid_; }\n> > +\tbool getEntry(uint32_t tag, camera_metadata_ro_entry_t *entry) const;\n> > \tbool addEntry(uint32_t tag, const void *data, size_t data_count);\n> > \tbool updateEntry(uint32_t tag, const void *data, size_t data_count);\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0EA9BD808\n\tfor ;\n\tThu, 21 Jan 2021 20:28:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53FCC68212;\n\tThu, 21 Jan 2021 21:28:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F97B68204\n\tfor ;\n\tThu, 21 Jan 2021 21:28:55 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D04CA50E;\n\tThu, 21 Jan 2021 21:28:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"F2R3Doy+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611260935;\n\tbh=OTYLlTylGLRK4dLThH0fVLTKXlFEqvjs6RrCAaUT4qs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=F2R3Doy+Gr3HOljFgJTiTLqBb4UU7HFTi6nLKK7dvPb6QsLTfmD4vuYRRH59Qat6w\n\ty3DaJevyRrK81PhRdlUJeEuZuIvCW0EfWd4JmKuYA2PuKMOiSbCUAqdGQ31G73hqY3\n\tjNatKy7Motj/Utan+PmmJh7xCQxRzP3EX1aiAP9s=","Date":"Thu, 21 Jan 2021 22:28:36 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210121101549.134574-1-paul.elder@ideasonboard.com>\n\t<20210121101549.134574-3-paul.elder@ideasonboard.com>\n\t<20210121112335.zjdbeujnkim6wz5t@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210121112335.zjdbeujnkim6wz5t@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v2 2/9] android: CameraMetadata: Add\n\tcopy constructor and getEntry","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]