[{"id":14635,"web_url":"https://patchwork.libcamera.org/comment/14635/","msgid":"","date":"2021-01-20T11:50:26","subject":"Re: [libcamera-devel] [PATCH v12 1/3] libcamera: controls: Add\n\tframe duration control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Tue, Jan 19, 2021 at 03:30:45PM +0000, Naushir Patuck wrote:\n> Add an int64_t array control (controls::FrameDurations) to specify the\n> minimum and maximum (in that order) frame duration to be used by the\n> camera sensor.\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n> Tested-by: David Plowman \n> Reviewed-by: Jacopo Mondi \n> ---\n> src/libcamera/control_ids.yaml | 36 ++++++++++++++++++++++++++++++++++\n> 1 file changed, 36 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 6d6f0fee508b..36c37161a3d5 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -306,6 +306,42 @@ controls:\n> maximum valid value is given by the properties::ScalerCropMaximum\n> property, and the two can be used to implement digital zoom.\n> \n> + - FrameDurations:\n> + type: int64_t\n> + description: |\n> + The minimum and maximum (in that order) frame duration,\n> + expressed in micro-seconds.\n\ns/micro-seconds/microseconds/\n\n(The indentation should be 2 spaces btw)\n\nI'll handle this when applying.\n\nReviewed-by: Laurent Pinchart \n\n> +\n> + When provided by applications, the control specifies the sensor frame\n> + duration interval the pipeline has to use. This limits the largest\n> + exposure time the sensor can use. For example, if a maximum frame\n> + duration of 33ms is requested (corresponding to 30 frames per second),\n> + the sensor will not be able to raise the exposure time above 33ms.\n> + A fixed frame duration is achieved by setting the minimum and maximum\n> + values to be the same. Setting both values to 0 reverts to using the\n> + IPA provided defaults.\n> +\n> + The maximum frame duration provides the absolute limit to the shutter\n> + speed computed by the AE algorithm and it overrides any exposure mode\n> + setting specified with controls::AeExposureMode. Similarly, when a\n> + manual exposure time is set through controls::ExposureTime, it also\n> + gets clipped to the limits set by this control. When reported in\n> + metadata, the control expresses the minimum and maximum frame\n> + durations used after being clipped to the sensor provided frame\n> + duration limits.\n> +\n> + \\sa AeExposureMode\n> + \\sa ExposureTime\n> +\n> + \\todo Define how to calculate the capture frame rate by\n> + defining controls to report additional delays introduced by\n> + the capture pipeline or post-processing stages (ie JPEG\n> + conversion, frame scaling).\n> +\n> + \\todo Provide an explicit definition of default control values, for\n> + this and all other controls.\n> + size: [2]\n> +\n> # ----------------------------------------------------------------------------\n> # Draft controls section\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0F0AC0F2A\n\tfor ;\n\tWed, 20 Jan 2021 11:50:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5ED9C681AD;\n\tWed, 20 Jan 2021 12:50:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BB88681A6\n\tfor ;\n\tWed, 20 Jan 2021 12:50:44 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7FA02813;\n\tWed, 20 Jan 2021 12:50:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WPB7KBbX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611143443;\n\tbh=O7d6+9bdzywzMqHoQY7s4G+6JUsdF9hBTLb/8zcIJqI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WPB7KBbXkJk+3mFHYTctkZT5ibbe31Cl2CY4f+TEa48yf085iufLpjvN2LQ49YZVG\n\tRtxbs2UcIqi7zTY1jK67MhoxcC2UaSGcQ6pIv71IwjlrOcQZTOkgxnN5wh8OIhX3bc\n\tNMx0YvMP+fumqg9Pe0r754/Kebz7fsSVbdngLlhE=","Date":"Wed, 20 Jan 2021 13:50:26 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20210119153047.468190-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210119153047.468190-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v12 1/3] libcamera: controls: Add\n\tframe duration control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14636,"web_url":"https://patchwork.libcamera.org/comment/14636/","msgid":"","date":"2021-01-20T11:54:38","subject":"Re: [libcamera-devel] [PATCH v12 1/3] libcamera: controls: Add\n\tframe duration control","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\n\nOn Wed, 20 Jan 2021 at 11:50, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Tue, Jan 19, 2021 at 03:30:45PM +0000, Naushir Patuck wrote:\n> > Add an int64_t array control (controls::FrameDurations) to specify the\n> > minimum and maximum (in that order) frame duration to be used by the\n> > camera sensor.\n> >\n> > Signed-off-by: Naushir Patuck \n> > Reviewed-by: David Plowman \n> > Tested-by: David Plowman \n> > Reviewed-by: Jacopo Mondi \n> > ---\n> > src/libcamera/control_ids.yaml | 36 ++++++++++++++++++++++++++++++++++\n> > 1 file changed, 36 insertions(+)\n> >\n> > diff --git a/src/libcamera/control_ids.yaml\n> b/src/libcamera/control_ids.yaml\n> > index 6d6f0fee508b..36c37161a3d5 100644\n> > --- a/src/libcamera/control_ids.yaml\n> > +++ b/src/libcamera/control_ids.yaml\n> > @@ -306,6 +306,42 @@ controls:\n> > maximum valid value is given by the\n> properties::ScalerCropMaximum\n> > property, and the two can be used to implement digital zoom.\n> >\n> > + - FrameDurations:\n> > + type: int64_t\n> > + description: |\n> > + The minimum and maximum (in that order) frame duration,\n> > + expressed in micro-seconds.\n>\n> s/micro-seconds/microseconds/\n>\n> (The indentation should be 2 spaces btw)\n>\n> I'll handle this when applying.\n>\n\nThank you! Apologies that I missed fixing those typos you pointed out\nearlier.\n\nRegards,\nNaush\n\n\n>\n> Reviewed-by: Laurent Pinchart \n>\n\n> > +\n> > + When provided by applications, the control specifies the\n> sensor frame\n> > + duration interval the pipeline has to use. This limits the\n> largest\n> > + exposure time the sensor can use. For example, if a maximum\n> frame\n> > + duration of 33ms is requested (corresponding to 30 frames per\n> second),\n> > + the sensor will not be able to raise the exposure time above\n> 33ms.\n> > + A fixed frame duration is achieved by setting the minimum and\n> maximum\n> > + values to be the same. Setting both values to 0 reverts to\n> using the\n> > + IPA provided defaults.\n> > +\n> > + The maximum frame duration provides the absolute limit to the\n> shutter\n> > + speed computed by the AE algorithm and it overrides any\n> exposure mode\n> > + setting specified with controls::AeExposureMode. Similarly,\n> when a\n> > + manual exposure time is set through controls::ExposureTime,\n> it also\n> > + gets clipped to the limits set by this control. When reported\n> in\n> > + metadata, the control expresses the minimum and maximum frame\n> > + durations used after being clipped to the sensor provided\n> frame\n> > + duration limits.\n> > +\n> > + \\sa AeExposureMode\n> > + \\sa ExposureTime\n> > +\n> > + \\todo Define how to calculate the capture frame rate by\n> > + defining controls to report additional delays introduced by\n> > + the capture pipeline or post-processing stages (ie JPEG\n> > + conversion, frame scaling).\n> > +\n> > + \\todo Provide an explicit definition of default control\n> values, for\n> > + this and all other controls.\n> > + size: [2]\n> > +\n> > #\n> ----------------------------------------------------------------------------\n> > # Draft controls section\n> >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C9A0BD808\n\tfor ;\n\tWed, 20 Jan 2021 11:54:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0EF50681B6;\n\tWed, 20 Jan 2021 12:54:57 +0100 (CET)","from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E64FC681A6\n\tfor ;\n\tWed, 20 Jan 2021 12:54:55 +0100 (CET)","by mail-lj1-x22b.google.com with SMTP id j3so6021689ljb.9\n\tfor ;\n\tWed, 20 Jan 2021 03:54:55 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"YRwzRGyG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=BOHx3zmvcAOgiC7t8gCdGxHzTUkhNXZdU2kUHPZY0Fc=;\n\tb=YRwzRGyGapS9qp22WKMbDef46g0ZwlnKYJ6IYAW19tYuQhQrzVmlruxQREUqktbdOh\n\tMExVFmIPbmum+B4dkF7BuKGKQxEsyP9OM/ImcZ4vkz72H0HoJY48oVno0KblsOd0quNF\n\t1eFqmCVgFkPnFvHp3hLQ+a0JfITeSMNvph7qKY0WTSt/AaXUudF1kuLFvlxYesQAPZZ7\n\tfRP5P+UbyeigwPfKcYm3ExW/jcvSHdaqrq5INiwu7ulbgSs541hdmMgsJGM7AnJFtWp1\n\tIiu2Ffq3aocwLn7seI6l83Ydqxl3zAbkHJrp7ojs6pzXPShCFAFyc4gb4otXeOCdMPmT\n\tmkwQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=BOHx3zmvcAOgiC7t8gCdGxHzTUkhNXZdU2kUHPZY0Fc=;\n\tb=k525FmYQZjNvxbkff8mKNVne7zv8hyxSYzw1xr/wLqeBkEPM4HxX4l/0LUGTWlMGSq\n\tv9OdYsT5Vylh36sQ3gFf2EiQL/pgNow6KTA6Uqefj6xLPpbKQd0/NWXSCwIHMUFXIMLn\n\tXz66BSOijmRPtwNtRnOCMTQePy2iJM9MraUtGZXbz1w1bQIX2RBkSsikAt47sB+E8TE3\n\tGvPjoMZD/20ml9uH+6pcX3nr0FuRIbm4flvOdMEKHoRagN/5KwhL83n1xIJt4RYnQqkh\n\tiEobhjDn739zzCQCZB2q/GewUqasEQEbyuo1+7F69egFvGVKXcPgVybTIHymQPEMAYEb\n\tbKyg==","X-Gm-Message-State":"AOAM530QhfvNPCQ21L/Cr7w5GiYhNClIZv+ROOhGy500Rqr3KowtVEsm\n\tTNHt5bUaM4j08ns0YZ6/603k1fAH8W2FC2ydwsMB/BIIplr1Pg==","X-Google-Smtp-Source":"ABdhPJwipyvid/8VB3z1tFjf6VDnxUp6+61ykbpCVlnoRu5KX6Gecz2jSO5V6NYbNOvXUFGa+jGNvTe61t+TsEECXY8=","X-Received":"by 2002:a2e:9b13:: with SMTP id u19mr4024881lji.48.1611143695337;\n\tWed, 20 Jan 2021 03:54:55 -0800 (PST)","MIME-Version":"1.0","References":"<20210119153047.468190-1-naush@raspberrypi.com>\n\t","In-Reply-To":"","From":"Naushir Patuck ","Date":"Wed, 20 Jan 2021 11:54:38 +0000","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v12 1/3] libcamera: controls: Add\n\tframe duration control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============4136432173583068976==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14638,"web_url":"https://patchwork.libcamera.org/comment/14638/","msgid":"","date":"2021-01-20T12:16:36","subject":"Re: [libcamera-devel] [PATCH v12 1/3] libcamera: controls: Add\n\tframe duration control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nOn Wed, Jan 20, 2021 at 11:54:38AM +0000, Naushir Patuck wrote:\n> On Wed, 20 Jan 2021 at 11:50, Laurent Pinchart wrote:\n> > On Tue, Jan 19, 2021 at 03:30:45PM +0000, Naushir Patuck wrote:\n> > > Add an int64_t array control (controls::FrameDurations) to specify the\n> > > minimum and maximum (in that order) frame duration to be used by the\n> > > camera sensor.\n> > >\n> > > Signed-off-by: Naushir Patuck \n> > > Reviewed-by: David Plowman \n> > > Tested-by: David Plowman \n> > > Reviewed-by: Jacopo Mondi \n> > > ---\n> > > src/libcamera/control_ids.yaml | 36 ++++++++++++++++++++++++++++++++++\n> > > 1 file changed, 36 insertions(+)\n> > >\n> > > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > > index 6d6f0fee508b..36c37161a3d5 100644\n> > > --- a/src/libcamera/control_ids.yaml\n> > > +++ b/src/libcamera/control_ids.yaml\n> > > @@ -306,6 +306,42 @@ controls:\n> > > maximum valid value is given by the properties::ScalerCropMaximum\n> > > property, and the two can be used to implement digital zoom.\n> > >\n> > > + - FrameDurations:\n> > > + type: int64_t\n> > > + description: |\n> > > + The minimum and maximum (in that order) frame duration,\n> > > + expressed in micro-seconds.\n> >\n> > s/micro-seconds/microseconds/\n> >\n> > (The indentation should be 2 spaces btw)\n> >\n> > I'll handle this when applying.\n> \n> Thank you! Apologies that I missed fixing those typos you pointed out\n> earlier.\n\nNo worries at all. I've now pushed the series.\n\n> > Reviewed-by: Laurent Pinchart \n> >\n> > > +\n> > > + When provided by applications, the control specifies the sensor frame\n> > > + duration interval the pipeline has to use. This limits the largest\n> > > + exposure time the sensor can use. For example, if a maximum frame\n> > > + duration of 33ms is requested (corresponding to 30 frames per second),\n> > > + the sensor will not be able to raise the exposure time above 33ms.\n> > > + A fixed frame duration is achieved by setting the minimum and maximum\n> > > + values to be the same. Setting both values to 0 reverts to using the\n> > > + IPA provided defaults.\n> > > +\n> > > + The maximum frame duration provides the absolute limit to the shutter\n> > > + speed computed by the AE algorithm and it overrides any exposure mode\n> > > + setting specified with controls::AeExposureMode. Similarly, when a\n> > > + manual exposure time is set through controls::ExposureTime, it also\n> > > + gets clipped to the limits set by this control. When reported in\n> > > + metadata, the control expresses the minimum and maximum frame\n> > > + durations used after being clipped to the sensor provided frame\n> > > + duration limits.\n> > > +\n> > > + \\sa AeExposureMode\n> > > + \\sa ExposureTime\n> > > +\n> > > + \\todo Define how to calculate the capture frame rate by\n> > > + defining controls to report additional delays introduced by\n> > > + the capture pipeline or post-processing stages (ie JPEG\n> > > + conversion, frame scaling).\n> > > +\n> > > + \\todo Provide an explicit definition of default control values, for\n> > > + this and all other controls.\n> > > + size: [2]\n> > > +\n> > > # ----------------------------------------------------------------------------\n> > > # Draft controls section\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8F59ABD808\n\tfor ;\n\tWed, 20 Jan 2021 12:16:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C418681B3;\n\tWed, 20 Jan 2021 13:16:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A884D6819D\n\tfor ;\n\tWed, 20 Jan 2021 13:16:54 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1AAA8813;\n\tWed, 20 Jan 2021 13:16:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U6PzpfbU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611145014;\n\tbh=zlXjWkyiBCaZ2BQ0NX6MO6jhFfyy/fek5e8tKf1nsmU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=U6PzpfbUmhbnez/elh8w9NnICraJ3f1Yq2jTmf9/pZkoEjNjUMXDFJ9GiJOYxsBb6\n\twFbKsQydQea1ARkIUpBWVdmqrcVlN089hwd4V7g5p56Va3X71J8DdZbkgo43i3Ai7t\n\tFyGeK8gMF0fu9ckTWIZOKKwSxhaMi8w3ZJyxEcao=","Date":"Wed, 20 Jan 2021 14:16:36 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20210119153047.468190-1-naush@raspberrypi.com>\n\t\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v12 1/3] libcamera: controls: Add\n\tframe duration control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]