{"id":10898,"url":"https://patchwork.libcamera.org/api/patches/10898/?format=json","web_url":"https://patchwork.libcamera.org/patch/10898/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210119143711.153517-11-jacopo@jmondi.org>","date":"2021-01-19T14:37:10","name":"[libcamera-devel,v2,10/11] android: camera_device: Support AWB_AUTO","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e6c864878588e3e9ac049a4bb35571b3519c84a6","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/10898/mbox/","series":[{"id":1584,"url":"https://patchwork.libcamera.org/api/series/1584/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1584","date":"2021-01-19T14:37:00","name":"android: Exposure times + scaler crop + android metadata","version":2,"mbox":"https://patchwork.libcamera.org/series/1584/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10898/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10898/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE2FFBD808\n\tfor ;\n\tTue, 19 Jan 2021 14:37:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 93EEA6814E;\n\tTue, 19 Jan 2021 15:37:06 +0100 (CET)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5961468156\n\tfor ;\n\tTue, 19 Jan 2021 15:37:01 +0100 (CET)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 20F52C0007\n\tfor ;\n\tTue, 19 Jan 2021 14:37:00 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 19 Jan 2021 15:37:10 +0100","Message-Id":"<20210119143711.153517-11-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20210119143711.153517-1-jacopo@jmondi.org>","References":"<20210119143711.153517-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 10/11] android: camera_device: Support\n\tAWB_AUTO","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Claim support for the AWB_AUTO mode in the\nANDROID_CONTROL_AWB_AVAILABLE_MODES static metadata.\n\nThis fixes the CTS test error:\nandroid.hardware.camera2.cts.CaptureRequestTest#testAwbModeAndLock fail\nThe static info key 'android.control.awbAvailableModes'\nAll camera devices must support AUTO mode\n\nReviewed-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 5600d32cd2b9..759625b35963 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -801,8 +801,12 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\t\t\t availableStabilizationModes.data(),\n \t\t\t\t availableStabilizationModes.size());\n \n+\t/*\n+\t * \\todo Inspect the Camera capabilities to report the available\n+\t * AWB modes. Default to AUTO as CTS tests require it.\n+\t */\n \tstd::vector availableAwbModes = {\n-\t\tANDROID_CONTROL_AWB_MODE_OFF,\n+\t\tANDROID_CONTROL_AWB_MODE_AUTO,\n \t};\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AWB_AVAILABLE_MODES,\n \t\t\t\t availableAwbModes.data(),\n","prefixes":["libcamera-devel","v2","10/11"]}