[{"id":14757,"web_url":"https://patchwork.libcamera.org/comment/14757/","msgid":"","date":"2021-01-25T11:35:28","subject":"Re: [libcamera-devel] [PATCH v2 08/11] libcamera: ipu3: Report\n\tScalerCrop in metadata","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Jan 19, 2021 at 03:37:08PM +0100, Jacopo Mondi wrote:\n> Report in the Request metadata the scaler crop region as requested by\n> application through the request controls. No actual scaling is applied\n> in the pipeline at the moment.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index fc5592f33032..329b9d51cf1b 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -968,6 +968,11 @@ void IPU3CameraData::imguOutputBufferReady(FrameBuffer *buffer)\n> \trequest->metadata().set(controls::draft::PipelineDepth, 3);\n> \t/* \\todo Move the ExposureTime control to the IPA. */\n> \trequest->metadata().set(controls::ExposureTime, exposureTime_);\n> +\t/* \\todo Handle the scaler crop region for each request. */\n\nMaybe \"Actually apply the scaler crop region to the ImgU\" ?\n\nReviewed-by: Laurent Pinchart \n\n> +\tif (request->controls().contains(controls::ScalerCrop)) {\n> +\t\tRectangle cropRegion = request->controls().get(controls::ScalerCrop);\n> +\t\trequest->metadata().set(controls::ScalerCrop, cropRegion);\n> +\t}\n> \tpipe_->completeRequest(request);\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9BD52C0F2B\n\tfor ;\n\tMon, 25 Jan 2021 11:35:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 215CF682C2;\n\tMon, 25 Jan 2021 12:35:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4E19682BB\n\tfor ;\n\tMon, 25 Jan 2021 12:35:48 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 197FC331;\n\tMon, 25 Jan 2021 12:35:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d3FJFHCh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611574548;\n\tbh=7dyYJEAHVNF/He+z+TraQUmFp9xw9E+M38zEQ6P+8hU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=d3FJFHChyFwPVn7y1P4/voHf7uiK5NvXq8bTtAXT6SuiZX67vFGIP83zm9l1dp2M/\n\tq6bvCE3+jfZitee7LBMT6ceOiWAqhDIPsD0oqdnzbSO0XnnhltTFL7hCdhMebPVymk\n\tfySqHCBrn4GTYr9RvibIogUYhSkvO8KtjBVZsE74=","Date":"Mon, 25 Jan 2021 13:35:28 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210119143711.153517-1-jacopo@jmondi.org>\n\t<20210119143711.153517-9-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210119143711.153517-9-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 08/11] libcamera: ipu3: Report\n\tScalerCrop in metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]