[{"id":14756,"web_url":"https://patchwork.libcamera.org/comment/14756/","msgid":"","date":"2021-01-25T11:33:02","subject":"Re: [libcamera-devel] [PATCH v2 07/11] android: camera_device:\n\tRegister MAX_DIGITAL_ZOOM","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Jan 19, 2021 at 03:37:07PM +0100, Jacopo Mondi wrote:\n> Register the ANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM static metadata\n> inspecting the ScalerCrop control's limits.\n> \n> Reviewed-by: Niklas Söderlund \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 23 ++++++++++++++++++++---\n> 1 file changed, 20 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 0484bb9a6557..14068e313f74 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1011,9 +1011,26 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t}\n> \n> \t/* Scaler static metadata. */\n> -\tfloat maxDigitalZoom = 1;\n> -\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM,\n> -\t\t\t\t &maxDigitalZoom, 1);\n> +\t{\n> +\t\t/*\n> +\t\t * \\todo The digital zoom factor is a property that depends\n> +\t\t * on the desired output configuration and the sensor frame size\n> +\t\t * input to the ISP. This information are not available to the\n\ns/are not/is not/\n\n> +\t\t * Android HAL, not at initialization time at least.\n> +\t\t *\n> +\t\t * As a workaround rely on pipeline handlers initializing the\n> +\t\t * ScalerCrop control with the camera default configuration and\n> +\t\t * use the maximum and minimum crop rectangles to calculate the\n> +\t\t * digital zoom factor.\n> +\t\t */\n> +\t\tconst auto info = controlsInfo.find(&controls::ScalerCrop);\n> +\t\tRectangle min = info->second.min().get();\n> +\t\tRectangle max = info->second.max().get();\n> +\t\tfloat maxZoom = std::min(1.0f * max.width / min.width,\n> +\t\t\t\t\t 1.0f * max.height / min.height);\n> +\t\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM,\n> +\t\t\t\t\t &maxZoom, 1);\n> +\t}\n> \n> \tstd::vector availableStreamConfigurations;\n> \tavailableStreamConfigurations.reserve(streamConfigurations_.size() * 4);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18D7EBD808\n\tfor ;\n\tMon, 25 Jan 2021 11:33:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 84F5A682C1;\n\tMon, 25 Jan 2021 12:33:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D2CA4682BB\n\tfor ;\n\tMon, 25 Jan 2021 12:33:21 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 41A71331;\n\tMon, 25 Jan 2021 12:33:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ijqa2TXP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611574401;\n\tbh=fDGpaseSx7iPQxxbRBrH6mhPOl1ZAv4Xn4Yd20gfygU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ijqa2TXPFEgIlYHGbX8Lr23HgZ3PtMv3E/fX6y61zTbJGBywGEMd+8A+bE/vefj++\n\tQaCf+TD/2VQv0BPVakzhEp8BOJzKQ1KqsalrBWxiJo++s0Wuwp7e4Bcfmqgo7/CJ8b\n\tLsj6W+9Cb95iIW6NmExYhnad2z0BMpUp7JW2hQJk=","Date":"Mon, 25 Jan 2021 13:33:02 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210119143711.153517-1-jacopo@jmondi.org>\n\t<20210119143711.153517-8-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210119143711.153517-8-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 07/11] android: camera_device:\n\tRegister MAX_DIGITAL_ZOOM","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]