{"id":10895,"url":"https://patchwork.libcamera.org/api/patches/10895/?format=json","web_url":"https://patchwork.libcamera.org/patch/10895/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210119143711.153517-8-jacopo@jmondi.org>","date":"2021-01-19T14:37:07","name":"[libcamera-devel,v2,07/11] android: camera_device: Register MAX_DIGITAL_ZOOM","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"85a15e867a8b09e1e015c96fbf00c03bed0a2c39","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/10895/mbox/","series":[{"id":1584,"url":"https://patchwork.libcamera.org/api/series/1584/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1584","date":"2021-01-19T14:37:00","name":"android: Exposure times + scaler crop + android metadata","version":2,"mbox":"https://patchwork.libcamera.org/series/1584/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10895/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10895/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61E20BD808\n\tfor ;\n\tTue, 19 Jan 2021 14:37:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F03B6814F;\n\tTue, 19 Jan 2021 15:37:04 +0100 (CET)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 18A7B68148\n\tfor ;\n\tTue, 19 Jan 2021 15:37:00 +0100 (CET)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D09A0C001A\n\tfor ;\n\tTue, 19 Jan 2021 14:36:59 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 19 Jan 2021 15:37:07 +0100","Message-Id":"<20210119143711.153517-8-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20210119143711.153517-1-jacopo@jmondi.org>","References":"<20210119143711.153517-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 07/11] android: camera_device: Register\n\tMAX_DIGITAL_ZOOM","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Register the ANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM static metadata\ninspecting the ScalerCrop control's limits.\n\nReviewed-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 23 ++++++++++++++++++++---\n 1 file changed, 20 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 0484bb9a6557..14068e313f74 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1011,9 +1011,26 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t}\n \n \t/* Scaler static metadata. */\n-\tfloat maxDigitalZoom = 1;\n-\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM,\n-\t\t\t\t &maxDigitalZoom, 1);\n+\t{\n+\t\t/*\n+\t\t * \\todo The digital zoom factor is a property that depends\n+\t\t * on the desired output configuration and the sensor frame size\n+\t\t * input to the ISP. This information are not available to the\n+\t\t * Android HAL, not at initialization time at least.\n+\t\t *\n+\t\t * As a workaround rely on pipeline handlers initializing the\n+\t\t * ScalerCrop control with the camera default configuration and\n+\t\t * use the maximum and minimum crop rectangles to calculate the\n+\t\t * digital zoom factor.\n+\t\t */\n+\t\tconst auto info = controlsInfo.find(&controls::ScalerCrop);\n+\t\tRectangle min = info->second.min().get();\n+\t\tRectangle max = info->second.max().get();\n+\t\tfloat maxZoom = std::min(1.0f * max.width / min.width,\n+\t\t\t\t\t 1.0f * max.height / min.height);\n+\t\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM,\n+\t\t\t\t\t &maxZoom, 1);\n+\t}\n \n \tstd::vector availableStreamConfigurations;\n \tavailableStreamConfigurations.reserve(streamConfigurations_.size() * 4);\n","prefixes":["libcamera-devel","v2","07/11"]}