{"id":10892,"url":"https://patchwork.libcamera.org/api/patches/10892/?format=json","web_url":"https://patchwork.libcamera.org/patch/10892/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210119143711.153517-5-jacopo@jmondi.org>","date":"2021-01-19T14:37:04","name":"[libcamera-devel,v2,04/11] android: camera_device: Register EXPOSURE_TIME_RANGE","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"345ca3e08a26bfe79d386de14ef7a0750cab736b","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/10892/mbox/","series":[{"id":1584,"url":"https://patchwork.libcamera.org/api/series/1584/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1584","date":"2021-01-19T14:37:00","name":"android: Exposure times + scaler crop + android metadata","version":2,"mbox":"https://patchwork.libcamera.org/series/1584/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10892/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10892/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0AB54BD808\n\tfor ;\n\tTue, 19 Jan 2021 14:37:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA6DB68161;\n\tTue, 19 Jan 2021 15:37:02 +0100 (CET)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D5F0068151\n\tfor ;\n\tTue, 19 Jan 2021 15:36:58 +0100 (CET)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 9B89EC0007\n\tfor ;\n\tTue, 19 Jan 2021 14:36:58 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 19 Jan 2021 15:37:04 +0100","Message-Id":"<20210119143711.153517-5-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20210119143711.153517-1-jacopo@jmondi.org>","References":"<20210119143711.153517-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 04/11] android: camera_device: Register\n\tEXPOSURE_TIME_RANGE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Register the EXPOSURE_TIME_RANGE static metadata inspecting the\nExposureTime control limits as reported by the camera.\n\nIf such information is not available, do not register the property.\n\nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 14 +++++++++-----\n 1 file changed, 9 insertions(+), 5 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex a136f8e33843..d22142337d04 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -888,11 +888,15 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\t\t\t\t &filterArr, 1);\n \t}\n \n-\tint64_t exposureTimeRange[] = {\n-\t\t100000, 200000000,\n-\t};\n-\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE,\n-\t\t\t\t &exposureTimeRange, 2);\n+\tconst auto &exposureInfo = controlsInfo.find(&controls::ExposureTime);\n+\tif (exposureInfo != controlsInfo.end()) {\n+\t\tint64_t exposureTimeRange[2] = {\n+\t\t\texposureInfo->second.min().get() * 1000LL,\n+\t\t\texposureInfo->second.max().get() * 1000LL,\n+\t\t};\n+\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE,\n+\t\t\t\t\t &exposureTimeRange, 2);\n+\t}\n \n \tstaticMetadata_->addEntry(ANDROID_SENSOR_ORIENTATION, &orientation_, 1);\n \n","prefixes":["libcamera-devel","v2","04/11"]}