{"id":10878,"url":"https://patchwork.libcamera.org/api/patches/10878/?format=json","web_url":"https://patchwork.libcamera.org/patch/10878/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210116114805.905397-6-niklas.soderlund@ragnatech.se>","date":"2021-01-16T11:48:02","name":"[libcamera-devel,v5,5/8] libcamera: camera_sensor: Expose the camera device","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"66200b506e5001c4983e1ea547074b09f8f99e75","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":{"id":16,"url":"https://patchwork.libcamera.org/api/users/16/?format=json","username":"neg","first_name":"Niklas","last_name":"Söderlund","email":"niklas.soderlund@ragnatech.se"},"mbox":"https://patchwork.libcamera.org/patch/10878/mbox/","series":[{"id":1579,"url":"https://patchwork.libcamera.org/api/series/1579/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1579","date":"2021-01-16T11:47:57","name":"libcamera: Add helper for controls that take effect with a delay","version":5,"mbox":"https://patchwork.libcamera.org/series/1579/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10878/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10878/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DD747C0F1D\n\tfor ;\n\tSat, 16 Jan 2021 11:48:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AAF2168123;\n\tSat, 16 Jan 2021 12:48:22 +0100 (CET)","from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 514706810C\n\tfor ;\n\tSat, 16 Jan 2021 12:48:21 +0100 (CET)","from bismarck.berto.se (p4fca2458.dip0.t-ipconnect.de\n\t[79.202.36.88])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid bac20099-57f0-11eb-a076-005056917f90;\n\tSat, 16 Jan 2021 12:48:20 +0100 (CET)"],"X-Halon-ID":"bac20099-57f0-11eb-a076-005056917f90","Authorized-sender":"niklas.soderlund@fsdn.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 16 Jan 2021 12:48:02 +0100","Message-Id":"<20210116114805.905397-6-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.30.0","In-Reply-To":"<20210116114805.905397-1-niklas.soderlund@ragnatech.se>","References":"<20210116114805.905397-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 5/8] libcamera: camera_sensor: Expose\n\tthe camera device","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Expose the device backing the CameraSensor instance.\n\nSigned-off-by: Niklas Söderlund \nReviewed-by: Jacopo Mondi \nReviewed-by: Laurent Pinchart \n---\n* Changes since v4\n- Add a \\todo\n\n* Changes since v3\n- New, needed to be able to move the DelayedControls handling out of\n CameraSensor.\n---\n include/libcamera/internal/camera_sensor.h | 2 ++\n src/libcamera/camera_sensor.cpp | 7 +++++++\n 2 files changed, 9 insertions(+)","diff":"diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex f80d836161a564e7..a70e024aa327f69b 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -61,6 +61,8 @@ public:\n \tControlList getControls(const std::vector &ids);\n \tint setControls(ControlList *ctrls);\n \n+\tV4L2Subdevice *device() { return subdev_.get(); }\n+\n \tconst ControlList &properties() const { return properties_; }\n \tint sensorInfo(CameraSensorInfo *info) const;\n \ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex e786821d4ba22fb8..8c00e1f8289b88fe 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -514,6 +514,13 @@ ControlList CameraSensor::getControls(const std::vector &ids)\n \treturn subdev_->getControls(ids);\n }\n \n+/**\n+ * \\fn CameraSensor::device()\n+ * \\brief Retrieve the camera sensor device\n+ * \\todo Remove this function by integrating DelayedControl with CameraSensor\n+ * \\return The camera sensor device\n+ */\n+\n /**\n * \\fn CameraSensor::properties()\n * \\brief Retrieve the camera sensor properties\n","prefixes":["libcamera-devel","v5","5/8"]}