[{"id":14534,"web_url":"https://patchwork.libcamera.org/comment/14534/","msgid":"","date":"2021-01-12T05:38:30","subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: pipelines: ipu3:\n\tSimplify error bail out path on start()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Tue, Jan 12, 2021 at 10:21:40AM +0530, Umang Jain wrote:\n> On the bail out path, always ensure that ImgU and CIO2 are stopped\n> before freeing the buffers. V4L2VideoDevice class guarantees that\n> calling stop() without having to call start() is harmless, hence use\n\ns/having to call/having called/\n\n> this guarantee to simplify error paths.\n> \n> Signed-off-by: Umang Jain \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 7 +++----\n> 1 file changed, 3 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index f1151733..73304ea7 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -617,15 +617,14 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] ControlList *con\n> \t\tgoto error;\n> \n> \tret = imgu->start();\n> -\tif (ret) {\n> -\t\timgu->stop();\n> -\t\tcio2->stop();\n> +\tif (ret)\n> \t\tgoto error;\n> -\t}\n> \n> \treturn 0;\n> \n> error:\n> +\timgu->stop();\n> +\tcio2->stop();\n\ncio2->stop() also calls V4L2VideoDevice::requestBuffers(), which calls\nVIDIOC_REQBUFS(0). This shouldn't be an issue, but we could possibly\noptimize it. It can be done on top if needed.\n\nReviewed-by: Laurent Pinchart \n\n> \tfreeBuffers(camera);\n> \tLOG(IPU3, Error) << \"Failed to start camera \" << camera->id();\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7358ABD808\n\tfor ;\n\tTue, 12 Jan 2021 05:38:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EB8ED680CA;\n\tTue, 12 Jan 2021 06:38:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B40BB60523\n\tfor ;\n\tTue, 12 Jan 2021 06:38:44 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3F5523E;\n\tTue, 12 Jan 2021 06:38:44 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Oz0/KBqu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1610429924;\n\tbh=jkav4KCa8EuzQdXRB/IDIhMrEuDtAhy+/f6wGZ1rizM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Oz0/KBquXHNJO6xRdvcUHWRUd1ECsBKJkoTLxPCk3Eip/DOvS3PTeXyS3GHxK3z5k\n\teHJozDUoBsQtLNR/tjzrcnnldI/Ku0MJsZFA/UA5wSad115FGkjA5vvC3436l8TAqC\n\tXuCg47WJVb0est0XrY0MI8sXvqeOa3Y9IC+DrUKA=","Date":"Tue, 12 Jan 2021 07:38:30 +0200","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210112045140.10979-1-email@uajain.com>\n\t<20210112045140.10979-3-email@uajain.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210112045140.10979-3-email@uajain.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: pipelines: ipu3:\n\tSimplify error bail out path on start()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14538,"web_url":"https://patchwork.libcamera.org/comment/14538/","msgid":"<21078820-9df5-6e63-9fb0-5b9725389057@ideasonboard.com>","date":"2021-01-12T14:04:20","subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: pipelines: ipu3:\n\tSimplify error bail out path on start()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Umang,\n\nOn 12/01/2021 05:38, Laurent Pinchart wrote:\n> Hi Umang,\n> \n> Thank you for the patch.\n> \n> On Tue, Jan 12, 2021 at 10:21:40AM +0530, Umang Jain wrote:\n>> On the bail out path, always ensure that ImgU and CIO2 are stopped\n>> before freeing the buffers. V4L2VideoDevice class guarantees that\n>> calling stop() without having to call start() is harmless, hence use\n> \n> s/having to call/having called/\n> \n>> this guarantee to simplify error paths.\n>>\n>> Signed-off-by: Umang Jain \n>> ---\n>> src/libcamera/pipeline/ipu3/ipu3.cpp | 7 +++----\n>> 1 file changed, 3 insertions(+), 4 deletions(-)\n>>\n>> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> index f1151733..73304ea7 100644\n>> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> @@ -617,15 +617,14 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] ControlList *con\n>> \t\tgoto error;\n>> \n>> \tret = imgu->start();\n>> -\tif (ret) {\n>> -\t\timgu->stop();\n>> -\t\tcio2->stop();\n>> +\tif (ret)\n>> \t\tgoto error;\n>> -\t}\n>> \n>> \treturn 0;\n>> \n>> error:\n>> +\timgu->stop();\n>> +\tcio2->stop();\n> \n> cio2->stop() also calls V4L2VideoDevice::requestBuffers(), which calls\n> VIDIOC_REQBUFS(0). This shouldn't be an issue, but we could possibly\n> optimize it. It can be done on top if needed.\n\nI think we can do optimisations later, this series fixes a bug from what\nI understand it - so I'll apply with the corrections to the commit log\nabove.\n\nReviewed-by: Kieran Bingham \n\n\n> Reviewed-by: Laurent Pinchart \n> \n>> \tfreeBuffers(camera);\n>> \tLOG(IPU3, Error) << \"Failed to start camera \" << camera->id();\n>> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5454BD80C\n\tfor ;\n\tTue, 12 Jan 2021 14:04:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5174D680D1;\n\tTue, 12 Jan 2021 15:04:29 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2150E6010B\n\tfor ;\n\tTue, 12 Jan 2021 15:04:27 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C1D258B;\n\tTue, 12 Jan 2021 15:04:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rD6SpDQU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1610460263;\n\tbh=un0TSf0Ze7tPDGtviaddfUuPAbfxaClooz0ZAZPK5e4=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=rD6SpDQUyTS10TMjxh1AFNPjHihgXQ3t1mbvGjkURtmxY94d3KnNQG13484IBE207\n\tXqfd+XvDA9y+q4YVA4h4HAkEZX6gVnSLus66erqKmu/4L08RJVtRsvwTw3grLcohN5\n\tO18wWH3M7hal80xXSudtF/ub1oSfC/piRsIfxvgA=","To":"Laurent Pinchart ,\n\tUmang Jain ","References":"<20210112045140.10979-1-email@uajain.com>\n\t<20210112045140.10979-3-email@uajain.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<21078820-9df5-6e63-9fb0-5b9725389057@ideasonboard.com>","Date":"Tue, 12 Jan 2021 14:04:20 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: pipelines: ipu3:\n\tSimplify error bail out path on start()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14552,"web_url":"https://patchwork.libcamera.org/comment/14552/","msgid":"<20210115155518.jbw4p6yzhzwxbqzo@uno.localdomain>","date":"2021-01-15T15:55:18","subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: pipelines: ipu3:\n\tSimplify error bail out path on start()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Umang\n\nOn Tue, Jan 12, 2021 at 10:21:40AM +0530, Umang Jain wrote:\n> On the bail out path, always ensure that ImgU and CIO2 are stopped\n> before freeing the buffers. V4L2VideoDevice class guarantees that\n> calling stop() without having to call start() is harmless, hence use\n> this guarantee to simplify error paths.\n>\n> Signed-off-by: Umang Jain \n\nThanks\nReviewed-by: Jacopo Mondi \n\n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 7 +++----\n> 1 file changed, 3 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index f1151733..73304ea7 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -617,15 +617,14 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] ControlList *con\n> \t\tgoto error;\n>\n> \tret = imgu->start();\n> -\tif (ret) {\n> -\t\timgu->stop();\n> -\t\tcio2->stop();\n> +\tif (ret)\n> \t\tgoto error;\n> -\t}\n>\n> \treturn 0;\n>\n> error:\n> +\timgu->stop();\n> +\tcio2->stop();\n> \tfreeBuffers(camera);\n> \tLOG(IPU3, Error) << \"Failed to start camera \" << camera->id();\n>\n> --\n> 2.26.2\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4ED66BD808\n\tfor ;\n\tFri, 15 Jan 2021 15:55:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D37A1680ED;\n\tFri, 15 Jan 2021 16:55:02 +0100 (CET)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE20B680D1\n\tfor ;\n\tFri, 15 Jan 2021 16:55:00 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 6FA2EFF80E;\n\tFri, 15 Jan 2021 15:55:00 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Fri, 15 Jan 2021 16:55:18 +0100","From":"Jacopo Mondi ","To":"Umang Jain ","Message-ID":"<20210115155518.jbw4p6yzhzwxbqzo@uno.localdomain>","References":"<20210112045140.10979-1-email@uajain.com>\n\t<20210112045140.10979-3-email@uajain.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210112045140.10979-3-email@uajain.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: pipelines: ipu3:\n\tSimplify error bail out path on start()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]