[{"id":14513,"web_url":"https://patchwork.libcamera.org/comment/14513/","msgid":"","date":"2021-01-11T00:39:44","subject":"Re: [libcamera-devel] [PATCH v6 07/10] libcamera: uvc: Initialize\n\tthe pixel array properties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Jan 07, 2021 at 10:47:32AM +0100, Jacopo Mondi wrote:\n> Initialize the pixel array properties in the UVC pipeline handler as\n> they're now initialized in the CameraSensor class, which the UVC\n> pipeline handler does not use.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 15 +++++++++++++++\n> 1 file changed, 15 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 7cb310e20511..e0c4131496be 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -509,6 +509,21 @@ int UVCCameraData::init(MediaDevice *media)\n> \tproperties_.set(properties::Location, properties::CameraLocationExternal);\n> \tproperties_.set(properties::Model, utils::toAscii(media->model()));\n> \n> +\t/*\n> +\t * Get the current format in order to initialize the sensor array\n> +\t * properties.\n> +\t */\n> +\tSize resolution{};\n\nNo need for {}, there's a suitable default constructor.\n\n> +\tfor (const auto &[pixelformat, sizerange] : video_->formats()) {\n\ns/pixelformat/pixelFormat/\ns/sizerange/sizeRanges/\n\nBut I'm afraid this breaks compilation with gcc 7, which generates a\nwarning due to the unused pixelformat variable. You need to use the\npre-C++17 syntax, with the infamous .second to get the size range.\n\n> +\t\tfor (const SizeRange &size : sizerange) {\n\ns/size/sizeRange/\n\nReviewed-by: Laurent Pinchart \n\n> +\t\t\tif (size.max > resolution)\n> +\t\t\t\tresolution = size.max;\n> +\t\t}\n> +\t}\n> +\n> +\tproperties_.set(properties::PixelArraySize, resolution);\n> +\tproperties_.set(properties::PixelArrayActiveAreas, { Rectangle(resolution) });\n> +\n> \t/* Initialise the supported controls. */\n> \tControlInfoMap::Map ctrls;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7F2EBD808\n\tfor ;\n\tMon, 11 Jan 2021 00:40:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 65A4268090;\n\tMon, 11 Jan 2021 01:40:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 87F1F60317\n\tfor ;\n\tMon, 11 Jan 2021 01:39:59 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE00DEC;\n\tMon, 11 Jan 2021 01:39:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qMcGyRt7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1610325599;\n\tbh=fvnasOg2tcs8KP32Pu91VD6vNbvehc2QZ3JMRryzNA0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qMcGyRt7XS3LAalQpR+WuQpEv98fHFMyA0WDn1cnjDRgkiU3VQhPo8DIqgejq0RzY\n\tzL8ajqKk8EM7zpQJNQX/sl5TnEhyzg3JtWNEAYhPEFwi5LO3UPLr1FCUPdg/P2kgq5\n\tktRt3smvSrNuzOM2H9a9mWnbBcqb2b5ab3xBbfRU=","Date":"Mon, 11 Jan 2021 02:39:44 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210107094735.11673-1-jacopo@jmondi.org>\n\t<20210107094735.11673-8-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210107094735.11673-8-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v6 07/10] libcamera: uvc: Initialize\n\tthe pixel array properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]