[{"id":14541,"web_url":"https://patchwork.libcamera.org/comment/14541/","msgid":"","date":"2021-01-13T13:03:47","subject":"Re: [libcamera-devel] [PATCH v6 06/10] libcamera: camera_sensor: Do\n\tnot default 'rotation'","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2021-01-07 10:47:31 +0100, Jacopo Mondi wrote:\n> The 'rotation' property is not critical. Only register it if the\n> sensor driver reports it.\n> \n> Reviewed-by: Niklas Söderlund Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/camera_sensor.cpp | 8 +++-----\n> 1 file changed, 3 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 71aa268f3b4f..e9c80c304dd4 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -370,13 +370,11 @@ int CameraSensor::initProperties()\n> \t}\n> \tproperties_.set(properties::Location, propertyValue);\n> \n> -\t/* Camera Rotation: default is 0 degrees. */\n> \tconst auto &rotationControl = controls.find(V4L2_CID_CAMERA_SENSOR_ROTATION);\n> -\tif (rotationControl != controls.end())\n> +\tif (rotationControl != controls.end()) {\n> \t\tpropertyValue = rotationControl->second.def().get();\n> -\telse\n> -\t\tpropertyValue = 0;\n> -\tproperties_.set(properties::Rotation, propertyValue);\n> +\t\tproperties_.set(properties::Rotation, propertyValue);\n> +\t}\n> \n> \tproperties_.set(properties::PixelArraySize, pixelArraySize_);\n> \tproperties_.set(properties::PixelArrayActiveAreas, { activeArea_ });\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14883BD808\n\tfor ;\n\tWed, 13 Jan 2021 13:03:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C5AB680D5;\n\tWed, 13 Jan 2021 14:03:50 +0100 (CET)","from mail-lj1-x229.google.com (mail-lj1-x229.google.com\n\t[IPv6:2a00:1450:4864:20::229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 46F736054E\n\tfor ;\n\tWed, 13 Jan 2021 14:03:49 +0100 (CET)","by mail-lj1-x229.google.com with SMTP id b10so2442545ljp.6\n\tfor ;\n\tWed, 13 Jan 2021 05:03:49 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tq21sm206342lfc.290.2021.01.13.05.03.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 13 Jan 2021 05:03:47 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"Jxb7D2oQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=aQ+VUxwXeM4B5I8FsXykNl0+9hAQvL/BZZ61V/NKmD0=;\n\tb=Jxb7D2oQXJb1hgRWJhyKia6Mbr+Xf7wWcTHrCrIjhWi3qxmBgMbGVbHSY75AIDrDGG\n\tRZKqd13VW66jNK/3OpGy8L6v15fBZvTrCAW/RXyH6SB43ectzl6VxDLN1qcrxfUBWyHk\n\t9KqOJuVTCZXC9pfX2ibhjIuUpBMAdSz1SeOTaurxg8MjBdWzsLt9SFbGfgGc20e/KAkg\n\t15eJ5Xv76ULlUNitdTun+KWsJejUS0pZ6SHjMQ0jaXUAp3Fxwjl2BhrtvtppiDcgtdIC\n\twZSBe682PECe6nKxJwX7pyjCg4rVENbL31W48/GC2bmZJxNMZPz3h5+C0r9P7VJzms+3\n\t/wxA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=aQ+VUxwXeM4B5I8FsXykNl0+9hAQvL/BZZ61V/NKmD0=;\n\tb=LwPaJJ9hRXs/D37cyGxkGSInGWPBHluyQ8DMuaqC9HjJmy40XuWCeCJ2UGf0D2pzfl\n\t3148bQ7BwBIHzfCqJEA+T0I3QTBy/JAih0kr1vuRAhokdi6KcFCDdG1TyJ3Pap7a4Rql\n\thfkvYQh0r6wmeaGomeifr0UFJ35KQXnQAjqODUUuvcCoKUtnaHHNSa3UXtyeMsWaqrUs\n\tMou7mMBo6wEksqTtpZkCSVU9p0sa3jh7j53Xp5BtN61W6jadNmtrOSBiZepbu0UmS5p2\n\t9HSL93ENdvRUD3QF7rRmjSUHSVgSOCdmlb/fFYSMCd7I9k+GhwsECYRqqhMBP64ZMOcX\n\tPV9w==","X-Gm-Message-State":"AOAM5338hXIxl85PRg8Ham33nccjtkrsvDBl8Ac6Sp33cYXqs7RVCuIX\n\tiV7aVJMlqPlPg53lQ/mTxDCWr2NkHK9Hiw==","X-Google-Smtp-Source":"ABdhPJz1bleEYaRnadAscodjxqEG0cJxtn+LcrzQtr2sLpei07xJKpnRbKD7E/zWGMZSAEngTTseig==","X-Received":"by 2002:a05:651c:283:: with SMTP id\n\tb3mr915152ljo.345.1610543028606; \n\tWed, 13 Jan 2021 05:03:48 -0800 (PST)","Date":"Wed, 13 Jan 2021 14:03:47 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210107094735.11673-1-jacopo@jmondi.org>\n\t<20210107094735.11673-7-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210107094735.11673-7-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v6 06/10] libcamera: camera_sensor: Do\n\tnot default 'rotation'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]