[{"id":14539,"web_url":"https://patchwork.libcamera.org/comment/14539/","msgid":"","date":"2021-01-13T12:29:48","subject":"Re: [libcamera-devel] [PATCH v6 04/10] libcamera: camera_sensor:\n\tDefault analogue crop rectangle","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2021-01-07 10:47:29 +0100, Jacopo Mondi wrote:\n> As support for the V4L2_SEL_TGT_CROP selection target used to read the\n> sensor analogue crop rectangle is schedule to become mandatory but is\n> still optional, use the sensor's active area size as fallback value to\n> allow the creation of the CameraSensorInfo in the case the driver does\n> not support it.\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/camera_sensor.cpp | 11 +++++++----\n> 1 file changed, 7 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 0c9bd4f50cff..e8caa4467643 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -643,13 +643,16 @@ int CameraSensor::sensorInfo(CameraSensorInfo *info) const\n> \t */\n> \tinfo->activeAreaSize = { activeArea_.width, activeArea_.height };\n> \n> -\t/* It's mandatory for the subdevice to report its crop rectangle. */\n> +\t/*\n> +\t * \\todo Support for retreiving the crop rectangle is scheduled to\n> +\t * become mandatory. For the time being use the default value if it has\n> +\t * been initialized at sensor driver validation time.\n> +\t */\n> \tint ret = subdev_->getSelection(pad_, V4L2_SEL_TGT_CROP, &info->analogCrop);\n> \tif (ret) {\n> +\t\tinfo->analogCrop = activeArea_;\n> \t\tLOG(CameraSensor, Error)\n> -\t\t\t<< \"Failed to construct camera sensor info: \"\n> -\t\t\t<< \"the camera sensor does not report the crop rectangle\";\n> -\t\treturn ret;\n> +\t\t\t<< \"The analogue crop rectangle has been defaulted to the active area size\";\n> \t}\n> \n> \t/*\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A08F1BD808\n\tfor ;\n\tWed, 13 Jan 2021 12:29:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C055680D2;\n\tWed, 13 Jan 2021 13:29:52 +0100 (CET)","from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com\n\t[IPv6:2a00:1450:4864:20::12b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1847F6054E\n\tfor ;\n\tWed, 13 Jan 2021 13:29:51 +0100 (CET)","by mail-lf1-x12b.google.com with SMTP id a12so2487894lfl.6\n\tfor ;\n\tWed, 13 Jan 2021 04:29:51 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ta207sm196413lfd.101.2021.01.13.04.29.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 13 Jan 2021 04:29:49 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"sS0Fh59P\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=gpaTBFP0TEjlNLg0kemOFVu9XSwkTawavt/YG/DdV1A=;\n\tb=sS0Fh59ProXgKDUbb7/OKzg3hFYkFRVfLXyrI6RqQamcuMtYAJMQiZKB0GO+f0Qx2v\n\tqiOYXisvphUvIjnGHPBRHObYlFKjS/2lz/35wxncc+kQAjCUY45DlcLWbanvt4KhtHxv\n\tQixoYoSB9Rb7ks5TZzL/9mhu/axIIiaYnzcVMoCCgJoU4XdDMGuZafEB/x9dU4Xw0NHA\n\tLg/vliV+KqSt/XM5eANN0+cG6+DI3X6S9ugD4l3qk4+SZNJh8lbadibb7+h6jLPiWt5d\n\tMG09Cfcv0ZUIf1M7Cne19xeNDc//4CR5jjhB6gdP4lMku9Q+ri27T4FjHbcM3PDMKDR9\n\t2Nsg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=gpaTBFP0TEjlNLg0kemOFVu9XSwkTawavt/YG/DdV1A=;\n\tb=YoZsBpfiNg1SpVTHL24tp8k8xmd8oeO3qlwEYeULKpSDtig8xWO5OFpyUl05c1sE4n\n\t2+NptSQhUD4WRgrIgedCzPWQkcT1sDsgV3T+dt84XrhW2KWQdklb3z0swzuVtTVZ7Lyb\n\tIcp/K3MOnnnGXHs+r9V7QsqNnuJtS3rPs1Jk69pNHJUjkEgIh1q0fJBhnqxM7A+XLRc9\n\tzfc1zx17FsEcUuLvpHLjtx0F8sBjQvitZ7ujWHnH0UiIFzpp3J68L7bJuHuT4cpgCdI5\n\tSl745RtZhDJ+kaxeLTBeE8W3sFebYEw9zGtN7/OSvUaranfJxdbvhADYxQJGAnQ+WGC3\n\tH6Yg==","X-Gm-Message-State":"AOAM530j40UJVDQP3AiqRto2+vP0i7+z79YKxXDArVOBiVb7Vtpg0Em7\n\tjklHnjSdTjmK51DJT6/w/wBulA==","X-Google-Smtp-Source":"ABdhPJzOc+TUv+cVFKengzlJw2JlPVgAlxH2m700sL8M6lAX89kp/7juI4MfhkeZjNHKXseftxXsLg==","X-Received":"by 2002:ac2:43ce:: with SMTP id u14mr788422lfl.369.1610540990144;\n\tWed, 13 Jan 2021 04:29:50 -0800 (PST)","Date":"Wed, 13 Jan 2021 13:29:48 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210107094735.11673-1-jacopo@jmondi.org>\n\t<20210107094735.11673-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210107094735.11673-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v6 04/10] libcamera: camera_sensor:\n\tDefault analogue crop rectangle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]