[{"id":14510,"web_url":"https://patchwork.libcamera.org/comment/14510/","msgid":"","date":"2021-01-11T00:13:12","subject":"Re: [libcamera-devel] [PATCH 11/12] android: camera_device: Support\n\tAWB_AUTO","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Jan 05, 2021 at 08:05:21PM +0100, Jacopo Mondi wrote:\n> Claim support for the AWB_AUTO mode in the\n> ANDROID_CONTROL_AWB_AVAILABLE_MODES static metadata.\n> \n> This fixes the CTS test error:\n> android.hardware.camera2.cts.CaptureRequestTest#testAwbModeAndLock fail\n> The static info key 'android.control.awbAvailableModes'\n> All camera devices must support AUTO mode\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 5f5e6576365b..6eb3404739e8 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -802,7 +802,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\t\t\t availableStabilizationModes.size());\n> \n> \tstd::vector availableAwbModes = {\n> -\t\tANDROID_CONTROL_AWB_MODE_OFF,\n> +\t\tANDROID_CONTROL_AWB_MODE_AUTO,\n\nI wonder if we should query the pipeline handler to only report auto\nwhen supported. This would break CTS for devices that don't support AWB,\nbut it would be better than faking it.\n\nWe can decide to handle this later if it would be too much effort right\nnow.\n\nReviewed-by: Laurent Pinchart \n\n> \t};\n> \tstaticMetadata_->addEntry(ANDROID_CONTROL_AWB_AVAILABLE_MODES,\n> \t\t\t\t availableAwbModes.data(),","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD662BD80C\n\tfor ;\n\tMon, 11 Jan 2021 00:13:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 440336808C;\n\tMon, 11 Jan 2021 01:13:29 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7804560317\n\tfor ;\n\tMon, 11 Jan 2021 01:13:28 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AFB59EC;\n\tMon, 11 Jan 2021 01:13:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oAatxPML\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1610324006;\n\tbh=G6oV+vOL0E18TzGT3wIRm+nIeBF9U0QVHXUeQlOxNBc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oAatxPMLzf7guYiVnuN5u9hYf+hNy/NnA5xaGXmcjCw33hxsJs18+uO44JkRC2uc6\n\tqV+VXG74C7p/ItI5bUK5tLPERYLecACRocpjT0hk7bf7LbMPuc0Vvw8RmEIIcBxCAS\n\tNXaxNnYsDCkEbixR3m6dphKFMw2XGuN9dXCY0gIw=","Date":"Mon, 11 Jan 2021 02:13:12 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210105190522.682324-1-jacopo@jmondi.org>\n\t<20210105190522.682324-12-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210105190522.682324-12-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 11/12] android: camera_device: Support\n\tAWB_AUTO","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14587,"web_url":"https://patchwork.libcamera.org/comment/14587/","msgid":"","date":"2021-01-18T15:40:59","subject":"Re: [libcamera-devel] [PATCH 11/12] android: camera_device: Support\n\tAWB_AUTO","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2021-01-05 20:05:21 +0100, Jacopo Mondi wrote:\n> Claim support for the AWB_AUTO mode in the\n> ANDROID_CONTROL_AWB_AVAILABLE_MODES static metadata.\n> \n> This fixes the CTS test error:\n> android.hardware.camera2.cts.CaptureRequestTest#testAwbModeAndLock fail\n> The static info key 'android.control.awbAvailableModes'\n> All camera devices must support AUTO mode\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 5f5e6576365b..6eb3404739e8 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -802,7 +802,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\t\t\t availableStabilizationModes.size());\n> \n> \tstd::vector availableAwbModes = {\n> -\t\tANDROID_CONTROL_AWB_MODE_OFF,\n> +\t\tANDROID_CONTROL_AWB_MODE_AUTO,\n> \t};\n> \tstaticMetadata_->addEntry(ANDROID_CONTROL_AWB_AVAILABLE_MODES,\n> \t\t\t\t availableAwbModes.data(),\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B56BBC0F1C\n\tfor ;\n\tMon, 18 Jan 2021 15:41:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E7AA6812E;\n\tMon, 18 Jan 2021 16:41:02 +0100 (CET)","from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com\n\t[IPv6:2a00:1450:4864:20::12c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8128E6010B\n\tfor ;\n\tMon, 18 Jan 2021 16:41:01 +0100 (CET)","by mail-lf1-x12c.google.com with SMTP id u25so24704833lfc.2\n\tfor ;\n\tMon, 18 Jan 2021 07:41:01 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tu19sm1722691lji.2.2021.01.18.07.41.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 18 Jan 2021 07:41:00 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"ubFLOEz2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=BQLmOVidkeYvYV5XkTP047hwLiWBIfiDZANGYt/XMgk=;\n\tb=ubFLOEz2l0nvHpZ1yZP/BF3i5+uzL1Q4F3e//OIVD07QccYq7F7uZFO5mBpEG+VnYt\n\tsr2gSRBLA1BZzRaCZ0oS8yoaiEXazNTN/TVLa3YFeYjiuzzVnKrHtZ1rL3pfi9V4Qlod\n\tEKAen6UQECdXtGoaXmLlpfM4IxyP+vFjtzlyHSZg/pC/CuY4bBeRt8wsDS63/9Vuzx2p\n\tXekzkim+AX6kvTgtWjHunuwtmGhOBafJADpKOJjYCNSaHazf7D20khevIFGimMUVoB6V\n\tXgMvbcXf4V+Tlr6oosv/jZnMwdRtXNwb0lQNN8BEnTk1XmLNStFXh2E4GRYX2Cx5j0aq\n\tsEcw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=BQLmOVidkeYvYV5XkTP047hwLiWBIfiDZANGYt/XMgk=;\n\tb=T0fsyqB89pXpJqkjgt6XqF+r4UMaKhXm61UsNGBxiM8wgnM2NJOWxpro/NTBpb+LTp\n\tsIrNWHEmW8RPmBg0wdZGX4xrBgjKvjumlWV4hxVTLCMVEJE6mvvfZjLU+eZGxRS26rkG\n\t97tAGHRz6ek5wNcsY8LXfwNleuZwhcFxNse0OWkLyVjG60Li2h8G8HoykF3jXm9vsZmQ\n\teSYdPgw+0tJ8wAXsrKjjd8ZyYFSAWFZ1kTtCFWBwwPV9HuwzZk+4wYiKhUXmVqtpzezh\n\tErxfGqWki5GVpsp8lcYQJuWhpebqX5oenC8FLS40mlHkT0/4CQvNQSR3kWHom+Ctvpoq\n\tb+gA==","X-Gm-Message-State":"AOAM533cgld71CNOK47Dv7t93SmFxzLikElaRYN6OSpTzNo3xpgs+ThV\n\tDiRvDZulppWpGpe76sQa4go9JjJmV3iz8A==","X-Google-Smtp-Source":"ABdhPJzYvPbJkfyDifJghS7XzKgwC8xMZ0DK3Kghj2zSWH823asX96YyW/avoDnvqinWalrYXB6L5A==","X-Received":"by 2002:ac2:593a:: with SMTP id\n\tv26mr9426528lfi.591.1610984461013; \n\tMon, 18 Jan 2021 07:41:01 -0800 (PST)","Date":"Mon, 18 Jan 2021 16:40:59 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210105190522.682324-1-jacopo@jmondi.org>\n\t<20210105190522.682324-12-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210105190522.682324-12-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 11/12] android: camera_device: Support\n\tAWB_AUTO","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]