[{"id":14507,"web_url":"https://patchwork.libcamera.org/comment/14507/","msgid":"","date":"2021-01-10T23:47:18","subject":"Re: [libcamera-devel] [PATCH 08/12] android: camera_device:\n\tRegister MAX_DIGITAL_ZOOM","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Jan 05, 2021 at 08:05:18PM +0100, Jacopo Mondi wrote:\n> Register the ANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM static metadata\n> inspecting the ScalerCrop control's limits.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 23 ++++++++++++++++++++---\n> 1 file changed, 20 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index e6cee75581f2..99297270598f 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1011,9 +1011,26 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t}\n> \n> \t/* Scaler static metadata. */\n> -\tfloat maxDigitalZoom = 1;\n> -\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM,\n> -\t\t\t\t &maxDigitalZoom, 1);\n> +\t{\n> +\t\t/*\n> +\t\t * \\todo The digital zoom factor is a property that depends\n> +\t\t * on the desired output configuration and the sensor frame size\n> +\t\t * input to the ISP. These information are not available to the\n\ns/These information/This information/\n\n> +\t\t * Android HAL, not at initialization time at least.\n> +\t\t *\n> +\t\t * Rely on pipeline handlers initializing the ScalerCrop control\n\nMaybe \"As a workaround, rely for now on ...\" ?\n\n> +\t\t * with the camera default configuration and use the maximum\n> +\t\t * and minimum crop rectangles to calculate the digital zoom\n> +\t\t * factor.\n> +\t\t */\n> +\t\tconst auto info = controlsInfo.find(&controls::ScalerCrop);\n> +\t\tRectangle min = info->second.min().get();\n> +\t\tRectangle max = info->second.max().get();\n> +\t\tfloat maxZoom = std::min(1.0f * max.width / min.width,\n> +\t\t\t\t\t\t1.0f * max.height / min.height);\n\nAs both arguments are float, you can drop the .\n\nReviewed-by: Laurent Pinchart \n\n> +\t\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM,\n> +\t\t\t\t\t &maxZoom, 1);\n> +\t}\n> \n> \tstd::vector availableStreamConfigurations;\n> \tavailableStreamConfigurations.reserve(streamConfigurations_.size() * 4);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81E96BD808\n\tfor ;\n\tSun, 10 Jan 2021 23:47:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1939568084;\n\tMon, 11 Jan 2021 00:47:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B8F3260317\n\tfor ;\n\tMon, 11 Jan 2021 00:47:32 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A363EC;\n\tMon, 11 Jan 2021 00:47:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JAttfl5i\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1610322452;\n\tbh=ZBCii3VgplN6P5teh27WzLhH+7zL1vBcViKN2YBcHas=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JAttfl5ilDAYNtTh+DIR5VGCfC26tkzoh8TlZ+GQWMSwSkSbvkSECLpJRnS0u6SRI\n\tdF7AFOboEWAvyzrTj1G6NRm9RcHZmm+oelp/ayam9rEtgQFMjCI28rzjKjBEngEXzi\n\tdGsrMoXgI7cEgm09bzNAhI6H3f4EFYF7aYaydWc0=","Date":"Mon, 11 Jan 2021 01:47:18 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210105190522.682324-1-jacopo@jmondi.org>\n\t<20210105190522.682324-9-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210105190522.682324-9-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 08/12] android: camera_device:\n\tRegister MAX_DIGITAL_ZOOM","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14584,"web_url":"https://patchwork.libcamera.org/comment/14584/","msgid":"","date":"2021-01-18T15:31:42","subject":"Re: [libcamera-devel] [PATCH 08/12] android: camera_device:\n\tRegister MAX_DIGITAL_ZOOM","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2021-01-05 20:05:18 +0100, Jacopo Mondi wrote:\n> Register the ANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM static metadata\n> inspecting the ScalerCrop control's limits.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 23 ++++++++++++++++++++---\n> 1 file changed, 20 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index e6cee75581f2..99297270598f 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1011,9 +1011,26 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t}\n> \n> \t/* Scaler static metadata. */\n> -\tfloat maxDigitalZoom = 1;\n> -\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM,\n> -\t\t\t\t &maxDigitalZoom, 1);\n> +\t{\n> +\t\t/*\n> +\t\t * \\todo The digital zoom factor is a property that depends\n> +\t\t * on the desired output configuration and the sensor frame size\n> +\t\t * input to the ISP. These information are not available to the\n> +\t\t * Android HAL, not at initialization time at least.\n> +\t\t *\n> +\t\t * Rely on pipeline handlers initializing the ScalerCrop control\n> +\t\t * with the camera default configuration and use the maximum\n> +\t\t * and minimum crop rectangles to calculate the digital zoom\n> +\t\t * factor.\n> +\t\t */\n> +\t\tconst auto info = controlsInfo.find(&controls::ScalerCrop);\n> +\t\tRectangle min = info->second.min().get();\n> +\t\tRectangle max = info->second.max().get();\n> +\t\tfloat maxZoom = std::min(1.0f * max.width / min.width,\n> +\t\t\t\t\t\t1.0f * max.height / min.height);\n> +\t\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM,\n> +\t\t\t\t\t &maxZoom, 1);\n> +\t}\n> \n> \tstd::vector availableStreamConfigurations;\n> \tavailableStreamConfigurations.reserve(streamConfigurations_.size() * 4);\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18F95BD808\n\tfor ;\n\tMon, 18 Jan 2021 15:31:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 993976812A;\n\tMon, 18 Jan 2021 16:31:46 +0100 (CET)","from mail-lj1-x234.google.com (mail-lj1-x234.google.com\n\t[IPv6:2a00:1450:4864:20::234])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 766986010B\n\tfor ;\n\tMon, 18 Jan 2021 16:31:44 +0100 (CET)","by mail-lj1-x234.google.com with SMTP id u11so18587118ljo.13\n\tfor ;\n\tMon, 18 Jan 2021 07:31:44 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ta11sm1939161lfl.22.2021.01.18.07.31.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 18 Jan 2021 07:31:43 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"yL0e96cD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=KQx1fcKx2oChQjbAEuYhU8ZYDunD9epu4q8HSzLSmuU=;\n\tb=yL0e96cDFxUuoQSqbRQxH06jWaamCk3XqA6m9PAcd9TKoQbhmSOHwZmDjzEK6oGwhX\n\tT2PUNPWf0Q2tLHz0M5+dI+TVjJiVPq4YAZRXwTuPeYI1lemiKeQr7kam1RUyskceH7k0\n\td7SxAE36KYYXUe+wHv36/6p86whx3NFmfPM2ZGmSaiWzHTyX7NzfWPcdS0S4PddKwpk2\n\t3ULeR2vPeg1Hh1+HL2+W+NRAYjkUVDWU60LIkV0f7a5zFjnIshgRhLuP3BvO45fuRe8M\n\tEcwgh7iR+G8CnKLYslsgPmB7XesNsbS+5KVrlxI2iDJdeutSIm73VPiwKLz6EL4DFOEM\n\tWkYg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=KQx1fcKx2oChQjbAEuYhU8ZYDunD9epu4q8HSzLSmuU=;\n\tb=blrTHGPocEoEps7nplqn358DKCKAdeQbTwSzsufU4XgbSAIyX/DoL6T6EZ3TqDHuIp\n\tbRvXItJaoNSPFDbJsdc1kGYwC35EEbsgQTnAXs7sNtftFLEQM9hV1bmBBiBxRwmnwJsq\n\tybL4MpsBlDMqbNML3CJdrtKR/3b3fw+2QUXkgeUO5cBlm0P7JXVXy7zjTTXCOYPKgxTN\n\tWjmckF/EvRp2VOF0oYkOvp2PaNJbTWasnZqJbsUvZPlH8G+tYIw33aoYNWKKEhbQNVkY\n\tKbXZ+ZZpW7eLXzokk0AEpOAzCAcqwiwIq8xQ+wpAwPGiAybQKK3V7338UhSurUIT4XWG\n\tK+Pw==","X-Gm-Message-State":"AOAM530J02Y+DYMdXFMqKpCqtGOGlBOcLOYqJsLiSLSIEoBGhvddOKHW\n\te/iQqJIC7QSqhZzxf9S+d6/eDA==","X-Google-Smtp-Source":"ABdhPJz2//UMxPuQvfCjy8rDRWHge14pufOnXEYZasZpJQWC1TmqbtTU06HSM0qL5i2DPrs7c6T6+w==","X-Received":"by 2002:a05:651c:1310:: with SMTP id\n\tu16mr88733lja.47.1610983903923; \n\tMon, 18 Jan 2021 07:31:43 -0800 (PST)","Date":"Mon, 18 Jan 2021 16:31:42 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210105190522.682324-1-jacopo@jmondi.org>\n\t<20210105190522.682324-9-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210105190522.682324-9-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 08/12] android: camera_device:\n\tRegister MAX_DIGITAL_ZOOM","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]