[{"id":14504,"web_url":"https://patchwork.libcamera.org/comment/14504/","msgid":"","date":"2021-01-10T22:30:17","subject":"Re: [libcamera-devel] [PATCH 05/12] android: camera_device: Report\n\tEXPOSURE_TIME","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Jan 05, 2021 at 08:05:15PM +0100, Jacopo Mondi wrote:\n> Instead of reporting a fake value in the dynamic metadata for the\n> EXPOSURE_TIME control, use the value provided by the pipeline.\n> \n> The metadata is only meaningfull in FULL mode.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 11 ++++++-----\n> 1 file changed, 6 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index de3ead275e91..e6cee75581f2 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1871,11 +1871,6 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \tresultMetadata->addEntry(ANDROID_SENSOR_ROLLING_SHUTTER_SKEW,\n> \t\t\t\t &rolling_shutter_skew, 1);\n> \n> -\t/* 16.6 msec */\n> -\tconst int64_t exposure_time = 16600000;\n> -\tresultMetadata->addEntry(ANDROID_SENSOR_EXPOSURE_TIME,\n> -\t\t\t\t &exposure_time, 1);\n> -\n> \tconst uint8_t lens_shading_map_mode =\n> \t\t\t\tANDROID_STATISTICS_LENS_SHADING_MAP_MODE_OFF;\n> \tresultMetadata->addEntry(ANDROID_STATISTICS_LENS_SHADING_MAP_MODE,\n> @@ -1893,6 +1888,12 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \t\t\t\t\t &pipeline_depth, 1);\n> \t}\n> \n> +\tif (metadata.contains(controls::ExposureTime)) {\n> +\t\tint32_t exposure = metadata.get(controls::ExposureTime);\n> +\t\tresultMetadata->addEntry(ANDROID_SENSOR_EXPOSURE_TIME,\n> +\t\t\t\t\t &exposure, 1);\n> +\t}\n\nIt's a small patch, it may seem trivial, but lots of effort was required\nto get to this point. It's very nice to see pieces falling into place,\ngood work !\n\nReviewed-by: Laurent Pinchart \n\n> +\n> \t/*\n> \t * Return the result metadata pack even is not valid: get() will return\n> \t * nullptr.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C1A7BD80C\n\tfor ;\n\tSun, 10 Jan 2021 22:30:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D30896807E;\n\tSun, 10 Jan 2021 23:30:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 26D2760523\n\tfor ;\n\tSun, 10 Jan 2021 23:30:32 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 92891DA;\n\tSun, 10 Jan 2021 23:30:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HRh1Rtjl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1610317831;\n\tbh=OuHZfFEw4jqbTjfjHrNmDCIFcLSlkgdKz8fLPraL/Ds=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HRh1RtjlqNZUNplkx3vRKEcd1K8f/tRWHLGjqj7c5CmPhIAb0z64mKrB50Y/9/Aot\n\tDlT1TbEMgak84NKzfhBSUo2SWd7Ju4yCWot5yFTD/JW1WBJWc505fvl4F5QZsrO0Ji\n\tOT/tNCWzFXPqc3phhi8LIabVSHOfahYqG7McKfXE=","Date":"Mon, 11 Jan 2021 00:30:17 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210105190522.682324-1-jacopo@jmondi.org>\n\t<20210105190522.682324-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210105190522.682324-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 05/12] android: camera_device: Report\n\tEXPOSURE_TIME","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14583,"web_url":"https://patchwork.libcamera.org/comment/14583/","msgid":"","date":"2021-01-18T15:21:21","subject":"Re: [libcamera-devel] [PATCH 05/12] android: camera_device: Report\n\tEXPOSURE_TIME","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2021-01-05 20:05:15 +0100, Jacopo Mondi wrote:\n> Instead of reporting a fake value in the dynamic metadata for the\n> EXPOSURE_TIME control, use the value provided by the pipeline.\n> \n> The metadata is only meaningfull in FULL mode.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 11 ++++++-----\n> 1 file changed, 6 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index de3ead275e91..e6cee75581f2 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1871,11 +1871,6 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \tresultMetadata->addEntry(ANDROID_SENSOR_ROLLING_SHUTTER_SKEW,\n> \t\t\t\t &rolling_shutter_skew, 1);\n> \n> -\t/* 16.6 msec */\n> -\tconst int64_t exposure_time = 16600000;\n> -\tresultMetadata->addEntry(ANDROID_SENSOR_EXPOSURE_TIME,\n> -\t\t\t\t &exposure_time, 1);\n> -\n> \tconst uint8_t lens_shading_map_mode =\n> \t\t\t\tANDROID_STATISTICS_LENS_SHADING_MAP_MODE_OFF;\n> \tresultMetadata->addEntry(ANDROID_STATISTICS_LENS_SHADING_MAP_MODE,\n> @@ -1893,6 +1888,12 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \t\t\t\t\t &pipeline_depth, 1);\n> \t}\n> \n> +\tif (metadata.contains(controls::ExposureTime)) {\n> +\t\tint32_t exposure = metadata.get(controls::ExposureTime);\n> +\t\tresultMetadata->addEntry(ANDROID_SENSOR_EXPOSURE_TIME,\n> +\t\t\t\t\t &exposure, 1);\n> +\t}\n> +\n> \t/*\n> \t * Return the result metadata pack even is not valid: get() will return\n> \t * nullptr.\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9220C0F1C\n\tfor ;\n\tMon, 18 Jan 2021 15:21:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8324D6010B;\n\tMon, 18 Jan 2021 16:21:24 +0100 (CET)","from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D9C66010B\n\tfor ;\n\tMon, 18 Jan 2021 16:21:23 +0100 (CET)","by mail-lj1-x22b.google.com with SMTP id f11so18591506ljm.8\n\tfor ;\n\tMon, 18 Jan 2021 07:21:23 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tc24sm534461lfc.7.2021.01.18.07.21.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 18 Jan 2021 07:21:21 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"bvQfolMf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=tlkxH6eRRX8ANR3SOlHIsjgPu+8vQ4bZwkQyHD2QRLQ=;\n\tb=bvQfolMf7NcDSx/YUztRUEv6PvqZyyhmlihpas88vfEK4m+2KQy6UShD7mJus4Hauc\n\t8d5zqGPxMflsRjAIUrnpbvcayJEu3Mt5Vhm8wl6CDWNhiKa+1RgjX+DT0ebXODzJWXDK\n\tSqnRzN6Q/bSVNw/NirhZ7w0ykAaBWc9NAkeCcbTQDdlC52G+saihFc2+FIg54BggYxD+\n\tZu/JmX46nixJs2/JpGkgALSKozXoLKS4D3swYSGp8YdZJEX9QheiY3Qu+Y9+mRviRjxn\n\tYrLML3e6/cgd/22np7dyRFkTtTSFbxYRJO2/jLyS214mUfvWxln6bFLIxwtB0I2tQ2XQ\n\tRJGQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=tlkxH6eRRX8ANR3SOlHIsjgPu+8vQ4bZwkQyHD2QRLQ=;\n\tb=VSf3XjCzDvZIyh2F8t6GSlUcLhpQgnwCAln5WxBL7An4X7GPf2UactpQ6TUkETA/pN\n\tD4NbToZi0MG21B/qm2ScaIda459k39QfmB8wqG8Fx0Mtz9CL8guaff4C8jGGnbk9ih68\n\tEOYvZvv5XwzO557qi3lQSw9rTAHR/N1VLnxidfZAqhHWr/4QyrkOwq4D3Mbjy7IUFO5z\n\t5x4CwnOiSRFaVzR8M+H2437uHeLanDj7qSmiByKbuC/1gLy0rtt41ci0mbGp41o8k6uV\n\tJCU+OruIW6xXuGMAwaESyyfMsHkIOInzorgRdCYIprbrDF8BkQeO3yNfTA1+Ey5kQLMn\n\tOOvw==","X-Gm-Message-State":"AOAM533+OQ4dYUMcuJ+tCFuUcyg7NUSBgUpiteNK832jaVOQDXGwOGph\n\tPgdliS2mmW3tAA764j332MlBcQ==","X-Google-Smtp-Source":"ABdhPJzX/U79x0FHEM/G85Ntcc4vsLeMy/eBkWxUramBIGE5XVTZlzewktam35KQ8L69hjLIL8VwRg==","X-Received":"by 2002:a2e:2c15:: with SMTP id s21mr71630ljs.39.1610983282787; \n\tMon, 18 Jan 2021 07:21:22 -0800 (PST)","Date":"Mon, 18 Jan 2021 16:21:21 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210105190522.682324-1-jacopo@jmondi.org>\n\t<20210105190522.682324-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210105190522.682324-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 05/12] android: camera_device: Report\n\tEXPOSURE_TIME","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]