{"id":10816,"url":"https://patchwork.libcamera.org/api/patches/10816/?format=json","web_url":"https://patchwork.libcamera.org/patch/10816/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210105190522.682324-3-jacopo@jmondi.org>","date":"2021-01-05T19:05:12","name":"[libcamera-devel,02/12] libcamera: camera_sensor: Make V4L2_CID_EXPOSURE mandatory","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e5e988d2162fe72a875c7e9428a4450979f57d75","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/10816/mbox/","series":[{"id":1568,"url":"https://patchwork.libcamera.org/api/series/1568/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1568","date":"2021-01-05T19:05:10","name":"android: Exposure times + scaler crop + android metadata","version":1,"mbox":"https://patchwork.libcamera.org/series/1568/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10816/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10816/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC3B8C0F1A\n\tfor ;\n\tTue, 5 Jan 2021 19:05:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6517663171;\n\tTue, 5 Jan 2021 20:05:16 +0100 (CET)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FD046297D\n\tfor ;\n\tTue, 5 Jan 2021 20:05:14 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 18445100002\n\tfor ;\n\tTue, 5 Jan 2021 19:05:13 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 5 Jan 2021 20:05:12 +0100","Message-Id":"<20210105190522.682324-3-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20210105190522.682324-1-jacopo@jmondi.org>","References":"<20210105190522.682324-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 02/12] libcamera: camera_sensor: Make\n\tV4L2_CID_EXPOSURE mandatory","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add the V4L2_CID_EXPOSURE control to the list of mandatory controls the\nsensor driver has to report and document this new requirement.\n\nSigned-off-by: Jacopo Mondi \n---\n Documentation/sensor_driver_requirements.rst | 11 ++++++++++-\n src/libcamera/camera_sensor.cpp | 1 +\n 2 files changed, 11 insertions(+), 1 deletion(-)","diff":"diff --git a/Documentation/sensor_driver_requirements.rst b/Documentation/sensor_driver_requirements.rst\nindex 0e658aaa03b5..97e98b9e12ef 100644\n--- a/Documentation/sensor_driver_requirements.rst\n+++ b/Documentation/sensor_driver_requirements.rst\n@@ -26,11 +26,20 @@ The sensor driver shall support the following V4L2 controls:\n \n * `V4L2_CID_HBLANK`_\n * `V4L2_CID_PIXEL_RATE`_\n+* `V4L2_CID_EXPOSURE`_\n \n .. _V4L2_CID_HBLANK: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-image-source.html\n .. _V4L2_CID_PIXEL_RATE: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-image-process.html\n+.. _V4L2_CID_EXPOSURE: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/control.html\n+\n+The `HBLANK` and `PIXEL_RATE` controls are used to compute the sensor\n+output timings.\n+\n+The `EXPOSURE` control shall report the image integration time in number of\n+lines. The V4L2 documentation does not specify a unit for this control, drivers\n+compliant with the V4L2 specification might need to be changed to be used by\n+libcamera.\n \n-Both controls are used to compute the sensor output timings.\n \n Optional Requirements\n ---------------------\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 05a1d7c22e97..f7939b94d2f8 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -245,6 +245,7 @@ int CameraSensor::validateSensorDriver()\n \tconst std::vector mandatoryControls{\n \t\tV4L2_CID_PIXEL_RATE,\n \t\tV4L2_CID_HBLANK,\n+\t\tV4L2_CID_EXPOSURE,\n \t};\n \n \tControlList ctrls = subdev_->getControls(mandatoryControls);\n","prefixes":["libcamera-devel","02/12"]}