[{"id":14455,"web_url":"https://patchwork.libcamera.org/comment/14455/","msgid":"","date":"2021-01-06T10:53:46","subject":"Re: [libcamera-devel] [PATCH v5 09/10] libcamera: camera_sensor:\n\tInitialize VIMC properties","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2021-01-05 13:31:27 +0100, Jacopo Mondi wrote:\n> The VIMC driver does not yet support all the features required\n> for all sensor drivers. As it is the main testing platforms and the\n> driver changes might take a long time to land in the developments\n> and testing platforms, temporary close the gap by skipping driver\n> validation and initializing properties with static information such\n> as the sensor resolution.\n> \n> Signed-off-by: Jacopo Mondi \n\nIt would have been nice if the workaround could be done inside the VIMC \npipeline handler but that may be to messy :-) As a temporary workaround \nI think this is good enough.\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/internal/camera_sensor.h | 1 +\n> src/libcamera/camera_sensor.cpp | 27 ++++++++++++++++++++++\n> 2 files changed, 28 insertions(+)\n> \n> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> index de6a0202d19a..759a12d16f72 100644\n> --- a/include/libcamera/internal/camera_sensor.h\n> +++ b/include/libcamera/internal/camera_sensor.h\n> @@ -70,6 +70,7 @@ protected:\n> private:\n> \tint generateId();\n> \tint validateSensorDriver();\n> +\tvoid initVIMCDefaultProperties();\n> \tint initProperties();\n> \n> \tconst MediaEntity *entity_;\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 0e8aff27b712..046474c03f4a 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -6,6 +6,7 @@\n> */\n> \n> #include \"libcamera/internal/camera_sensor.h\"\n> +#include \"libcamera/internal/media_device.h\"\n> \n> #include \n> #include \n> @@ -207,6 +208,21 @@ int CameraSensor::init()\n> \t */\n> \tresolution_ = sizes_.back();\n> \n> +\t/*\n> +\t * VIMC is a bit special, as it does not yet support all the\n> +\t * mandatory requirements regular sensors have to respect.\n> +\t *\n> +\t * Do not validate the driver if it's VIMC and initialize the\n> +\t * the sensor properties with static information.\n> +\t *\n> +\t * \\todo Remove the special case once the VIMC driver has been\n> +\t * updated in all test platforms.\n> +\t */\n> +\tif (entity_->device()->driver() == \"vimc\") {\n> +\t\tinitVIMCDefaultProperties();\n> +\t\treturn initProperties();\n> +\t}\n> +\n> \tret = validateSensorDriver();\n> \tif (ret)\n> \t\treturn ret;\n> @@ -306,6 +322,17 @@ int CameraSensor::validateSensorDriver()\n> \treturn 0;\n> }\n> \n> +/*\n> + * \\brief Initialize properties that cannot be intialized by the\n> + * regular initProperties() function for VIMC\n> + */\n> +void CameraSensor::initVIMCDefaultProperties()\n> +{\n> +\tpixelArraySize_ = resolution();\n> +\tactiveArea_ = Rectangle(pixelArraySize_);\n> +\tanalogueCrop_ = activeArea_;\n> +}\n> +\n> int CameraSensor::initProperties()\n> {\n> \t/*\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4654DC0F1C\n\tfor ;\n\tWed, 6 Jan 2021 10:53:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C296C631AB;\n\tWed, 6 Jan 2021 11:53:49 +0100 (CET)","from mail-lf1-x133.google.com (mail-lf1-x133.google.com\n\t[IPv6:2a00:1450:4864:20::133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D4D762D3E\n\tfor ;\n\tWed, 6 Jan 2021 11:53:48 +0100 (CET)","by mail-lf1-x133.google.com with SMTP id l11so5673448lfg.0\n\tfor ;\n\tWed, 06 Jan 2021 02:53:48 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tn6sm274044lfi.112.2021.01.06.02.53.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 06 Jan 2021 02:53:47 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"g97p+ud6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=t3gZnzh58m5wxjwIqXV7F0wOq4/kcAI6BYVrqvo5yys=;\n\tb=g97p+ud6AyMVi02WLmQ3jS5jPECWdMZptcbGYk7uKi+FFgt5NFTQ/wh13bSx867NH0\n\tS5GqJ9rGxr0dl2BTEscPEtzcpd4u8WU1N8uzeM1d2RXnOGKUdJpEPvlBvus9SJ8LjkDy\n\tJPMEQaDVQSBS2bCTSkk9k7yzJo1tNOAYOQQBnv8g1X/74Jk5KJ9oWsqrNjrbNCm9snVy\n\tWc4xtdkvC9q9eojpoWPwbUv34DnBUPIBfne9Qba/NQ3P5oQnNpi3NhDeQymK87mk1dza\n\t2uekOV0sv845vBnj8v0qjNDSiGyT8o7G8qwMhs/JBM/M/W8iAMR0EUtfHNRN0Mj/lMFB\n\tOMdg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=t3gZnzh58m5wxjwIqXV7F0wOq4/kcAI6BYVrqvo5yys=;\n\tb=KgFxq//pbe6uPodpwzE+3j6OgLttbx4fNE4gC/zOgmNmn7cJCz8Q7btY4MZ3mICRSr\n\tNXRmpqKWYWo2W7qtOK7JgeZB7ppzvTYhMI9kLtz9B+JyNmwNEWDWedFrCOU3tlqXMorx\n\tfaZEO6RQ+tO/OJ2N0Yt/Rg2cN+JuyeKuHplMAFdGqM1mrzXXi5DbeE8RGRbTQkAT2Hy+\n\t1QNRow+gxSeexMK5HQfblNkSgTsSNQRpVLOz277Juq9aYXonxMM4FrJstWyRB3O+MEPs\n\tpn2vKVN+wODmCCpjjSFRdll05Y0XzlIjEENLLiRbwZobs+8YPpwY3D+ht6/KzOX8yLaV\n\tJUSA==","X-Gm-Message-State":"AOAM531BWhkmT5eEZ+kCNnleDTYqE0e8BuufyIGIZJ4mU1MOL4k812Ao\n\tjSoQkHByqGU5jxQbLsMXkz39Vnd3c/4BKg==","X-Google-Smtp-Source":"ABdhPJxTAadzWc22dj7yxZYscCIGYB1Rt2Yw6mQPxwYodfIhoO/oF4KhR+qMkFC9D+Ckgtl9zs+PzA==","X-Received":"by 2002:a2e:b4d1:: with SMTP id\n\tr17mr1939353ljm.466.1609930427981; \n\tWed, 06 Jan 2021 02:53:47 -0800 (PST)","Date":"Wed, 6 Jan 2021 11:53:46 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210105123128.617543-1-jacopo@jmondi.org>\n\t<20210105123128.617543-10-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210105123128.617543-10-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v5 09/10] libcamera: camera_sensor:\n\tInitialize VIMC properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14460,"web_url":"https://patchwork.libcamera.org/comment/14460/","msgid":"","date":"2021-01-07T02:59:56","subject":"Re: [libcamera-devel] [PATCH v5 09/10] libcamera: camera_sensor:\n\tInitialize VIMC properties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Jan 05, 2021 at 01:31:27PM +0100, Jacopo Mondi wrote:\n> The VIMC driver does not yet support all the features required\n> for all sensor drivers. As it is the main testing platforms and the\n> driver changes might take a long time to land in the developments\n> and testing platforms, temporary close the gap by skipping driver\n> validation and initializing properties with static information such\n> as the sensor resolution.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/internal/camera_sensor.h | 1 +\n> src/libcamera/camera_sensor.cpp | 27 ++++++++++++++++++++++\n> 2 files changed, 28 insertions(+)\n> \n> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> index de6a0202d19a..759a12d16f72 100644\n> --- a/include/libcamera/internal/camera_sensor.h\n> +++ b/include/libcamera/internal/camera_sensor.h\n> @@ -70,6 +70,7 @@ protected:\n> private:\n> \tint generateId();\n> \tint validateSensorDriver();\n> +\tvoid initVIMCDefaultProperties();\n\ns/VIMC/Vimc/\n\n> \tint initProperties();\n> \n> \tconst MediaEntity *entity_;\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 0e8aff27b712..046474c03f4a 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -6,6 +6,7 @@\n> */\n> \n> #include \"libcamera/internal/camera_sensor.h\"\n> +#include \"libcamera/internal/media_device.h\"\n> \n> #include \n> #include \n> @@ -207,6 +208,21 @@ int CameraSensor::init()\n> \t */\n> \tresolution_ = sizes_.back();\n> \n> +\t/*\n> +\t * VIMC is a bit special, as it does not yet support all the\n> +\t * mandatory requirements regular sensors have to respect.\n> +\t *\n> +\t * Do not validate the driver if it's VIMC and initialize the\n> +\t * the sensor properties with static information.\n\ns/the the/the/\n\n(You could also reflow the text up to 80 columns)\n\n> +\t *\n> +\t * \\todo Remove the special case once the VIMC driver has been\n> +\t * updated in all test platforms.\n> +\t */\n> +\tif (entity_->device()->driver() == \"vimc\") {\n> +\t\tinitVIMCDefaultProperties();\n\nYou could have inlined the function here as it's really small, but it's\nno big deal.\n\nDid you btw implement the corresponding changes in vimc yet ? If not I\ncan help.\n\nReviewed-by: Laurent Pinchart \n\n> +\t\treturn initProperties();\n> +\t}\n> +\n> \tret = validateSensorDriver();\n> \tif (ret)\n> \t\treturn ret;\n> @@ -306,6 +322,17 @@ int CameraSensor::validateSensorDriver()\n> \treturn 0;\n> }\n> \n> +/*\n> + * \\brief Initialize properties that cannot be intialized by the\n> + * regular initProperties() function for VIMC\n> + */\n> +void CameraSensor::initVIMCDefaultProperties()\n> +{\n> +\tpixelArraySize_ = resolution();\n> +\tactiveArea_ = Rectangle(pixelArraySize_);\n> +\tanalogueCrop_ = activeArea_;\n> +}\n> +\n> int CameraSensor::initProperties()\n> {\n> \t/*","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC515C0F1C\n\tfor ;\n\tThu, 7 Jan 2021 03:00:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7D338631AC;\n\tThu, 7 Jan 2021 04:00:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9240E6010E\n\tfor ;\n\tThu, 7 Jan 2021 04:00:09 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 06E3A2E0;\n\tThu, 7 Jan 2021 04:00:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UBtQ7Qoi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1609988409;\n\tbh=N7V9KVC1ixQabl9LdhaHef3jq+ejRSGl89HK54VGUWM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UBtQ7Qoig0lCi86Qkz/XBJrL2Q4Y0j1OhbZJw7TFIl2TfJ5wXv09pe7q8HAOvqjYx\n\tv8UYhC8KTvMRf3sLrx7vE0ct1oeeb16hzw72TmUL3/ASkjHJee9WHdTm8jOGLs5bc/\n\tdOwGbZpoop2lwOO0gPkE2SpM5ED5T2xruD86A+I8=","Date":"Thu, 7 Jan 2021 04:59:56 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210105123128.617543-1-jacopo@jmondi.org>\n\t<20210105123128.617543-10-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210105123128.617543-10-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v5 09/10] libcamera: camera_sensor:\n\tInitialize VIMC properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14466,"web_url":"https://patchwork.libcamera.org/comment/14466/","msgid":"<20210107081010.yeewpbscqrlqjx5y@uno.localdomain>","date":"2021-01-07T08:10:10","subject":"Re: [libcamera-devel] [PATCH v5 09/10] libcamera: camera_sensor:\n\tInitialize VIMC properties","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Thu, Jan 07, 2021 at 04:59:56AM +0200, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Tue, Jan 05, 2021 at 01:31:27PM +0100, Jacopo Mondi wrote:\n> > The VIMC driver does not yet support all the features required\n> > for all sensor drivers. As it is the main testing platforms and the\n> > driver changes might take a long time to land in the developments\n> > and testing platforms, temporary close the gap by skipping driver\n> > validation and initializing properties with static information such\n> > as the sensor resolution.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > include/libcamera/internal/camera_sensor.h | 1 +\n> > src/libcamera/camera_sensor.cpp | 27 ++++++++++++++++++++++\n> > 2 files changed, 28 insertions(+)\n> >\n> > diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> > index de6a0202d19a..759a12d16f72 100644\n> > --- a/include/libcamera/internal/camera_sensor.h\n> > +++ b/include/libcamera/internal/camera_sensor.h\n> > @@ -70,6 +70,7 @@ protected:\n> > private:\n> > \tint generateId();\n> > \tint validateSensorDriver();\n> > +\tvoid initVIMCDefaultProperties();\n>\n> s/VIMC/Vimc/\n>\n> > \tint initProperties();\n> >\n> > \tconst MediaEntity *entity_;\n> > diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> > index 0e8aff27b712..046474c03f4a 100644\n> > --- a/src/libcamera/camera_sensor.cpp\n> > +++ b/src/libcamera/camera_sensor.cpp\n> > @@ -6,6 +6,7 @@\n> > */\n> >\n> > #include \"libcamera/internal/camera_sensor.h\"\n> > +#include \"libcamera/internal/media_device.h\"\n> >\n> > #include \n> > #include \n> > @@ -207,6 +208,21 @@ int CameraSensor::init()\n> > \t */\n> > \tresolution_ = sizes_.back();\n> >\n> > +\t/*\n> > +\t * VIMC is a bit special, as it does not yet support all the\n> > +\t * mandatory requirements regular sensors have to respect.\n> > +\t *\n> > +\t * Do not validate the driver if it's VIMC and initialize the\n> > +\t * the sensor properties with static information.\n>\n> s/the the/the/\n>\n> (You could also reflow the text up to 80 columns)\n>\n> > +\t *\n> > +\t * \\todo Remove the special case once the VIMC driver has been\n> > +\t * updated in all test platforms.\n> > +\t */\n> > +\tif (entity_->device()->driver() == \"vimc\") {\n> > +\t\tinitVIMCDefaultProperties();\n>\n> You could have inlined the function here as it's really small, but it's\n> no big deal.\n>\n> Did you btw implement the corresponding changes in vimc yet ? If not I\n> can help.\n\nNot yet. The 'hardest' part should be figure out meaningful values to\nreturn for the PIXEL_RATE and VBLANK controls, the implementation\nitself should be trivial.\n\nThanks\n j\n\n>\n> Reviewed-by: Laurent Pinchart \n>\n> > +\t\treturn initProperties();\n> > +\t}\n> > +\n> > \tret = validateSensorDriver();\n> > \tif (ret)\n> > \t\treturn ret;\n> > @@ -306,6 +322,17 @@ int CameraSensor::validateSensorDriver()\n> > \treturn 0;\n> > }\n> >\n> > +/*\n> > + * \\brief Initialize properties that cannot be intialized by the\n> > + * regular initProperties() function for VIMC\n> > + */\n> > +void CameraSensor::initVIMCDefaultProperties()\n> > +{\n> > +\tpixelArraySize_ = resolution();\n> > +\tactiveArea_ = Rectangle(pixelArraySize_);\n> > +\tanalogueCrop_ = activeArea_;\n> > +}\n> > +\n> > int CameraSensor::initProperties()\n> > {\n> > \t/*\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6DA45C3256\n\tfor ;\n\tThu, 7 Jan 2021 08:09:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E3B40631D0;\n\tThu, 7 Jan 2021 09:09:56 +0100 (CET)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA13360318\n\tfor ;\n\tThu, 7 Jan 2021 09:09:55 +0100 (CET)","from uno.localdomain (unknown [93.56.74.111])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id E52424000A;\n\tThu, 7 Jan 2021 08:09:54 +0000 (UTC)"],"X-Originating-IP":"93.56.74.111","Date":"Thu, 7 Jan 2021 09:10:10 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210107081010.yeewpbscqrlqjx5y@uno.localdomain>","References":"<20210105123128.617543-1-jacopo@jmondi.org>\n\t<20210105123128.617543-10-jacopo@jmondi.org>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v5 09/10] libcamera: camera_sensor:\n\tInitialize VIMC properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]