{"id":10800,"url":"https://patchwork.libcamera.org/api/patches/10800/?format=json","web_url":"https://patchwork.libcamera.org/patch/10800/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210101171553.32727-2-andrey.konovalov@linaro.org>","date":"2021-01-01T17:15:52","name":"[libcamera-devel,RFC,v2,1/2] qcam: viewfinder_gl: change uniform float tex_stepx to vec2 tex_step","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6c3654377fc5dccf7b2189c61be5de913dbd2834","submitter":{"id":25,"url":"https://patchwork.libcamera.org/api/people/25/?format=json","name":"Andrey Konovalov","email":"andrey.konovalov@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10800/mbox/","series":[{"id":1565,"url":"https://patchwork.libcamera.org/api/series/1565/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1565","date":"2021-01-01T17:15:51","name":"qcam: viewfinder_gl: add RAW12P format support","version":2,"mbox":"https://patchwork.libcamera.org/series/1565/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10800/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10800/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B92CC0F1A\n\tfor ;\n\tFri, 1 Jan 2021 17:16:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A35862000;\n\tFri, 1 Jan 2021 18:16:22 +0100 (CET)","from mail-lf1-x130.google.com (mail-lf1-x130.google.com\n\t[IPv6:2a00:1450:4864:20::130])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A86846031C\n\tfor ;\n\tFri, 1 Jan 2021 18:16:20 +0100 (CET)","by mail-lf1-x130.google.com with SMTP id l11so49903562lfg.0\n\tfor ;\n\tFri, 01 Jan 2021 09:16:20 -0800 (PST)","from localhost.localdomain ([85.249.43.69])\n\tby smtp.googlemail.com with ESMTPSA id\n\tm12sm7873213lji.110.2021.01.01.09.16.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 01 Jan 2021 09:16:19 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"AyFzw4d6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=olzp5+f2p8vLdXof0aF2IDvl6Y/vw19jdOA72WR6mWo=;\n\tb=AyFzw4d6PIeDXemBIme0OHCdHCeD9dpvRz+pgYIfDVcT5Uxmmup03I5g1tAqYNSn7N\n\ti5tZF+hCbvY1iW+NT/CIqY00jpX1thyO1cJZ1QllKUnleEAj9OWW5+usLvzuMvCpvyCY\n\tS6hAO3fcm2QMn4dmq6U+BH6zy/omu7zMw4gbISSl8c4N74+aYnPmXR46UC03V3SFCscb\n\t5yuvPX2PdnVHgJvIhd6vCN/+b86a8oqjT4hPU5II6MKVtLGGuYjeedj1K4NfeYbMLWd3\n\tPqwSEYDb1rsaF0/c3lAyPDQsGZxv734Zl0qp9PiH0iRsZV51uPuT/i3B6HDTDLDSz61I\n\tf0OQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=olzp5+f2p8vLdXof0aF2IDvl6Y/vw19jdOA72WR6mWo=;\n\tb=jQIVBFAcrTfw8oGPi4p6y2bsEqehYsNGefuqImyFK8DFtxdBR8msGrz6T69JpDLGAu\n\t3AeLmrwOCULGhLmrHOXCrVGuJaQd5SFj2cSkXJFbwrGdo//sGGMItiYDzzw0wFQ3znsQ\n\tYpyeEnNPWwZTWWJxhGTVn2eBGFZbwb4/vpXrR0/Kl//uCpfonihhy0zsAA/xB1XXlT8G\n\t2XuyFW04r/he7mRCZ5GYtxRCJYAhnkdS9nEJnCg2LR9oGM+0nk4QuhmYGq9ASNGHRmsR\n\t0rHhVc6wEnLtE4OQ/ON0Rd2rtjLntJVvg0InCsDqOHiaei9LjhlJPlNwfn4ncD3CXfWi\n\tjmnQ==","X-Gm-Message-State":"AOAM533oV+EPCSqmOfeW12wKfrDuICXC2QcYJSgCJz0ieeiHlikY7kj2\n\tF97eNxWufftKP0iMOAasHGuhvevQbPHNlNQ1","X-Google-Smtp-Source":"ABdhPJxDmTqjWq0omseuIry97X5UX/ayLcTp0FosM48F7eFGs+l9r4fwF9TzzbZwGjKVvEQDeCjofA==","X-Received":"by 2002:a2e:6818:: with SMTP id\n\tc24mr32603941lja.184.1609521379717; \n\tFri, 01 Jan 2021 09:16:19 -0800 (PST)","From":"Andrey Konovalov ","To":"libcamera-devel@lists.libcamera.org,\n\tlaurent.pinchart@ideasonboard.com","Date":"Fri, 1 Jan 2021 20:15:52 +0300","Message-Id":"<20210101171553.32727-2-andrey.konovalov@linaro.org>","X-Mailer":"git-send-email 2.17.1","In-Reply-To":"<20210101171553.32727-1-andrey.konovalov@linaro.org>","References":"<20210101171553.32727-1-andrey.konovalov@linaro.org>","Subject":"[libcamera-devel] [PATCH][RFC v2 1/2] qcam: viewfinder_gl: change\n\tuniform float tex_stepx to vec2 tex_step","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"morgan@casual-effects.com","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In preparation to extend the supported formats, extend the tex_stepx\nuniform to cover the steps between texels in both horizontal and\nvertical directions.\n\nSigned-off-by: Andrey Konovalov \n---\n src/qcam/assets/shader/YUV_packed.frag | 8 ++++----\n src/qcam/viewfinder_gl.cpp | 7 ++++---\n src/qcam/viewfinder_gl.h | 2 +-\n 3 files changed, 9 insertions(+), 8 deletions(-)","diff":"diff --git a/src/qcam/assets/shader/YUV_packed.frag b/src/qcam/assets/shader/YUV_packed.frag\nindex 224dfafe..d6efd4ce 100644\n--- a/src/qcam/assets/shader/YUV_packed.frag\n+++ b/src/qcam/assets/shader/YUV_packed.frag\n@@ -12,7 +12,7 @@ precision mediump float;\n varying vec2 textureOut;\n \n uniform sampler2D tex_y;\n-uniform float tex_stepx;\n+uniform vec2 tex_step;\n \n void main(void)\n {\n@@ -49,10 +49,10 @@ void main(void)\n \t * a = fract(x) * 2 - 1\t\t\tif fract(x) >= 0.5\n \t */\n \tvec2 pos = textureOut;\n-\tfloat f_x = fract(pos.x / tex_stepx);\n+\tfloat f_x = fract(pos.x / tex_step.x);\n \n-\tvec4 left = texture2D(tex_y, vec2(pos.x - f_x * tex_stepx, pos.y));\n-\tvec4 right = texture2D(tex_y, vec2(pos.x + (1.0 - f_x) * tex_stepx , pos.y));\n+\tvec4 left = texture2D(tex_y, vec2(pos.x - f_x * tex_step.x, pos.y));\n+\tvec4 right = texture2D(tex_y, vec2(pos.x + (1.0 - f_x) * tex_step.x , pos.y));\n \n #if defined(YUV_PATTERN_UYVY)\n \tfloat y_left = mix(left.g, left.a, f_x * 2.0);\ndiff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\nindex 5d9b442e..ff719418 100644\n--- a/src/qcam/viewfinder_gl.cpp\n+++ b/src/qcam/viewfinder_gl.cpp\n@@ -289,7 +289,7 @@ bool ViewFinderGL::createFragmentShader()\n \ttextureUniformY_ = shaderProgram_.uniformLocation(\"tex_y\");\n \ttextureUniformU_ = shaderProgram_.uniformLocation(\"tex_u\");\n \ttextureUniformV_ = shaderProgram_.uniformLocation(\"tex_v\");\n-\ttextureUniformStepX_ = shaderProgram_.uniformLocation(\"tex_stepx\");\n+\ttextureUniformStep_ = shaderProgram_.uniformLocation(\"tex_step\");\n \n \t/* Create the textures. */\n \tfor (std::unique_ptr &texture : textures_) {\n@@ -508,8 +508,9 @@ void ViewFinderGL::doRender()\n \t\t * ([0, 1]). There are exactly width - 1 steps between the\n \t\t * leftmost and rightmost texels.\n \t\t */\n-\t\tshaderProgram_.setUniformValue(textureUniformStepX_,\n-\t\t\t\t\t 1.0f / (size_.width() / 2 - 1));\n+\t\tshaderProgram_.setUniformValue(textureUniformStep_,\n+\t\t\t\t\t 1.0f / (size_.width() / 2 - 1),\n+\t\t\t\t\t 1.0f /* not used */);\n \t\tbreak;\n \n \tcase libcamera::formats::ABGR8888:\ndiff --git a/src/qcam/viewfinder_gl.h b/src/qcam/viewfinder_gl.h\nindex 150fa4ae..1b1faa91 100644\n--- a/src/qcam/viewfinder_gl.h\n+++ b/src/qcam/viewfinder_gl.h\n@@ -85,7 +85,7 @@ private:\n \tGLuint textureUniformU_;\n \tGLuint textureUniformV_;\n \tGLuint textureUniformY_;\n-\tGLuint textureUniformStepX_;\n+\tGLuint textureUniformStep_;\n \tunsigned int horzSubSample_;\n \tunsigned int vertSubSample_;\n \n","prefixes":["libcamera-devel","RFC","v2","1/2"]}