[{"id":14442,"web_url":"https://patchwork.libcamera.org/comment/14442/","msgid":"","date":"2021-01-04T13:23:07","subject":"Re: [libcamera-devel] [PATCH v4 6/6] android: camera_device: Do not\n\tdefault pixel array properties","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-12-31 00:06:03 +0100, Jacopo Mondi wrote:\n> Now that the pixel array properties have been defaulted in the\n> CameraSensor class, they will always be reported by the\n> libcamera::Camera and there's no need to default them in the\n> Camera HAL.\n> \n> Remove defaults and assume properties are always there.\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 20 ++------------------\n> 1 file changed, 2 insertions(+), 18 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 7678d4485ce9..9912875ea046 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -851,7 +851,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstaticMetadata_->addEntry(ANDROID_JPEG_MAX_SIZE, &maxJpegBufferSize_, 1);\n> \n> \t/* Sensor static metadata. */\n> -\tif (properties.contains(properties::PixelArraySize)) {\n> +\t{\n> \t\tconst Size &size =\n> \t\t\tproperties.get(properties::PixelArraySize);\n> \t\tstd::vector data{\n> @@ -860,17 +860,9 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\t};\n> \t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_PIXEL_ARRAY_SIZE,\n> \t\t\t\t\t data.data(), data.size());\n> -\t} else {\n> -\t\t/*\n> -\t\t * \\todo Drop the default once the ov5670 and ov13858 drivers\n> -\t\t * are updated to report the pixel array size.\n> -\t\t */\n> -\t\tint32_t data[] = { 2592, 1944 };\n> -\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_PIXEL_ARRAY_SIZE,\n> -\t\t\t\t\t data, 2);\n> \t}\n> \n> -\tif (properties.contains(properties::PixelArrayActiveAreas)) {\n> +\t{\n> \t\tconst Span &rects =\n> \t\t\tproperties.get(properties::PixelArrayActiveAreas);\n> \t\tstd::vector data{\n> @@ -881,14 +873,6 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\t};\n> \t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n> \t\t\t\t\t data.data(), data.size());\n> -\t} else {\n> -\t\t/*\n> -\t\t * \\todo Drop the default once the ov5670 and ov13858 drivers\n> -\t\t * are updated to report the pixel array size.\n> -\t\t */\n> -\t\tint32_t data[] = { 0, 0, 2560, 1920 };\n> -\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n> -\t\t\t\t\t data, 4);\n> \t}\n> \n> \tint32_t sensitivityRange[] = {\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7677C0F1C\n\tfor ;\n\tMon, 4 Jan 2021 13:23:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B0CD862015;\n\tMon, 4 Jan 2021 14:23:10 +0100 (CET)","from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com\n\t[IPv6:2a00:1450:4864:20::12d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF0356200B\n\tfor ;\n\tMon, 4 Jan 2021 14:23:08 +0100 (CET)","by mail-lf1-x12d.google.com with SMTP id 23so64155874lfg.10\n\tfor ;\n\tMon, 04 Jan 2021 05:23:08 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tv18sm7290266lfg.24.2021.01.04.05.23.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 04 Jan 2021 05:23:07 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"BEZeUOxJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=GwP/4sN/6pGg4+kv3XEsVWbuEpTCPoARITxMHl2kq1k=;\n\tb=BEZeUOxJgn7Yn3nIze34h81D5SlJ0Yfd4bMYke9XBg6D6GnnkZVrmqBEk3DI23BsOY\n\tzpYSKapz+ESuUBRI7IRklFaEKrxWItifd3bIDmGbBhkdqrIeFA/O8PoBlWgvi7q0LzSf\n\tNlzXoTvZLQxBr1fgreJRTDSDQKSwvI3GbzpBvCabwdYEVFSl3mVOhxEMg51TXd1H3fGj\n\tl+Lj6jjYHAH7NA2AAYK9JfdiesnKAfffm9WZTjqMJTMsSi4wQpGpOZrcN2Tm2kKbE90H\n\tXN1JrmO+k8qAi8/BAftbDbCd19rP98U1QHc28bXJ2DNMIoFZCYyFLnach1+fPQI3DRv1\n\tdwYA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=GwP/4sN/6pGg4+kv3XEsVWbuEpTCPoARITxMHl2kq1k=;\n\tb=Y/+bGsyCtjdGW4fFz0sGf6LhnX+uLXBXdF/EppDIJSIBnT62NYLVNgs1WB3irS7kSF\n\tYxLsDfi2P6ECL9WUWAKxZ8aQoKNg6ABC+SGZIS8UeGR5L6LrWzN3fxY36gZvx/4jC5Gb\n\tjTLrlKBgHQ1cJPGhJgJknoptxGDqiuqUHGQaM+q5NKiQK/3vR/25YqiYi0SJnIXTYtox\n\tq1yqv0Tqrwdzo0mbt2Zr0xBsprsnBOo/1SwRuc2Fprp4wCz6x2bits78BGTLIG2V1UQw\n\tQMuhD1hrgg/PftufzQf73zlUSMPa1HrWlp5fmF5j7ydVuZcX5swXC1Lqq/xioFwxuFtG\n\t7YfA==","X-Gm-Message-State":"AOAM532XTWqYBpzNQSFNyUM25gltOTPCIy/Ojlwbj0jqnDsYSsRMxucE\n\tbwDXOYyr5FhYAEoXpsmrCKoIWH/+vb37Kg==","X-Google-Smtp-Source":"ABdhPJz5qTLrBQhiaLArT7cBOywgZixZB81ZJhdd4Qxr8G39pWSDOUoJVyW9crdrC7mzYFqT1psi/g==","X-Received":"by 2002:a05:6512:3211:: with SMTP id\n\td17mr34605700lfe.468.1609766588202; \n\tMon, 04 Jan 2021 05:23:08 -0800 (PST)","Date":"Mon, 4 Jan 2021 14:23:07 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201230230603.123486-1-jacopo@jmondi.org>\n\t<20201230230603.123486-7-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201230230603.123486-7-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v4 6/6] android: camera_device: Do not\n\tdefault pixel array properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]