[{"id":14441,"web_url":"https://patchwork.libcamera.org/comment/14441/","msgid":"","date":"2021-01-04T13:22:01","subject":"Re: [libcamera-devel] [PATCH v4 5/6] libcamera: camera_sensor: Do\n\tnot default 'rotation'","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2020-12-31 00:06:02 +0100, Jacopo Mondi wrote:\n> The 'rotation' property is not critical. Only register it if the\n> sensor driver reports it.\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/camera_sensor.cpp | 8 +++-----\n> 1 file changed, 3 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 98207cde71f5..ae7b33bddeab 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -374,13 +374,11 @@ int CameraSensor::initProperties()\n> \t}\n> \tproperties_.set(properties::Location, propertyValue);\n> \n> -\t/* Camera Rotation: default is 0 degrees. */\n> \tconst auto &rotationControl = controls.find(V4L2_CID_CAMERA_SENSOR_ROTATION);\n> -\tif (rotationControl != controls.end())\n> +\tif (rotationControl != controls.end()) {\n> \t\tpropertyValue = rotationControl->second.def().get();\n> -\telse\n> -\t\tpropertyValue = 0;\n> -\tproperties_.set(properties::Rotation, propertyValue);\n> +\t\tproperties_.set(properties::Rotation, propertyValue);\n> +\t}\n> \n> \tproperties_.set(properties::PixelArraySize, pixelArraySize_);\n> \tproperties_.set(properties::PixelArrayActiveAreas, { activeArea_ });\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2E44C0F1C\n\tfor ;\n\tMon, 4 Jan 2021 13:22:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 458C06200F;\n\tMon, 4 Jan 2021 14:22:05 +0100 (CET)","from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com\n\t[IPv6:2a00:1450:4864:20::12e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A94A62007\n\tfor ;\n\tMon, 4 Jan 2021 14:22:03 +0100 (CET)","by mail-lf1-x12e.google.com with SMTP id h22so64291428lfu.2\n\tfor ;\n\tMon, 04 Jan 2021 05:22:03 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tf29sm7294163lfj.47.2021.01.04.05.22.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 04 Jan 2021 05:22:02 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"mwY8VIff\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=KT9fblTmndnOkhFhe31b+XhILZ0djqnC9WAm+cUbSXk=;\n\tb=mwY8VIffXgM1O+KmPPhx0//J6hcZ15c56WA28NQJsjuaFZKXDAei9TjPvhs3wRGCuf\n\tB9yMHx5WqM8St154zV2/vDgXYafKOss5NNeWwUOHm7qQVG/474NKiIMxZ9FRgNvgWqO7\n\tJBfvu4qmvMECfXRvfEXoISyvCmfhhXtNmhzjmFg1yJ+3bzIUy8LQ9eYeUtjdwZkeiY9A\n\trsuj452gL5fLB+Qa9sh52cHhVMttTPFtWLfMxuAtpM+zEryXVRC4RBEzGIodZWXTLuUj\n\ttG2WYmGMqpJIW3YA6YVW389QMnotXS+W2IUAhYR512UOgPUccyZ4bny4dYKSf1qAaIfk\n\tPJqw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=KT9fblTmndnOkhFhe31b+XhILZ0djqnC9WAm+cUbSXk=;\n\tb=tBrPJHmgDo1tUq2Sfa4JA++iQ3j0IurbtlQ33ifyHDvRgAYzDcjnVgY4nc1OjeJwde\n\tlHiQImhNrhoGMzciGXbzWPmJmPzrxJHAt46GV2InVL/vUKpmYEUIkeN+3QjUytyQ7yT4\n\toh/9c2ga59myWhYVdHARv+j2Jemobcq8ItUVsO2CQQrup8ZFBSYJSZZTh1GjaldjerSI\n\ttka0s3s16sPr0DEyxKhRPmMzlDnNjWh7PuTJZpWboc1I5zwgm3G0+d+qHL+CuFAv8hOa\n\tDqJRi7p8rxhN8cgTHq5S6JNmhe0kL6zvFBpUDtks76czdgnqjkfw5Anlq3szbOpPBJ+M\n\tOpPQ==","X-Gm-Message-State":"AOAM533lGvg1ar2XFzLaTyyRypavO2udnuDpAsl/ZCCdcJDC7LyXui2R\n\tmrEo9kFwuY+hWRL5ZtyZuabyGgyBWb3ngw==","X-Google-Smtp-Source":"ABdhPJzv+lB70SxbAVOtD4HFKuYLN0a2/B9HcTfZ+ZO9rTt/pWPGsnuQWEn/mYiR67/jQ9CrqVISZA==","X-Received":"by 2002:a05:6512:20d2:: with SMTP id\n\tu18mr30439679lfr.47.1609766523008; \n\tMon, 04 Jan 2021 05:22:03 -0800 (PST)","Date":"Mon, 4 Jan 2021 14:22:01 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201230230603.123486-1-jacopo@jmondi.org>\n\t<20201230230603.123486-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201230230603.123486-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v4 5/6] libcamera: camera_sensor: Do\n\tnot default 'rotation'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]