{"id":1079,"url":"https://patchwork.libcamera.org/api/patches/1079/?format=json","web_url":"https://patchwork.libcamera.org/patch/1079/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190419101839.10337-7-jacopo@jmondi.org>","date":"2019-04-19T10:18:37","name":"[libcamera-devel,v7,6/8] libcamera: ipu3: Queue requests for multiple streams","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9c0cc2ecdef9fe19262e4c228ae976d98bcf39d7","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1079/mbox/","series":[{"id":261,"url":"https://patchwork.libcamera.org/api/series/261/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=261","date":"2019-04-19T10:18:31","name":"libcamera: ipu3: Multiple streams support","version":7,"mbox":"https://patchwork.libcamera.org/series/261/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1079/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1079/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A20B560DC0\n\tfor ;\n\tFri, 19 Apr 2019 12:17:55 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 0A621FF80C;\n\tFri, 19 Apr 2019 10:17:54 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 19 Apr 2019 12:18:37 +0200","Message-Id":"<20190419101839.10337-7-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190419101839.10337-1-jacopo@jmondi.org>","References":"<20190419101839.10337-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v7 6/8] libcamera: ipu3: Queue requests\n\tfor multiple streams","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 19 Apr 2019 10:17:55 -0000"},"content":"Add support for queueing requests for multiple streams in the IPU3\npipeline handler class.\n\nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 23 +++++++++--------------\n 1 file changed, 9 insertions(+), 14 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex fe671b95ed8e..8fa59157532e 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -563,25 +563,20 @@ void PipelineHandlerIPU3::stop(Camera *camera)\n \n int PipelineHandlerIPU3::queueRequest(Camera *camera, Request *request)\n {\n-\tIPU3CameraData *data = cameraData(camera);\n-\tV4L2Device *output = data->imgu_->output_.dev;\n-\tIPU3Stream *stream = &data->outStream_;\n+\tint error = 0;\n \n-\t/* Queue a buffer to the ImgU output for capture. */\n-\tBuffer *buffer = request->findBuffer(stream);\n-\tif (!buffer) {\n-\t\tLOG(IPU3, Error)\n-\t\t\t<< \"Attempt to queue request with invalid stream\";\n-\t\treturn -ENOENT;\n-\t}\n+\tfor (auto it : request->buffers()) {\n+\t\tIPU3Stream *stream = static_cast(it.first);\n+\t\tBuffer *buffer = it.second;\n \n-\tint ret = output->queueBuffer(buffer);\n-\tif (ret < 0)\n-\t\treturn ret;\n+\t\tint ret = stream->device_->dev->queueBuffer(buffer);\n+\t\tif (ret < 0)\n+\t\t\terror = ret;\n+\t}\n \n \tPipelineHandler::queueRequest(camera, request);\n \n-\treturn 0;\n+\treturn error;\n }\n \n bool PipelineHandlerIPU3::match(DeviceEnumerator *enumerator)\n","prefixes":["libcamera-devel","v7","6/8"]}