[{"id":14440,"web_url":"https://patchwork.libcamera.org/comment/14440/","msgid":"","date":"2021-01-04T13:20:02","subject":"Re: [libcamera-devel] [PATCH v4 4/6] libcamera: camera_sensor:\n\tDefault 'location' to External","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-12-31 00:06:01 +0100, Jacopo Mondi wrote:\n> If the sensor driver does not report the camera location default it\n> to 'External' instead of 'Front'.\n> \n> As the camera location is used to construct the camera unique name\n> presented to the user, it makes more sense to report multiple 'External'\n> cameras instead of multiple 'Front' ones.\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/camera_sensor.cpp | 11 +++++------\n> 1 file changed, 5 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index bf0d6b06ae20..98207cde71f5 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -349,7 +349,6 @@ int CameraSensor::initProperties()\n> \tconst ControlInfoMap &controls = subdev_->controls();\n> \tint32_t propertyValue;\n> \n> -\t/* Camera Location: default is front location. */\n> \tconst auto &orientation = controls.find(V4L2_CID_CAMERA_ORIENTATION);\n> \tif (orientation != controls.end()) {\n> \t\tint32_t v4l2Orientation = orientation->second.def().get();\n> @@ -358,20 +357,20 @@ int CameraSensor::initProperties()\n> \t\tdefault:\n> \t\t\tLOG(CameraSensor, Warning)\n> \t\t\t\t<< \"Unsupported camera location \"\n> -\t\t\t\t<< v4l2Orientation << \", setting to Front\";\n> +\t\t\t\t<< v4l2Orientation << \", setting to External\";\n> \t\t\t/* Fall-through */\n> +\t\tcase V4L2_CAMERA_ORIENTATION_EXTERNAL:\n> +\t\t\tpropertyValue = properties::CameraLocationExternal;\n> +\t\t\tbreak;\n> \t\tcase V4L2_CAMERA_ORIENTATION_FRONT:\n> \t\t\tpropertyValue = properties::CameraLocationFront;\n> \t\t\tbreak;\n> \t\tcase V4L2_CAMERA_ORIENTATION_BACK:\n> \t\t\tpropertyValue = properties::CameraLocationBack;\n> \t\t\tbreak;\n> -\t\tcase V4L2_CAMERA_ORIENTATION_EXTERNAL:\n> -\t\t\tpropertyValue = properties::CameraLocationExternal;\n> -\t\t\tbreak;\n> \t\t}\n> \t} else {\n> -\t\tpropertyValue = properties::CameraLocationFront;\n> +\t\tpropertyValue = properties::CameraLocationExternal;\n> \t}\n> \tproperties_.set(properties::Location, propertyValue);\n> \n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E831AC0F1A\n\tfor ;\n\tMon, 4 Jan 2021 13:20:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B866B6200B;\n\tMon, 4 Jan 2021 14:20:04 +0100 (CET)","from mail-lf1-x131.google.com (mail-lf1-x131.google.com\n\t[IPv6:2a00:1450:4864:20::131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E28D62007\n\tfor ;\n\tMon, 4 Jan 2021 14:20:04 +0100 (CET)","by mail-lf1-x131.google.com with SMTP id b26so64230823lff.9\n\tfor ;\n\tMon, 04 Jan 2021 05:20:04 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\to14sm5105518lfi.92.2021.01.04.05.20.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 04 Jan 2021 05:20:02 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"iwIM1naJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=4XXeTsJbUtdFQU3VW6qcsxWt+7EaCjyexeaCU/is4bQ=;\n\tb=iwIM1naJ70S5v7wfjvu5jdj9u+77InqBbF0M7sAMDmI+Q7itzh5OVRbp6nURuVqMkk\n\tiL/v/rwr/2fGt5002tg8i0sddeeSBP3aPq/Z1ore4s20zfq6k1WWIkTfR8C9Yg9+QOed\n\tj2xb99G2NLWAnHD3wfotL4gWAbT6twTzY6vGAo5YiFiXDcDoBlu3rObrbPB5GXjMGdHp\n\tDGsuuO6GGZt4bzB6JD1bTztgC+r57W2A1s5zNDdh0bHGh2z0Zf9FuC5itKs7FQbO0vol\n\tmu25dJI8h80+cS7ruMGoBmEs2KczuxffLpGPyjjf/ObZcZj2s3Aj7DVqcMdmVdZyuPJa\n\t83XQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=4XXeTsJbUtdFQU3VW6qcsxWt+7EaCjyexeaCU/is4bQ=;\n\tb=l53inXz8RluWpTZBSRVI5DZeehAjk3ASqhne33sxfgDVVcwKPDRciDYoXSfIP5V+ho\n\t6eYYcqT8hx3e74+lGlMFYerH7sfsNgZ7xcd3tdjyrXyCg34ZNSat5JfVdES7OJf10rOR\n\tnRcnbmPRAuNAj5yghBHMPs6IwO5GCeE2UcJeTf8Ot3hiiB1A8/EUX9kjhgLAaFaR1ooX\n\t8NRIhjoZx217OrAWWpNr8aLCfO5UfhgQJDgFI2Ws7wkHxtKYfT7e/dRzLG4GXCXOO7+k\n\tIPXojrgWXwOjZbA8utu5Dxcxm+vhhWt7g/06QK7q3scQlwhmlp30gVtziUaaES0HYLA0\n\t3wyg==","X-Gm-Message-State":"AOAM530vlTFXJ+0Ot+9QJK2Q5m2zDt4/JDABrNF+mO7ovA9+OEbDpnhC\n\tzP4zLuXVhRgaMIAoscCjwfrC21xIEQ6WPQ==","X-Google-Smtp-Source":"ABdhPJyKR3v5uhqWUfZ4F+YNlx3maJUemBpCwH9GRo1zPdtmewaRCCWKBjbGSefWVXCwW/iHjNh44g==","X-Received":"by 2002:a19:8c04:: with SMTP id\n\to4mr30910421lfd.333.1609766403547; \n\tMon, 04 Jan 2021 05:20:03 -0800 (PST)","Date":"Mon, 4 Jan 2021 14:20:02 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201230230603.123486-1-jacopo@jmondi.org>\n\t<20201230230603.123486-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201230230603.123486-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v4 4/6] libcamera: camera_sensor:\n\tDefault 'location' to External","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]