[{"id":14426,"web_url":"https://patchwork.libcamera.org/comment/14426/","msgid":"","date":"2020-12-30T20:15:40","subject":"Re: [libcamera-devel] [PATCH v3 5/6] libcamera: camera_sensor: Do\n\tnot default 'rotation'","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Dec 30, 2020 at 07:01:19PM +0100, Jacopo Mondi wrote:\n> The 'rotation' property is not critical. Only register if the\n\ns/register/register it/\n\n> sensor driver reports it.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/camera_sensor.cpp | 7 +------\n> 1 file changed, 1 insertion(+), 6 deletions(-)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 1a316da45511..f7b20b396914 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -379,16 +379,11 @@ int CameraSensor::initProperties()\n> \t}\n> \tproperties_.set(properties::Location, propertyValue);\n> \n> -\t/* Camera Rotation: default is 0 degrees. */\n> \tconst auto &rotationControl = controls.find(V4L2_CID_CAMERA_SENSOR_ROTATION);\n> \tif (rotationControl != controls.end()) {\n> \t\tpropertyValue = rotationControl->second.def().get();\n> -\t} else {\n> -\t\tpropertyValue = 0;\n> -\t\tLOG(CameraSensor, Debug)\n> -\t\t\t<< \"Rotation property defaulted to 0 degrees\";\n> +\t\tproperties_.set(properties::Rotation, propertyValue);\n> \t}\n> -\tproperties_.set(properties::Rotation, propertyValue);\n> \n> \tproperties_.set(properties::PixelArraySize, pixelArraySize_);\n> \tproperties_.set(properties::PixelArrayActiveAreas, { activeAreaSize_ });","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 225D0C0F1A\n\tfor ;\n\tWed, 30 Dec 2020 20:15:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E28A8615B4;\n\tWed, 30 Dec 2020 21:15:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D9C660526\n\tfor ;\n\tWed, 30 Dec 2020 21:15:52 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D23E2A3;\n\tWed, 30 Dec 2020 21:15:51 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"D/D4Xwy8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1609359352;\n\tbh=+rkK0E90Fv5rZVwMcJSwJPEskjiGDOlamGDlqSpBlN0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=D/D4Xwy8A7tJNC4Gf/650S0vmA3n6DSe+O9iicVq6bKv8pVN/Uw7W01hkv5ROFpBB\n\tLK7GOeNxXCDkq8TjJV3Rv66F8vgNn37VwOhlxwlEFEdq+Hot/lcsclbE1tHJ5Txo7p\n\tfHQJ8BuG105gh9ed9p+Vf7Gt95QXTNrmxEtJuqPU=","Date":"Wed, 30 Dec 2020 22:15:40 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201230180120.78407-1-jacopo@jmondi.org>\n\t<20201230180120.78407-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201230180120.78407-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 5/6] libcamera: camera_sensor: Do\n\tnot default 'rotation'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]