[{"id":14417,"web_url":"https://patchwork.libcamera.org/comment/14417/","msgid":"","date":"2020-12-30T12:41:18","subject":"Re: [libcamera-devel] [PATCH v2 5/5] libcamera: ipu3: Register\n\tsensor controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Dec 28, 2020 at 05:56:00PM +0100, Jacopo Mondi wrote:\n> Register the sensor provided controls together with the pipeline\n> handler initialized controls.\n> \n> Reviewed-by: Paul Elder \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index f1151733d9fe..a745d163462d 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -777,7 +777,12 @@ int PipelineHandlerIPU3::registerCameras()\n> \t\tdata->properties_ = cio2->sensor()->properties();\n> \n> \t\t/* Initialze the camera controls. */\n> -\t\tdata->controlInfo_ = IPU3Controls;\n> +\t\tControlInfoMap::Map controlsMap;\n> +\t\tfor (const auto &it : IPU3Controls)\n> +\t\t\tcontrolsMap[it.first] = it.second;\n\nShould IPU3Controls be turned into a ControlInfoMap::Map, to be able to\nwrite\n\n\t\tControlInfoMap::Map controlsMap = IPU3Controls;\n\nand then extend it as done in the next few lines ?\n\n> +\t\tfor (const auto &it : cio2->sensor()->controls())\n> +\t\t\tcontrolsMap[it.first] = it.second;\n> +\t\tdata->controlInfo_ = std::move(controlsMap);\n\nThis I don't like at all, for reasons explained in the review of preview\npatches :-( We don't have to fix everything in one go, but I'd like to\nat least already make the creation of the public controls controlled by\nthe pipeline handler, explicitly.\n\n> \n> \t\t/**\n> \t\t * \\todo Dynamically assign ImgU and output devices to each","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7BEDCC0F1A\n\tfor ;\n\tWed, 30 Dec 2020 12:41:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE86C60526;\n\tWed, 30 Dec 2020 13:41:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7281060320\n\tfor ;\n\tWed, 30 Dec 2020 13:41:30 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D824F2A3;\n\tWed, 30 Dec 2020 13:41:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hGHr6PuQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1609332090;\n\tbh=coWNrX5z8HAqLkk7M1uTrPXu45s1VD51JfxhI/pDrTE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hGHr6PuQnelhw5/Dgmmw5lt4IovYA2aknPpnKeRzDyOKSDWiy+AkT9NqrVrMdUADb\n\tVkxwdwU8QD8AqNcM9NtUG4hes7B8QhERIggzedD+m13RDlLA/jk/kWIPyfS+uyPEPO\n\thh/53aZalw4BpYBPHgvD6HofaLbp6jFbtT6XUgOM=","Date":"Wed, 30 Dec 2020 14:41:18 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201228165600.53987-1-jacopo@jmondi.org>\n\t<20201228165600.53987-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201228165600.53987-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 5/5] libcamera: ipu3: Register\n\tsensor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]