[{"id":14384,"web_url":"https://patchwork.libcamera.org/comment/14384/","msgid":"<20201229041928.GD67590@pyrite.rasen.tech>","date":"2020-12-29T04:19:28","subject":"Re: [libcamera-devel] [PATCH v3 4/4] android: camera_device: Align\n\tstyle of active area size","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Dec 28, 2020 at 05:52:03PM +0100, Jacopo Mondi wrote:\n> Align the style of ANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE property\n> registration with the one of the other sensor related properties.\n\ns/one/ones/\n\n> \n> Cosmetic change only, no functional changes intended.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/android/camera_device.cpp | 11 +++++------\n> 1 file changed, 5 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 9ad417ee6c3a..b48c7b7c9d2b 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -883,26 +883,25 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_PHYSICAL_SIZE,\n> \t\t\t\t physicalSize.data(), physicalSize.size());\n> \n> +\tstd::vector activeAreaSize(4);\n> \tif (properties.contains(properties::PixelArrayActiveAreas)) {\n> \t\tconst Span &rects =\n> \t\t\tproperties.get(properties::PixelArrayActiveAreas);\n> -\t\tstd::vector data{\n> +\t\tactiveAreaSize = {\n> \t\t\tstatic_cast(rects[0].x),\n> \t\t\tstatic_cast(rects[0].y),\n> \t\t\tstatic_cast(rects[0].width),\n> \t\t\tstatic_cast(rects[0].height),\n> \t\t};\n> -\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n> -\t\t\t\t\t data.data(), data.size());\n> \t} else {\n> \t\t/*\n> \t\t * \\todo Drop the default once the ov5670 and ov13858 drivers\n> \t\t * are updated to report the pixel array size.\n> \t\t */\n> -\t\tint32_t data[] = { 0, 0, 2560, 1920 };\n> -\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n> -\t\t\t\t\t data, 4);\n> +\t\tactiveAreaSize = { 0, 0, 2560, 1920 };\n> \t}\n> +\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n> +\t\t\t\t activeAreaSize.data(), 4);\n> \n> \tint32_t sensitivityRange[] = {\n> \t\t32, 2400,\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0318C0F1A\n\tfor ;\n\tTue, 29 Dec 2020 04:19:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5DF6D615B2;\n\tTue, 29 Dec 2020 05:19:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6ACC06031A\n\tfor ;\n\tTue, 29 Dec 2020 05:19:36 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D006C98;\n\tTue, 29 Dec 2020 05:19:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wEqPCMSM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1609215576;\n\tbh=DVaHXRMRYr6/5ciIoFbvNqhoMSuCvf+RV2J1cMA6C68=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wEqPCMSMyN/NjcMuJa2kvGgQZabY7x86SbzapnDLDbOOiN8zSL/VPTmsw3bISQbpT\n\t4857exHy2rRPwpwX5UA559bcnVGupU65BMF0e4jWvrgR7HNHl3pkiN/QOOA8jl2XVq\n\t2OcUp9zJM6fIcwG2FYXAsvQxuIUrgjiQtmSKXmCY=","Date":"Tue, 29 Dec 2020 13:19:28 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20201229041928.GD67590@pyrite.rasen.tech>","References":"<20201228165203.53771-1-jacopo@jmondi.org>\n\t<20201228165203.53771-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201228165203.53771-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 4/4] android: camera_device: Align\n\tstyle of active area size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14401,"web_url":"https://patchwork.libcamera.org/comment/14401/","msgid":"","date":"2020-12-29T17:31:57","subject":"Re: [libcamera-devel] [PATCH v3 4/4] android: camera_device: Align\n\tstyle of active area size","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-12-28 17:52:03 +0100, Jacopo Mondi wrote:\n> Align the style of ANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE property\n> registration with the one of the other sensor related properties.\n> \n> Cosmetic change only, no functional changes intended.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 11 +++++------\n> 1 file changed, 5 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 9ad417ee6c3a..b48c7b7c9d2b 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -883,26 +883,25 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_PHYSICAL_SIZE,\n> \t\t\t\t physicalSize.data(), physicalSize.size());\n> \n> +\tstd::vector activeAreaSize(4);\n> \tif (properties.contains(properties::PixelArrayActiveAreas)) {\n> \t\tconst Span &rects =\n> \t\t\tproperties.get(properties::PixelArrayActiveAreas);\n> -\t\tstd::vector data{\n> +\t\tactiveAreaSize = {\n> \t\t\tstatic_cast(rects[0].x),\n> \t\t\tstatic_cast(rects[0].y),\n> \t\t\tstatic_cast(rects[0].width),\n> \t\t\tstatic_cast(rects[0].height),\n> \t\t};\n> -\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n> -\t\t\t\t\t data.data(), data.size());\n> \t} else {\n> \t\t/*\n> \t\t * \\todo Drop the default once the ov5670 and ov13858 drivers\n> \t\t * are updated to report the pixel array size.\n> \t\t */\n> -\t\tint32_t data[] = { 0, 0, 2560, 1920 };\n> -\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n> -\t\t\t\t\t data, 4);\n> +\t\tactiveAreaSize = { 0, 0, 2560, 1920 };\n> \t}\n> +\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n> +\t\t\t\t activeAreaSize.data(), 4);\n> \n> \tint32_t sensitivityRange[] = {\n> \t\t32, 2400,\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E7A8C0F1C\n\tfor ;\n\tTue, 29 Dec 2020 17:32:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3BD966031F;\n\tTue, 29 Dec 2020 18:32:01 +0100 (CET)","from mail-lf1-x132.google.com (mail-lf1-x132.google.com\n\t[IPv6:2a00:1450:4864:20::132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B1206031F\n\tfor ;\n\tTue, 29 Dec 2020 18:31:59 +0100 (CET)","by mail-lf1-x132.google.com with SMTP id m25so32288534lfc.11\n\tfor ;\n\tTue, 29 Dec 2020 09:31:59 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tx186sm5681444lff.76.2020.12.29.09.31.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 29 Dec 2020 09:31:58 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"Zpsq8eoY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=2AtzVAlsBWw4G4GJlwshL+XKNon7ZhwFZ/d3glErTec=;\n\tb=Zpsq8eoYjijo8vplxZFG5L5vNbr6Fc8K+FqWVrmDZWi3LT838tc0T/gALqvPplnLRm\n\tK2Qa4myAxuGteyFrVo0Bo3DJvXT5roPGX0GcjtVcSALzNKmvwsHHB2c3dKB+ik7R+6x+\n\t0qzhpLW81uvjx7tCvHqB3zbm5vlZICinGBn7EEfMJsy1cFs6/GzXYWrP45MU07SRdBFo\n\tWKmce3zrWZGYVYvYzcqARtYkrOvnuhIRHD4ZiSiCIYxlX87f/8hV4EG8uRsoZiDKhxkl\n\teIa4PS7dP3Q9ueaGmqVKuOrSn7gsFbnQD+L+6NkBNZMTudwOilWbs+AhIgsWhGkQ6gjd\n\tj6mg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=2AtzVAlsBWw4G4GJlwshL+XKNon7ZhwFZ/d3glErTec=;\n\tb=rkY/s9DujKJXt4vXdJu0SMeD0dimhHnTv1DAFeFPuh4DSTaeAxLGxxz85aIEtna2/k\n\tCrdKYtZwUsyG5JODQqGJufZzoGwljJ5klZmVhP5lSeZXp0DcSz5T5Osn5RPfcZnKj5RQ\n\tIdOs3KOEPZPcD4ypKwz6y8n6Fy4Rt6XtTa0ft21haFM2h4TBmEQlCDOtx+DGU6CVw4dM\n\tGBvMTQxIIdnaHsPptJHq2S2QXrfPttEtOzKxzZQgKHQuxqvw/pymatE5/4qQbkoMAzts\n\tKzYeka8Rifij/XslOs56+Of/Vx9HPTYcEHhzq329wW8CSgtSn2japqLNhgn6iuroISIQ\n\t/EWQ==","X-Gm-Message-State":"AOAM533Lw31i/XSwoEVrF1GUQnDmP352cqquOqLjTDOoZe/uwBZNYpCx\n\tRA8dp9Of8RtR2v6SjynVefga9A==","X-Google-Smtp-Source":"ABdhPJwBWXjfn0Dyu9fuy2/Z7p3tkEIeuDHf/rYGINa4KX/fUhroL2wd2D/aGz95RM6Z1k7sx2qpvA==","X-Received":"by 2002:a05:6512:52c:: with SMTP id\n\to12mr20656663lfc.559.1609263119028; \n\tTue, 29 Dec 2020 09:31:59 -0800 (PST)","Date":"Tue, 29 Dec 2020 18:31:57 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201228165203.53771-1-jacopo@jmondi.org>\n\t<20201228165203.53771-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201228165203.53771-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 4/4] android: camera_device: Align\n\tstyle of active area size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]