[{"id":14391,"web_url":"https://patchwork.libcamera.org/comment/14391/","msgid":"<20201229045516.GK67590@pyrite.rasen.tech>","date":"2020-12-29T04:55:16","subject":"Re: [libcamera-devel] [PATCH v2 5/5] android: camera_device:\n\tSimplify properties.get()","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Dec 28, 2020 at 05:40:03PM +0100, Jacopo Mondi wrote:\n> When accessing the value of a property by reading the properties\n> ControlList content with ControlList::get<>() it is not necessary to\n> specify the template type as it is already conveyed by the Control\n> instance provided as first argument.\n> \n> Reviewed-by: Niklas Söderlund \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/android/camera_device.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index bbf016c323a7..7678d4485ce9 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -853,7 +853,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t/* Sensor static metadata. */\n> \tif (properties.contains(properties::PixelArraySize)) {\n> \t\tconst Size &size =\n> -\t\t\tproperties.get(properties::PixelArraySize);\n> +\t\t\tproperties.get(properties::PixelArraySize);\n> \t\tstd::vector data{\n> \t\t\tstatic_cast(size.width),\n> \t\t\tstatic_cast(size.height),\n> @@ -872,7 +872,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \n> \tif (properties.contains(properties::PixelArrayActiveAreas)) {\n> \t\tconst Span &rects =\n> -\t\t\tproperties.get>(properties::PixelArrayActiveAreas);\n> +\t\t\tproperties.get(properties::PixelArrayActiveAreas);\n> \t\tstd::vector data{\n> \t\t\tstatic_cast(rects[0].x),\n> \t\t\tstatic_cast(rects[0].y),\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86D35C0F1C\n\tfor ;\n\tTue, 29 Dec 2020 04:55:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 59038619E2;\n\tTue, 29 Dec 2020 05:55:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 953456031A\n\tfor ;\n\tTue, 29 Dec 2020 05:55:23 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F2A7B98;\n\tTue, 29 Dec 2020 05:55:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"X7x7Huov\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1609217723;\n\tbh=mS+qwMwIz0ORq/bpaMzotFPhPAxSzE4Z3OPOJOoNQ0c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=X7x7HuovkloP1y454xAYMYRM89I5weLkpjwAeu9nTdF8Y+Yuf4uHlAg7fvjv3rgHA\n\tA9Vrb2/+LT4xiEk+8R25kvgrWBCumvOzte4S90on6m1ysn8SJ8EiDZv5Un+tOVF/nr\n\tz/806BqmTeoWDNxRKxuZgAOWen0yroEasw40BoKM=","Date":"Tue, 29 Dec 2020 13:55:16 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20201229045516.GK67590@pyrite.rasen.tech>","References":"<20201228164003.53051-1-jacopo@jmondi.org>\n\t<20201228164003.53051-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201228164003.53051-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 5/5] android: camera_device:\n\tSimplify properties.get()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]