[{"id":14390,"web_url":"https://patchwork.libcamera.org/comment/14390/","msgid":"<20201229045343.GJ67590@pyrite.rasen.tech>","date":"2020-12-29T04:53:43","subject":"Re: [libcamera-devel] [PATCH v2 4/5] android: camera_device: Report\n\tColorFilterArrangement","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Dec 28, 2020 at 05:40:02PM +0100, Jacopo Mondi wrote:\n> Conditionally report the ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT\n> property inspecting the draft property reported by the libcamera Camera.\n> \n> Reviewed-by: Niklas Söderlund \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/android/camera_device.cpp | 9 ++++++---\n> 1 file changed, 6 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index b4618a680f41..bbf016c323a7 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -897,9 +897,12 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_SENSITIVITY_RANGE,\n> \t\t\t\t &sensitivityRange, 2);\n> \n> -\tuint16_t filterArr = ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT_GRBG;\n> -\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT,\n> -\t\t\t\t &filterArr, 1);\n> +\t/* Report the color filter arrangement if the camera reports it. */\n> +\tif (properties.contains(properties::draft::ColorFilterArrangement)) {\n> +\t\tuint8_t filterArr = properties.get(properties::draft::ColorFilterArrangement);\n> +\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT,\n> +\t\t\t\t\t &filterArr, 1);\n> +\t}\n> \n> \tint64_t exposureTimeRange[] = {\n> \t\t100000, 200000000,\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5977EC0F1A\n\tfor ;\n\tTue, 29 Dec 2020 04:53:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D7A52615D5;\n\tTue, 29 Dec 2020 05:53:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5091A615B2\n\tfor ;\n\tTue, 29 Dec 2020 05:53:51 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E559598;\n\tTue, 29 Dec 2020 05:53:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sklmjiUP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1609217630;\n\tbh=tcj7/NNNX1g844HwzHG7i4xEljgUCmcoVgDaR+ANNOs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sklmjiUPvG6/9rfqNq935HvSdBuMsGLt2kL5d0pIo/LZwx6sdy/mXdOam4SsD0GXX\n\tjm2AfKysAIYtVC7KNRqQUTvTlphvV8KsUErzMPMUEk9e0ySRv4Cg81Tsn/j6C8+ROU\n\ttV+0ZBvI9KdAhdhjNQteo1bQsML9MZL1PuTCy8/w=","Date":"Tue, 29 Dec 2020 13:53:43 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20201229045343.GJ67590@pyrite.rasen.tech>","References":"<20201228164003.53051-1-jacopo@jmondi.org>\n\t<20201228164003.53051-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201228164003.53051-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 4/5] android: camera_device: Report\n\tColorFilterArrangement","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]