[{"id":14389,"web_url":"https://patchwork.libcamera.org/comment/14389/","msgid":"<20201229045002.GI67590@pyrite.rasen.tech>","date":"2020-12-29T04:50:02","subject":"Re: [libcamera-devel] [PATCH v2 3/5] libcamera: camera_sensor:\n\tRegister ColorFilterArrangement","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Dec 28, 2020 at 05:40:01PM +0100, Jacopo Mondi wrote:\n> Inspect the list of media bus codes supported by the camera sensor\n> in order to deduce the color filter arrangement and register the\n> ColorFilterArrangement draft property.\n> \n> Reviewed-by: Niklas Söderlund \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/camera_sensor.cpp | 36 +++++++++++++++++++++++++++++----\n> 1 file changed, 32 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 1628ba9c892b..e786821d4ba2 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -17,6 +17,7 @@\n> \n> #include \n> \n> +#include \"libcamera/internal/bayer_format.h\"\n> #include \"libcamera/internal/formats.h\"\n> #include \"libcamera/internal/sysfs.h\"\n> #include \"libcamera/internal/utils.h\"\n> @@ -178,10 +179,6 @@ int CameraSensor::init()\n> \tif (ret < 0)\n> \t\treturn ret;\n> \n> -\tret = initProperties();\n> -\tif (ret)\n> -\t\treturn ret;\n> -\n> \t/* Enumerate, sort and cache media bus codes and sizes. */\n> \tformats_ = subdev_->formats(pad_);\n> \tif (formats_.empty()) {\n> @@ -210,6 +207,10 @@ int CameraSensor::init()\n> \t */\n> \tresolution_ = sizes_.back();\n> \n> +\tret = initProperties();\n> +\tif (ret)\n> +\t\treturn ret;\n> +\n> \treturn 0;\n> }\n> \n> @@ -307,6 +308,33 @@ int CameraSensor::initProperties()\n> \t\tproperties_.set(properties::PixelArrayActiveAreas, { crop });\n> \t}\n> \n> +\t/* Color filter array pattern, register only for RAW sensors. */\n> +\tfor (const auto &format : formats_) {\n> +\t\tunsigned int mbusCode = format.first;\n> +\t\tBayerFormat bayerFormat = BayerFormat::fromMbusCode(mbusCode);\n> +\t\tif (!bayerFormat.isValid())\n> +\t\t\tcontinue;\n> +\n> +\t\tint32_t cfa;\n> +\t\tswitch (bayerFormat.order) {\n> +\t\tcase BayerFormat::BGGR:\n> +\t\t\tcfa = properties::draft::BGGR;\n> +\t\t\tbreak;\n> +\t\tcase BayerFormat::GBRG:\n> +\t\t\tcfa = properties::draft::GBRG;\n> +\t\t\tbreak;\n> +\t\tcase BayerFormat::GRBG:\n> +\t\t\tcfa = properties::draft::GRBG;\n> +\t\t\tbreak;\n> +\t\tcase BayerFormat::RGGB:\n> +\t\t\tcfa = properties::draft::RGGB;\n> +\t\t\tbreak;\n> +\t\t}\n> +\n> +\t\tproperties_.set(properties::draft::ColorFilterArrangement, cfa);\n> +\t\tbreak;\n> +\t}\n> +\n> \treturn 0;\n> }\n> \n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67FD8C0F1A\n\tfor ;\n\tTue, 29 Dec 2020 04:50:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C804615D2;\n\tTue, 29 Dec 2020 05:50:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41F2B6159A\n\tfor ;\n\tTue, 29 Dec 2020 05:50:09 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DBCC698;\n\tTue, 29 Dec 2020 05:50:07 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EcWQXdMv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1609217408;\n\tbh=Txi8FTbw/qjpC0NS6O4iur/gf2nRhGtagzPLz+II2rQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EcWQXdMviVtMBusc2v5skmen7w/83jxYagyZ/7YEQlovAb75tIa1moVZamjksC6dV\n\teKm53AptT0PIOZnlDdTNPT0tCIa52Rj8IzgwZ3PoPAZzeGXYiNZ5jvZfc2TD54bVcT\n\t80ETsT4lqnAem60kU3Vx8SOKcrB5dRpaN3V/4egs=","Date":"Tue, 29 Dec 2020 13:50:02 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20201229045002.GI67590@pyrite.rasen.tech>","References":"<20201228164003.53051-1-jacopo@jmondi.org>\n\t<20201228164003.53051-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201228164003.53051-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 3/5] libcamera: camera_sensor:\n\tRegister ColorFilterArrangement","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]