[{"id":14392,"web_url":"https://patchwork.libcamera.org/comment/14392/","msgid":"<20201229045603.GL67590@pyrite.rasen.tech>","date":"2020-12-29T04:56:03","subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: properties:\n\tColorFilterArrangement draft property","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Dec 28, 2020 at 05:39:59PM +0100, Jacopo Mondi wrote:\n> Define the 'ColorFilterArrangement' draft property. The property is\n> currently identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/property_ids.yaml | 29 +++++++++++++++++++++++++++++\n> 1 file changed, 29 insertions(+)\n> \n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index 64e88f0361d6..104e9aaf4fa3 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -678,4 +678,33 @@ controls:\n> \\todo Turn this property into a \"maximum control value\" for the\n> ScalerCrop control once \"dynamic\" controls have been implemented.\n> \n> + # ----------------------------------------------------------------------------\n> + # Draft properties section\n> +\n> + - ColorFilterArrangement:\n> + type: int32_t\n> + draft: true\n> + description: |\n> + The arrangement of color filters on sensor; represents the colors in the\n> + top-left 2x2 section of the sensor, in reading order. Currently\n> + identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> + enum:\n> + - name: RGGB\n> + value: 0\n> + description: RGGB Bayer pattern\n> + - name: GRBG\n> + value: 1\n> + description: GRBG Bayer pattern\n> + - name: GBRG\n> + value: 2\n> + description: GBRG Bayer pattern\n> + - name: BGGR\n> + value: 3\n> + description: BGGR Bayer pattern\n> + - name: RGB\n> + value: 4\n> + description: |\n> + Sensor is not Bayer; output has 3 16-bit values for each pixel,\n> + instead of just 1 16-bit value per pixel.\n> +\n> ...\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 232B4C0F1C\n\tfor ;\n\tTue, 29 Dec 2020 04:56:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4F59619AF;\n\tTue, 29 Dec 2020 05:56:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B54516031A\n\tfor ;\n\tTue, 29 Dec 2020 05:56:10 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5DA0198;\n\tTue, 29 Dec 2020 05:56:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EySbFuBo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1609217770;\n\tbh=WU/FzsYts66Cg/asbhQ8uZHUQNMliu44umqmLZ1Ylck=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EySbFuBobhnBmHpqTOo7PFzKLAj77/CTYMd3J3nBynrcuyTgCMWdeuKIaOZUXFj+X\n\tn7feUvLI+vLv/Cm+a7xqa69Qb0CxF6nEq4v7/lJLN9FQkoWgBvX51Z+afYDE8Eye7J\n\tg3yEdLT/XuoVQlUq790V1GZdgXPfD2qC8qgw433c=","Date":"Tue, 29 Dec 2020 13:56:03 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20201229045603.GL67590@pyrite.rasen.tech>","References":"<20201228164003.53051-1-jacopo@jmondi.org>\n\t<20201228164003.53051-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201228164003.53051-2-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: properties:\n\tColorFilterArrangement draft property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14393,"web_url":"https://patchwork.libcamera.org/comment/14393/","msgid":"","date":"2020-12-29T09:25:14","subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: properties:\n\tColorFilterArrangement draft property","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Jacopo\n\nThanks for this patch! Just one little question - I suppose Android\n(and libcamera) have some other way of signalling a monochrome\nsensor... I think I might have expected to find a\n\"monochrome/non-Bayer\" option in the list?\n\nBest regards\nDavid\n\nOn Tue, 29 Dec 2020 at 04:56, wrote:\n>\n> Hi Jacopo,\n>\n> On Mon, Dec 28, 2020 at 05:39:59PM +0100, Jacopo Mondi wrote:\n> > Define the 'ColorFilterArrangement' draft property. The property is\n> > currently identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> >\n> > Reviewed-by: Laurent Pinchart \n> > Signed-off-by: Jacopo Mondi \n>\n> Reviewed-by: Paul Elder \n>\n> > ---\n> > src/libcamera/property_ids.yaml | 29 +++++++++++++++++++++++++++++\n> > 1 file changed, 29 insertions(+)\n> >\n> > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > index 64e88f0361d6..104e9aaf4fa3 100644\n> > --- a/src/libcamera/property_ids.yaml\n> > +++ b/src/libcamera/property_ids.yaml\n> > @@ -678,4 +678,33 @@ controls:\n> > \\todo Turn this property into a \"maximum control value\" for the\n> > ScalerCrop control once \"dynamic\" controls have been implemented.\n> >\n> > + # ----------------------------------------------------------------------------\n> > + # Draft properties section\n> > +\n> > + - ColorFilterArrangement:\n> > + type: int32_t\n> > + draft: true\n> > + description: |\n> > + The arrangement of color filters on sensor; represents the colors in the\n> > + top-left 2x2 section of the sensor, in reading order. Currently\n> > + identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> > + enum:\n> > + - name: RGGB\n> > + value: 0\n> > + description: RGGB Bayer pattern\n> > + - name: GRBG\n> > + value: 1\n> > + description: GRBG Bayer pattern\n> > + - name: GBRG\n> > + value: 2\n> > + description: GBRG Bayer pattern\n> > + - name: BGGR\n> > + value: 3\n> > + description: BGGR Bayer pattern\n> > + - name: RGB\n> > + value: 4\n> > + description: |\n> > + Sensor is not Bayer; output has 3 16-bit values for each pixel,\n> > + instead of just 1 16-bit value per pixel.\n> > +\n> > ...\n> > --\n> > 2.29.2\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89F7CC0F1C\n\tfor ;\n\tTue, 29 Dec 2020 09:25:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 08AE26031F;\n\tTue, 29 Dec 2020 10:25:28 +0100 (CET)","from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com\n\t[IPv6:2607:f8b0:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 240436031D\n\tfor ;\n\tTue, 29 Dec 2020 10:25:26 +0100 (CET)","by mail-ot1-x32e.google.com with SMTP id o11so11389354ote.4\n\tfor ;\n\tTue, 29 Dec 2020 01:25:26 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"rxwAfxq3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=QWud7NXo0QM3fPbPA6/oboK48/2XgZS2tIW/fASr1DE=;\n\tb=rxwAfxq3L+XGBbSUvwxptFrYb1XrnC+DsZYmDZL1cCg5CeJqo92tk4Ki9OvtcOUx8D\n\tQfydKJKSgIdhgadROHZBT/45u761XwnccAth86biyahYdvjgnhYn922zexd+XG1s/FUG\n\t2Sa4uu4IvALMxQ9FTY6N6j5rgZXwOqVrTQaIxCAI1YulFkhuu4Qf6uGEss0AS0uoXrdj\n\tM4FkxfaPOf4csuLeXrFClJD58FBS8CRllkA1jfRFd170/UmM4KfJVKh6JcOjGBQoXSao\n\twk+9UzcsFBrUAKI4tokWsW/9t5lhaGQS6tn42hpXzMJ1BYV5yo9ytJaj7ZZ+iR9/x2Np\n\tM9eA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=QWud7NXo0QM3fPbPA6/oboK48/2XgZS2tIW/fASr1DE=;\n\tb=QEO+JevMAVF/dz9KYgRav6CYv6xm9pi2kQC8n+txZUrtAog3qo+qxSqsdtrGXAW41e\n\tDWPRoiQCLxVowC61WftdrufqZYqqd6P0o7uLZpy3/QaZ3nCVeq/ZhaofPXmjngDA9Ax9\n\tLkFN7yK3O5nkeoAiwOxGo/5mcy7xByzn3WGe+i+rMkkhFGCCG1LbQMJnrLxr3rYH+Mc/\n\tj4hKpE+CI7N43ktXlYv7cJMccEUFhtt/f8m8cegt6/pfSHtHxhDOKr1OCIitg+QLTXys\n\t/LOAPg3c1FetraDJf4pVRrD6FBTYBwLMkWRdsiecQbzZVCMXfjjxmAaXDmRaAhNd/8JB\n\tXmmQ==","X-Gm-Message-State":"AOAM531FE4GBe03OlKO/g5hXcCjgpdzOj87h895Cqnm3YnxVTQS9yHdt\n\t1gmb06PhYAe2psC4pP/uQ2hw6+fmTr2a/iYA23Cjrg==","X-Google-Smtp-Source":"ABdhPJxy20DR/kkpNELbvynzghRqG5H5DJHlXRNy32uRMaO4rLfsp2twiG0M3ibBIcQhtBnF3ir3RgcV5e0dbv9MsLA=","X-Received":"by 2002:a9d:7f81:: with SMTP id\n\tt1mr36170467otp.166.1609233924708; \n\tTue, 29 Dec 2020 01:25:24 -0800 (PST)","MIME-Version":"1.0","References":"<20201228164003.53051-1-jacopo@jmondi.org>\n\t<20201228164003.53051-2-jacopo@jmondi.org>\n\t<20201229045603.GL67590@pyrite.rasen.tech>","In-Reply-To":"<20201229045603.GL67590@pyrite.rasen.tech>","From":"David Plowman ","Date":"Tue, 29 Dec 2020 09:25:14 +0000","Message-ID":"","To":"paul.elder@ideasonboard.com","Subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: properties:\n\tColorFilterArrangement draft property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14394,"web_url":"https://patchwork.libcamera.org/comment/14394/","msgid":"<20201229102652.sw7jafpc5dqdd5qz@uno.localdomain>","date":"2020-12-29T10:26:52","subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: properties:\n\tColorFilterArrangement draft property","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi David,\n\nOn Tue, Dec 29, 2020 at 09:25:14AM +0000, David Plowman wrote:\n> Hi Jacopo\n>\n> Thanks for this patch! Just one little question - I suppose Android\n> (and libcamera) have some other way of signalling a monochrome\n> sensor... I think I might have expected to find a\n> \"monochrome/non-Bayer\" option in the list?\n\nPlease bare in mind this is a draft property, whose main purpose is\nto temporary close the gap with Android and its definition come\nstraight from there.\n\nThis property only makes sensor for RAW sensors, although there's a\nmore generic 'RGB' value that sounds like a catch-all for non-Bayer\nsensors.\n\nSimply put: non-RAW sensor won't register this property at all.\nWhen we'll un-draft the property we can discuss if that makes sense\nat all as a choice, or we might want to have a more generic\ndefinition.\n\nDo you perhaps have any usage for such a more generic property in mind ?\n\n>\n> Best regards\n> David\n>\n> On Tue, 29 Dec 2020 at 04:56, wrote:\n> >\n> > Hi Jacopo,\n> >\n> > On Mon, Dec 28, 2020 at 05:39:59PM +0100, Jacopo Mondi wrote:\n> > > Define the 'ColorFilterArrangement' draft property. The property is\n> > > currently identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> > >\n> > > Reviewed-by: Laurent Pinchart \n> > > Signed-off-by: Jacopo Mondi \n> >\n> > Reviewed-by: Paul Elder \n> >\n> > > ---\n> > > src/libcamera/property_ids.yaml | 29 +++++++++++++++++++++++++++++\n> > > 1 file changed, 29 insertions(+)\n> > >\n> > > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > > index 64e88f0361d6..104e9aaf4fa3 100644\n> > > --- a/src/libcamera/property_ids.yaml\n> > > +++ b/src/libcamera/property_ids.yaml\n> > > @@ -678,4 +678,33 @@ controls:\n> > > \\todo Turn this property into a \"maximum control value\" for the\n> > > ScalerCrop control once \"dynamic\" controls have been implemented.\n> > >\n> > > + # ----------------------------------------------------------------------------\n> > > + # Draft properties section\n> > > +\n> > > + - ColorFilterArrangement:\n> > > + type: int32_t\n> > > + draft: true\n> > > + description: |\n> > > + The arrangement of color filters on sensor; represents the colors in the\n> > > + top-left 2x2 section of the sensor, in reading order. Currently\n> > > + identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> > > + enum:\n> > > + - name: RGGB\n> > > + value: 0\n> > > + description: RGGB Bayer pattern\n> > > + - name: GRBG\n> > > + value: 1\n> > > + description: GRBG Bayer pattern\n> > > + - name: GBRG\n> > > + value: 2\n> > > + description: GBRG Bayer pattern\n> > > + - name: BGGR\n> > > + value: 3\n> > > + description: BGGR Bayer pattern\n> > > + - name: RGB\n> > > + value: 4\n> > > + description: |\n> > > + Sensor is not Bayer; output has 3 16-bit values for each pixel,\n> > > + instead of just 1 16-bit value per pixel.\n> > > +\n> > > ...\n> > > --\n> > > 2.29.2\n> > >\n> > > _______________________________________________\n> > > libcamera-devel mailing list\n> > > libcamera-devel@lists.libcamera.org\n> > > https://lists.libcamera.org/listinfo/libcamera-devel\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20EA0C0F1A\n\tfor ;\n\tTue, 29 Dec 2020 10:26:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A6A5A615B2;\n\tTue, 29 Dec 2020 11:26:40 +0100 (CET)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 641316031D\n\tfor ;\n\tTue, 29 Dec 2020 11:26:39 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 977BBFF802;\n\tTue, 29 Dec 2020 10:26:38 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Tue, 29 Dec 2020 11:26:52 +0100","From":"Jacopo Mondi ","To":"David Plowman ","Message-ID":"<20201229102652.sw7jafpc5dqdd5qz@uno.localdomain>","References":"<20201228164003.53051-1-jacopo@jmondi.org>\n\t<20201228164003.53051-2-jacopo@jmondi.org>\n\t<20201229045603.GL67590@pyrite.rasen.tech>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: properties:\n\tColorFilterArrangement draft property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14404,"web_url":"https://patchwork.libcamera.org/comment/14404/","msgid":"","date":"2020-12-29T22:32:21","subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: properties:\n\tColorFilterArrangement draft property","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Jacopo\n\nThanks for the reply!\n\nOn Tue, 29 Dec 2020 at 10:26, Jacopo Mondi wrote:\n>\n> Hi David,\n>\n> On Tue, Dec 29, 2020 at 09:25:14AM +0000, David Plowman wrote:\n> > Hi Jacopo\n> >\n> > Thanks for this patch! Just one little question - I suppose Android\n> > (and libcamera) have some other way of signalling a monochrome\n> > sensor... I think I might have expected to find a\n> > \"monochrome/non-Bayer\" option in the list?\n>\n> Please bare in mind this is a draft property, whose main purpose is\n> to temporary close the gap with Android and its definition come\n> straight from there.\n>\n> This property only makes sensor for RAW sensors, although there's a\n> more generic 'RGB' value that sounds like a catch-all for non-Bayer\n> sensors.\n>\n> Simply put: non-RAW sensor won't register this property at all.\n> When we'll un-draft the property we can discuss if that makes sense\n> at all as a choice, or we might want to have a more generic\n> definition.\n>\n> Do you perhaps have any usage for such a more generic property in mind ?\n\nNot especially, my thoughts on the subject are only \"draft\" too! :)\n\nI guess my only observations are that a monochrome (\"no CFA at all\")\nformat would probably be useful (it's still a RAW format, though not a\nBayer one). Also, that single non-RAW format (3x16-bit RGB) seems a\nbit lonely, for example YUV422 interleaved is probably more common,\nbut I doubt we want to list all the possible pixel formats all over\nagain, we have enough of that already!\n\nThanks!\nDavid\n\n>\n> >\n> > Best regards\n> > David\n> >\n> > On Tue, 29 Dec 2020 at 04:56, wrote:\n> > >\n> > > Hi Jacopo,\n> > >\n> > > On Mon, Dec 28, 2020 at 05:39:59PM +0100, Jacopo Mondi wrote:\n> > > > Define the 'ColorFilterArrangement' draft property. The property is\n> > > > currently identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> > > >\n> > > > Reviewed-by: Laurent Pinchart \n> > > > Signed-off-by: Jacopo Mondi \n> > >\n> > > Reviewed-by: Paul Elder \n> > >\n> > > > ---\n> > > > src/libcamera/property_ids.yaml | 29 +++++++++++++++++++++++++++++\n> > > > 1 file changed, 29 insertions(+)\n> > > >\n> > > > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > > > index 64e88f0361d6..104e9aaf4fa3 100644\n> > > > --- a/src/libcamera/property_ids.yaml\n> > > > +++ b/src/libcamera/property_ids.yaml\n> > > > @@ -678,4 +678,33 @@ controls:\n> > > > \\todo Turn this property into a \"maximum control value\" for the\n> > > > ScalerCrop control once \"dynamic\" controls have been implemented.\n> > > >\n> > > > + # ----------------------------------------------------------------------------\n> > > > + # Draft properties section\n> > > > +\n> > > > + - ColorFilterArrangement:\n> > > > + type: int32_t\n> > > > + draft: true\n> > > > + description: |\n> > > > + The arrangement of color filters on sensor; represents the colors in the\n> > > > + top-left 2x2 section of the sensor, in reading order. Currently\n> > > > + identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> > > > + enum:\n> > > > + - name: RGGB\n> > > > + value: 0\n> > > > + description: RGGB Bayer pattern\n> > > > + - name: GRBG\n> > > > + value: 1\n> > > > + description: GRBG Bayer pattern\n> > > > + - name: GBRG\n> > > > + value: 2\n> > > > + description: GBRG Bayer pattern\n> > > > + - name: BGGR\n> > > > + value: 3\n> > > > + description: BGGR Bayer pattern\n> > > > + - name: RGB\n> > > > + value: 4\n> > > > + description: |\n> > > > + Sensor is not Bayer; output has 3 16-bit values for each pixel,\n> > > > + instead of just 1 16-bit value per pixel.\n> > > > +\n> > > > ...\n> > > > --\n> > > > 2.29.2\n> > > >\n> > > > _______________________________________________\n> > > > libcamera-devel mailing list\n> > > > libcamera-devel@lists.libcamera.org\n> > > > https://lists.libcamera.org/listinfo/libcamera-devel\n> > > _______________________________________________\n> > > libcamera-devel mailing list\n> > > libcamera-devel@lists.libcamera.org\n> > > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7CFD4C0F1A\n\tfor ;\n\tTue, 29 Dec 2020 22:32:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4B3C615B2;\n\tTue, 29 Dec 2020 23:32:33 +0100 (CET)","from mail-oi1-x231.google.com (mail-oi1-x231.google.com\n\t[IPv6:2607:f8b0:4864:20::231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5611C6031F\n\tfor ;\n\tTue, 29 Dec 2020 23:32:32 +0100 (CET)","by mail-oi1-x231.google.com with SMTP id f132so16463361oib.12\n\tfor ;\n\tTue, 29 Dec 2020 14:32:32 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"SKQSpKE6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=t+ZOYExRig8t9+Eave+ugVDmPHDjmC2+Zmk/uRs6g8c=;\n\tb=SKQSpKE6oiyOLK79thXMjgaIN2HOuJbRlrunLr7noozOvLDTu3ujmf65G+RmSwLgqi\n\ty4MEIHAF5GLAqBl9aUILAjwqOO2XFhpj526c4r32ehmj8mZdj5zasP445ESrd8wUeLjI\n\tbUHKxhqG3YMxotYvaYLuV1siyoD60Ic3mHCCGfFhTw08LKIaGZYmkB8o3WXFls6Ut0LR\n\tVgDe6MhaGXT6ji4qHi0huk86JCj7lO6eVRswjEIt0Br5dcJIHmvYqhhbTa3s2LK1wCJh\n\tqksEOnKgi7SNXF7muTlyAW+n2pXiEHRbl60JvyxNQqQvg/DVc9ec20L/fQ79RLxzmjru\n\tCPDg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=t+ZOYExRig8t9+Eave+ugVDmPHDjmC2+Zmk/uRs6g8c=;\n\tb=pFdNP12nF6bKd4Sh4t6L/BYqYbHC3C2o7BNIrzlTwFL/3YCx5NFfTVBnQGBQ6bMVFT\n\tc09jJ8SZn9BfU2q4lYzhN9B8BD2URihqptXPQu3TvKd6vgU/1wmmgcNdG8NXNtWL4Dqq\n\tCwpBE8OnPN0QKSbX03JrYuOqe/B37yVgLdH1Oqv18nwmM3zbpoGbCKjlalA+zrtOdAXQ\n\tXAxLsbpQO94fG1j33zszC7qq5N8ul7UNQbrxGi2RaVqihNvC8cdVt6akW54GkIUjcH6w\n\thEg4eA189MgjUxPc95V0ok1w1z4qAgPB4fojECwr2jlKZdQZFE1erTz3ntdDR9tA0LyK\n\t/1GQ==","X-Gm-Message-State":"AOAM532P2GiSlyehuSumKDeeqvs/Be0G86ocmy0Q1XsqfyWETuumB51G\n\tbCRwr1yVc3eHepyuFFIyqoStA45MpNEcR4vAOF7iFMfXzjU=","X-Google-Smtp-Source":"ABdhPJxHpEqmulAYMi6OJYsWIsmS4rXYS3fYdkBx/KXMvJuVz5pSONIBo1dFJy0/MJbUloJVzIIAzEEinuRhcj3/wO8=","X-Received":"by 2002:aca:f10b:: with SMTP id p11mr3649687oih.55.1609281151024;\n\tTue, 29 Dec 2020 14:32:31 -0800 (PST)","MIME-Version":"1.0","References":"<20201228164003.53051-1-jacopo@jmondi.org>\n\t<20201228164003.53051-2-jacopo@jmondi.org>\n\t<20201229045603.GL67590@pyrite.rasen.tech>\n\t\n\t<20201229102652.sw7jafpc5dqdd5qz@uno.localdomain>","In-Reply-To":"<20201229102652.sw7jafpc5dqdd5qz@uno.localdomain>","From":"David Plowman ","Date":"Tue, 29 Dec 2020 22:32:21 +0000","Message-ID":"","To":"Jacopo Mondi ","Subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: properties:\n\tColorFilterArrangement draft property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14405,"web_url":"https://patchwork.libcamera.org/comment/14405/","msgid":"<20201230075931.bhxbygjjvtm6zs3a@uno.localdomain>","date":"2020-12-30T07:59:31","subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: properties:\n\tColorFilterArrangement draft property","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi David,\n\nOn Tue, Dec 29, 2020 at 10:32:21PM +0000, David Plowman wrote:\n> Hi Jacopo\n>\n> Thanks for the reply!\n>\n> On Tue, 29 Dec 2020 at 10:26, Jacopo Mondi wrote:\n> >\n> > Hi David,\n> >\n> > On Tue, Dec 29, 2020 at 09:25:14AM +0000, David Plowman wrote:\n> > > Hi Jacopo\n> > >\n> > > Thanks for this patch! Just one little question - I suppose Android\n> > > (and libcamera) have some other way of signalling a monochrome\n> > > sensor... I think I might have expected to find a\n> > > \"monochrome/non-Bayer\" option in the list?\n> >\n> > Please bare in mind this is a draft property, whose main purpose is\n> > to temporary close the gap with Android and its definition come\n> > straight from there.\n> >\n> > This property only makes sensor for RAW sensors, although there's a\n> > more generic 'RGB' value that sounds like a catch-all for non-Bayer\n> > sensors.\n> >\n> > Simply put: non-RAW sensor won't register this property at all.\n> > When we'll un-draft the property we can discuss if that makes sense\n> > at all as a choice, or we might want to have a more generic\n> > definition.\n> >\n> > Do you perhaps have any usage for such a more generic property in mind ?\n>\n> Not especially, my thoughts on the subject are only \"draft\" too! :)\n>\n> I guess my only observations are that a monochrome (\"no CFA at all\")\n> format would probably be useful (it's still a RAW format, though not a\n\nMy bad, I always thought 'mono-chrome' as a YUV sensor with only the Y\nchannel being sent out.\n\n> Bayer one). Also, that single non-RAW format (3x16-bit RGB) seems a\n> bit lonely, for example YUV422 interleaved is probably more common,\n> but I doubt we want to list all the possible pixel formats all over\n> again, we have enough of that already!\n\nI'm not sure I follow. How does a processed format like YUV422 relates\nto the sensor's color filters arrangements ?\n\nThanks\n j\n\n>\n> Thanks!\n> David\n>\n> >\n> > >\n> > > Best regards\n> > > David\n> > >\n> > > On Tue, 29 Dec 2020 at 04:56, wrote:\n> > > >\n> > > > Hi Jacopo,\n> > > >\n> > > > On Mon, Dec 28, 2020 at 05:39:59PM +0100, Jacopo Mondi wrote:\n> > > > > Define the 'ColorFilterArrangement' draft property. The property is\n> > > > > currently identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> > > > >\n> > > > > Reviewed-by: Laurent Pinchart \n> > > > > Signed-off-by: Jacopo Mondi \n> > > >\n> > > > Reviewed-by: Paul Elder \n> > > >\n> > > > > ---\n> > > > > src/libcamera/property_ids.yaml | 29 +++++++++++++++++++++++++++++\n> > > > > 1 file changed, 29 insertions(+)\n> > > > >\n> > > > > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > > > > index 64e88f0361d6..104e9aaf4fa3 100644\n> > > > > --- a/src/libcamera/property_ids.yaml\n> > > > > +++ b/src/libcamera/property_ids.yaml\n> > > > > @@ -678,4 +678,33 @@ controls:\n> > > > > \\todo Turn this property into a \"maximum control value\" for the\n> > > > > ScalerCrop control once \"dynamic\" controls have been implemented.\n> > > > >\n> > > > > + # ----------------------------------------------------------------------------\n> > > > > + # Draft properties section\n> > > > > +\n> > > > > + - ColorFilterArrangement:\n> > > > > + type: int32_t\n> > > > > + draft: true\n> > > > > + description: |\n> > > > > + The arrangement of color filters on sensor; represents the colors in the\n> > > > > + top-left 2x2 section of the sensor, in reading order. Currently\n> > > > > + identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> > > > > + enum:\n> > > > > + - name: RGGB\n> > > > > + value: 0\n> > > > > + description: RGGB Bayer pattern\n> > > > > + - name: GRBG\n> > > > > + value: 1\n> > > > > + description: GRBG Bayer pattern\n> > > > > + - name: GBRG\n> > > > > + value: 2\n> > > > > + description: GBRG Bayer pattern\n> > > > > + - name: BGGR\n> > > > > + value: 3\n> > > > > + description: BGGR Bayer pattern\n> > > > > + - name: RGB\n> > > > > + value: 4\n> > > > > + description: |\n> > > > > + Sensor is not Bayer; output has 3 16-bit values for each pixel,\n> > > > > + instead of just 1 16-bit value per pixel.\n> > > > > +\n> > > > > ...\n> > > > > --\n> > > > > 2.29.2\n> > > > >\n> > > > > _______________________________________________\n> > > > > libcamera-devel mailing list\n> > > > > libcamera-devel@lists.libcamera.org\n> > > > > https://lists.libcamera.org/listinfo/libcamera-devel\n> > > > _______________________________________________\n> > > > libcamera-devel mailing list\n> > > > libcamera-devel@lists.libcamera.org\n> > > > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0CD89C0F1C\n\tfor ;\n\tWed, 30 Dec 2020 07:59:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8055B615B2;\n\tWed, 30 Dec 2020 08:59:20 +0100 (CET)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6981C60111\n\tfor ;\n\tWed, 30 Dec 2020 08:59:18 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 6983220003;\n\tWed, 30 Dec 2020 07:59:17 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 30 Dec 2020 08:59:31 +0100","From":"Jacopo Mondi ","To":"David Plowman ","Message-ID":"<20201230075931.bhxbygjjvtm6zs3a@uno.localdomain>","References":"<20201228164003.53051-1-jacopo@jmondi.org>\n\t<20201228164003.53051-2-jacopo@jmondi.org>\n\t<20201229045603.GL67590@pyrite.rasen.tech>\n\t\n\t<20201229102652.sw7jafpc5dqdd5qz@uno.localdomain>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: properties:\n\tColorFilterArrangement draft property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14409,"web_url":"https://patchwork.libcamera.org/comment/14409/","msgid":"<20201230093828.uftuuiqhnhrhbsph@uno.localdomain>","date":"2020-12-30T09:38:28","subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: properties:\n\tColorFilterArrangement draft property","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi David,\n\nOn Wed, Dec 30, 2020 at 08:59:31AM +0100, Jacopo Mondi wrote:\n> Hi David,\n>\n> On Tue, Dec 29, 2020 at 10:32:21PM +0000, David Plowman wrote:\n> > Hi Jacopo\n> >\n> > Thanks for the reply!\n> >\n> > On Tue, 29 Dec 2020 at 10:26, Jacopo Mondi wrote:\n> > >\n> > > Hi David,\n> > >\n> > > On Tue, Dec 29, 2020 at 09:25:14AM +0000, David Plowman wrote:\n> > > > Hi Jacopo\n> > > >\n> > > > Thanks for this patch! Just one little question - I suppose Android\n> > > > (and libcamera) have some other way of signalling a monochrome\n> > > > sensor... I think I might have expected to find a\n> > > > \"monochrome/non-Bayer\" option in the list?\n> > >\n> > > Please bare in mind this is a draft property, whose main purpose is\n> > > to temporary close the gap with Android and its definition come\n> > > straight from there.\n> > >\n> > > This property only makes sensor for RAW sensors, although there's a\n> > > more generic 'RGB' value that sounds like a catch-all for non-Bayer\n> > > sensors.\n> > >\n> > > Simply put: non-RAW sensor won't register this property at all.\n> > > When we'll un-draft the property we can discuss if that makes sense\n> > > at all as a choice, or we might want to have a more generic\n> > > definition.\n> > >\n> > > Do you perhaps have any usage for such a more generic property in mind ?\n> >\n> > Not especially, my thoughts on the subject are only \"draft\" too! :)\n> >\n> > I guess my only observations are that a monochrome (\"no CFA at all\")\n> > format would probably be useful (it's still a RAW format, though not a\n>\n> My bad, I always thought 'mono-chrome' as a YUV sensor with only the Y\n> channel being sent out.\n>\n> > Bayer one). Also, that single non-RAW format (3x16-bit RGB) seems a\n> > bit lonely, for example YUV422 interleaved is probably more common,\n> > but I doubt we want to list all the possible pixel formats all over\n> > again, we have enough of that already!\n>\n> I'm not sure I follow. How does a processed format like YUV422 relates\n> to the sensor's color filters arrangements ?\n\nLaurent helped clarify this to me, and yes, we probably need a\ndefinition for monochrome going forward. I would however keep the draft\nproperty version as close as possible to Android's definition and\nexpand it when un-drafting.\n\nThanks\n j","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8256AC0F1A\n\tfor ;\n\tWed, 30 Dec 2020 09:38:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E181C615D2;\n\tWed, 30 Dec 2020 10:38:18 +0100 (CET)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13F6E6031B\n\tfor ;\n\tWed, 30 Dec 2020 10:38:15 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 6D87D100006;\n\tWed, 30 Dec 2020 09:38:14 +0000 (UTC)"],"Date":"Wed, 30 Dec 2020 10:38:28 +0100","From":"Jacopo Mondi ","To":"David Plowman ","Message-ID":"<20201230093828.uftuuiqhnhrhbsph@uno.localdomain>","References":"<20201228164003.53051-1-jacopo@jmondi.org>\n\t<20201228164003.53051-2-jacopo@jmondi.org>\n\t<20201229045603.GL67590@pyrite.rasen.tech>\n\t\n\t<20201229102652.sw7jafpc5dqdd5qz@uno.localdomain>\n\t\n\t<20201230075931.bhxbygjjvtm6zs3a@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201230075931.bhxbygjjvtm6zs3a@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: properties:\n\tColorFilterArrangement draft property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14412,"web_url":"https://patchwork.libcamera.org/comment/14412/","msgid":"","date":"2020-12-30T10:00:07","subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: properties:\n\tColorFilterArrangement draft property","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Jacopo\n\nThanks for that. Actually I think I was a bit confused too. I was\nthinking that the 3x16-bit was somehow supposed to include non-RAW\nsensors, but I guess it doesn't. Maybe Android invented it to account\nfor those Foveon sensors that we had a few years back, which did give\nyou R, G and B at each location, but were still RAW?\n\nBut anyway, I agree it will probably make sense to add a \"no CFA\"\noption for those monochrome RAW sensors at some point. In fact, I\nwonder if in future we may want to add that to our BayerFormat\nclass... at which point \"BayerFormat\" isn't necessarily the right name\nany more. Oh dear! Anyway, that's a question for another time...\n\nBest regards\nDavid\n\nOn Wed, 30 Dec 2020 at 09:38, Jacopo Mondi wrote:\n>\n> Hi David,\n>\n> On Wed, Dec 30, 2020 at 08:59:31AM +0100, Jacopo Mondi wrote:\n> > Hi David,\n> >\n> > On Tue, Dec 29, 2020 at 10:32:21PM +0000, David Plowman wrote:\n> > > Hi Jacopo\n> > >\n> > > Thanks for the reply!\n> > >\n> > > On Tue, 29 Dec 2020 at 10:26, Jacopo Mondi wrote:\n> > > >\n> > > > Hi David,\n> > > >\n> > > > On Tue, Dec 29, 2020 at 09:25:14AM +0000, David Plowman wrote:\n> > > > > Hi Jacopo\n> > > > >\n> > > > > Thanks for this patch! Just one little question - I suppose Android\n> > > > > (and libcamera) have some other way of signalling a monochrome\n> > > > > sensor... I think I might have expected to find a\n> > > > > \"monochrome/non-Bayer\" option in the list?\n> > > >\n> > > > Please bare in mind this is a draft property, whose main purpose is\n> > > > to temporary close the gap with Android and its definition come\n> > > > straight from there.\n> > > >\n> > > > This property only makes sensor for RAW sensors, although there's a\n> > > > more generic 'RGB' value that sounds like a catch-all for non-Bayer\n> > > > sensors.\n> > > >\n> > > > Simply put: non-RAW sensor won't register this property at all.\n> > > > When we'll un-draft the property we can discuss if that makes sense\n> > > > at all as a choice, or we might want to have a more generic\n> > > > definition.\n> > > >\n> > > > Do you perhaps have any usage for such a more generic property in mind ?\n> > >\n> > > Not especially, my thoughts on the subject are only \"draft\" too! :)\n> > >\n> > > I guess my only observations are that a monochrome (\"no CFA at all\")\n> > > format would probably be useful (it's still a RAW format, though not a\n> >\n> > My bad, I always thought 'mono-chrome' as a YUV sensor with only the Y\n> > channel being sent out.\n> >\n> > > Bayer one). Also, that single non-RAW format (3x16-bit RGB) seems a\n> > > bit lonely, for example YUV422 interleaved is probably more common,\n> > > but I doubt we want to list all the possible pixel formats all over\n> > > again, we have enough of that already!\n> >\n> > I'm not sure I follow. How does a processed format like YUV422 relates\n> > to the sensor's color filters arrangements ?\n>\n> Laurent helped clarify this to me, and yes, we probably need a\n> definition for monochrome going forward. I would however keep the draft\n> property version as close as possible to Android's definition and\n> expand it when un-drafting.\n>\n> Thanks\n> j","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B94EC0F1C\n\tfor ;\n\tWed, 30 Dec 2020 10:00:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D7078615B2;\n\tWed, 30 Dec 2020 11:00:19 +0100 (CET)","from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com\n\t[IPv6:2607:f8b0:4864:20::22e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 890B16031B\n\tfor ;\n\tWed, 30 Dec 2020 11:00:18 +0100 (CET)","by mail-oi1-x22e.google.com with SMTP id p5so18200461oif.7\n\tfor ;\n\tWed, 30 Dec 2020 02:00:18 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"qJpvvd9l\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=jMp2Eq+5X1VE9V4oL3byy+hn+6z+3EUHKbDNsUeAlus=;\n\tb=qJpvvd9l9ZzQiKZaBHZORR6M/hlp2Osq+CSn+N0zy1kp3iW5KQxX5D3XQ4xZmoVeDI\n\tCZxKon8PBthG3jmwy6lZes88GOhO/MNf0pMUbg46+Yze6SDxqcHgOsgjD3YYlGEJuQZE\n\tSFwnoKn8x20JafBBNFObW/tH5CoSzuX1u3FHwPptM0pE8Ijs7A4bIeYHeTKwp6r94L8K\n\trigreX3a4Xj38kxi8UYBcIuaL1wLmsvymgZ3DYArMl4CmokDmCxvAnMtv+pbqLqOukZh\n\txrSolyTpnUxS8ZqZgGrxIN+o0LFm5pQ5RMOP2J2JrgCtoay5nVuUSKQeWrEaCEFSRJWl\n\tUVDw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=jMp2Eq+5X1VE9V4oL3byy+hn+6z+3EUHKbDNsUeAlus=;\n\tb=be4rqHo9bBgBoAkliIQL0k93++YzOuMbmOz+7COavrPbBFgxPEAGrPRG5/Rk2l8fBd\n\t3egA7VCZxEw43qmXTTAY2j2JtrkZtnDG/MawTdj8ztWTfWW7Wwt1KtCvruy7K2lCUr+B\n\t8zL2obLiuCv/3ObC3yJNjaA5FNB82dWZorEv0kPkNmz/bRzRg15p8ns1Gjsg+YCZFpJu\n\tDtasxKBwlkb8iLodYAcIlhmB6BZ26B98BfrNsQTK525iKucsz7ngAZbzI0hPDkpKDkvj\n\t6xdnJmy+twsP5qQiYL2UwFuuF2pJkB0aV1gZXnVrQdVEArdQNc0I2eJ4oWo1NxM81hjy\n\tLcQA==","X-Gm-Message-State":"AOAM532sJgQcVH11GfEtyYFJowWIKj4+U6nLfzkATGdWmx/cFhhuGwpQ\n\tNOFik/fc0m78Klt7zFKa9YK8661frq4IQ0MgGJ/ncpW2iG4=","X-Google-Smtp-Source":"ABdhPJzcwOCsNlXbZGhi4GmOvvSikNnr4Ulqcq0RKelqpBsy6wiIf6q081cabO8DkTiA0j+enO7lqxA332uY9ieI15Y=","X-Received":"by 2002:aca:f10b:: with SMTP id p11mr4800432oih.55.1609322417232;\n\tWed, 30 Dec 2020 02:00:17 -0800 (PST)","MIME-Version":"1.0","References":"<20201228164003.53051-1-jacopo@jmondi.org>\n\t<20201228164003.53051-2-jacopo@jmondi.org>\n\t<20201229045603.GL67590@pyrite.rasen.tech>\n\t\n\t<20201229102652.sw7jafpc5dqdd5qz@uno.localdomain>\n\t\n\t<20201230075931.bhxbygjjvtm6zs3a@uno.localdomain>\n\t<20201230093828.uftuuiqhnhrhbsph@uno.localdomain>","In-Reply-To":"<20201230093828.uftuuiqhnhrhbsph@uno.localdomain>","From":"David Plowman ","Date":"Wed, 30 Dec 2020 10:00:07 +0000","Message-ID":"","To":"Jacopo Mondi ","Subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: properties:\n\tColorFilterArrangement draft property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14418,"web_url":"https://patchwork.libcamera.org/comment/14418/","msgid":"","date":"2020-12-30T12:50:29","subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: properties:\n\tColorFilterArrangement draft property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nOn Wed, Dec 30, 2020 at 10:00:07AM +0000, David Plowman wrote:\n> Hi Jacopo\n> \n> Thanks for that. Actually I think I was a bit confused too. I was\n> thinking that the 3x16-bit was somehow supposed to include non-RAW\n> sensors, but I guess it doesn't. Maybe Android invented it to account\n> for those Foveon sensors that we had a few years back, which did give\n> you R, G and B at each location, but were still RAW?\n> \n> But anyway, I agree it will probably make sense to add a \"no CFA\"\n> option for those monochrome RAW sensors at some point. In fact, I\n> wonder if in future we may want to add that to our BayerFormat\n> class... at which point \"BayerFormat\" isn't necessarily the right name\n> any more. Oh dear! Anyway, that's a question for another time...\n\nColorFilterArray may be a better name. It depends on what the\nBayerFormat class ends up being used for. If it's just a helper to\ntranspose the component ordering, it shouldn't be too much of an issue.\nAndroid, in its android.sensor.info.colorFilterArrangement property,\ndifferentiates monochrome from NIR. There's a slippery slope toards\nexposing sensor frequency response information, which likely doesn't\nbelong to whatever BayerFormat will end up being.\n\nIn any case, it's a topic for later indeed.\n\n> On Wed, 30 Dec 2020 at 09:38, Jacopo Mondi wrote:\n> > On Wed, Dec 30, 2020 at 08:59:31AM +0100, Jacopo Mondi wrote:\n> > > On Tue, Dec 29, 2020 at 10:32:21PM +0000, David Plowman wrote:\n> > > > On Tue, 29 Dec 2020 at 10:26, Jacopo Mondi wrote:\n> > > > > On Tue, Dec 29, 2020 at 09:25:14AM +0000, David Plowman wrote:\n> > > > > > Hi Jacopo\n> > > > > >\n> > > > > > Thanks for this patch! Just one little question - I suppose Android\n> > > > > > (and libcamera) have some other way of signalling a monochrome\n> > > > > > sensor... I think I might have expected to find a\n> > > > > > \"monochrome/non-Bayer\" option in the list?\n> > > > >\n> > > > > Please bare in mind this is a draft property, whose main purpose is\n> > > > > to temporary close the gap with Android and its definition come\n> > > > > straight from there.\n> > > > >\n> > > > > This property only makes sensor for RAW sensors, although there's a\n> > > > > more generic 'RGB' value that sounds like a catch-all for non-Bayer\n> > > > > sensors.\n> > > > >\n> > > > > Simply put: non-RAW sensor won't register this property at all.\n> > > > > When we'll un-draft the property we can discuss if that makes sense\n> > > > > at all as a choice, or we might want to have a more generic\n> > > > > definition.\n> > > > >\n> > > > > Do you perhaps have any usage for such a more generic property in mind ?\n> > > >\n> > > > Not especially, my thoughts on the subject are only \"draft\" too! :)\n> > > >\n> > > > I guess my only observations are that a monochrome (\"no CFA at all\")\n> > > > format would probably be useful (it's still a RAW format, though not a\n> > >\n> > > My bad, I always thought 'mono-chrome' as a YUV sensor with only the Y\n> > > channel being sent out.\n> > >\n> > > > Bayer one). Also, that single non-RAW format (3x16-bit RGB) seems a\n> > > > bit lonely, for example YUV422 interleaved is probably more common,\n> > > > but I doubt we want to list all the possible pixel formats all over\n> > > > again, we have enough of that already!\n> > >\n> > > I'm not sure I follow. How does a processed format like YUV422 relates\n> > > to the sensor's color filters arrangements ?\n> >\n> > Laurent helped clarify this to me, and yes, we probably need a\n> > definition for monochrome going forward. I would however keep the draft\n> > property version as close as possible to Android's definition and\n> > expand it when un-drafting.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E12BC0F1C\n\tfor ;\n\tWed, 30 Dec 2020 12:50:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F0988615B2;\n\tWed, 30 Dec 2020 13:50:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 49B6260320\n\tfor ;\n\tWed, 30 Dec 2020 13:50:41 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD8602A3;\n\tWed, 30 Dec 2020 13:50:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fZ/BT0y7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1609332640;\n\tbh=+LMrs7wSUyr9Z2yOZnsY7X0g38vU88tmoil0RUN45+A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fZ/BT0y79OXrpNvtoUuAaGUtLs2qscfebdI9LMk2oAYdRmJfUxiQlNNJlVyIYcNPl\n\tX/ya9QbUxkuMbg8/eJpug7gGtwJXMjBN45M2ZFgv3s8I70UwRIta+GvNOPhLVEeCLG\n\tLaZgdT+0anby6AGTF0ngxKhDvcIYwhEb6WNT8bGc=","Date":"Wed, 30 Dec 2020 14:50:29 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20201228164003.53051-1-jacopo@jmondi.org>\n\t<20201228164003.53051-2-jacopo@jmondi.org>\n\t<20201229045603.GL67590@pyrite.rasen.tech>\n\t\n\t<20201229102652.sw7jafpc5dqdd5qz@uno.localdomain>\n\t\n\t<20201230075931.bhxbygjjvtm6zs3a@uno.localdomain>\n\t<20201230093828.uftuuiqhnhrhbsph@uno.localdomain>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: properties:\n\tColorFilterArrangement draft property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]