[{"id":14333,"web_url":"https://patchwork.libcamera.org/comment/14333/","msgid":"","date":"2020-12-27T09:51:16","subject":"Re: [libcamera-devel] [PATCH] Documentation: Fix Doxygen exclusion\n\tof details namespaces","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-12-27 11:47:56 +0200, Laurent Pinchart wrote:\n> The details namespaces in libcamera are used to hide implementation\n> details, and should thus be excluded from documentation generation. This\n> is done incorrectly by specifying the exclusion pattern \"*::details::*\"\n> which will ignore all namespaces and types in any details namespace, but\n> won't ignore functions. Fix it by removing the trailing \"::*\", causing\n> Doxygen to ignore the namespace itself, and thus all its contents.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> Documentation/Doxyfile.in | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/Doxyfile.in b/Documentation/Doxyfile.in\n> index c986fb6ab899..dc76cbeab335 100644\n> --- a/Documentation/Doxyfile.in\n> +++ b/Documentation/Doxyfile.in\n> @@ -877,7 +877,7 @@ EXCLUDE_SYMBOLS = libcamera::BoundMethodArgs \\\n> libcamera::BoundMethodStatic \\\n> libcamera::SignalBase \\\n> libcamera::*::Private \\\n> - *::details::* \\\n> + *::details \\\n> std::*\n> \n> # The EXAMPLE_PATH tag can be used to specify one or more files or directories\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 801F3C0F1B\n\tfor ;\n\tSun, 27 Dec 2020 09:51:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 07C40615AC;\n\tSun, 27 Dec 2020 10:51:21 +0100 (CET)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A03AC6031F\n\tfor ;\n\tSun, 27 Dec 2020 10:51:19 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id x20so17780710lfe.12\n\tfor ;\n\tSun, 27 Dec 2020 01:51:19 -0800 (PST)","from localhost ([185.224.57.161]) by smtp.gmail.com with ESMTPSA id\n\tj3sm4970138lfb.29.2020.12.27.01.51.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 27 Dec 2020 01:51:18 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"FNQgEHkk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=zlXw44kgwr4qcv8/waJ2qCy9XCmfjnvz35V5HSu3948=;\n\tb=FNQgEHkknJLturY7qIaRktiJaXyv85gXw+nIogLBm2IXRLQVbzYMXvZ66g5wjgmm9q\n\tXtFh6LTlenXwJvSG5O1850d/yrIYlP1rhQPvSNFVGtBNdAHo/8M/ZBQ18fntXVqdHMTh\n\tsE2QbVeWr4/tnY2ynlYZSoChDzcxuT2Sbb+X0x18Pz98tyF5TKtvEOQMT70tJlNEUHs/\n\tNxFkh7DYjnvcTscgOgXzj1+L94+WTjtHeJkN284lMW0d+Jfv/oEyJF1YLN/NmSkq0XYQ\n\ttDfOajKsfe2+vLd0P3UnKXAD/lWkOwhC+CoiNPtRt3eewxwk7lIxzoFXlkak0m6Onyrx\n\t7kMQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=zlXw44kgwr4qcv8/waJ2qCy9XCmfjnvz35V5HSu3948=;\n\tb=CzYcgP+4KTNXKNKqYrlog2S0B2HqWglYNEx7+9Lf7YfEIcJe/VNsS9ivIxfaZkAPVG\n\tYSbYlCBM7JpyxaInNiDj1vWhaRMXV6jiLrd/5/guHVrtVRReF57TidcWaoPYAo7GOABb\n\tRYvoqTg1R74Mr5YIklg161rWqleurqiJB4ey5x+n3HTOns2vcZ2GmAjrMIDntDXTE4Tp\n\thxWfdowsdSQPqmYQK+uulzPXN64yUF4e14xzVALEu2pVlU8/Go8jZhloKYuWHuMx0d+a\n\tRXZFcNcdAqNSUqGhEBXzfxi3Aag7RwDK8+nNt2+elY7APo6yyvp8N7EOsDB8yD2fRJTk\n\tie9Q==","X-Gm-Message-State":"AOAM532xnDGW8qwwOnsDolVXgFtQ/IFuaQpfFz5ohHFHyN4kL/Rn3+f9\n\tJgsuGkg7AGYKWscy1llgTK+leg==","X-Google-Smtp-Source":"ABdhPJz0zdS1/1YSwYzuxrFGsuxS5Spp8uoDpRUrTyOCPb/tuGTnrBsj7INIewO7cA+wNXIRYMCQVw==","X-Received":"by 2002:a2e:9f13:: with SMTP id\n\tu19mr18699662ljk.69.1609062679066; \n\tSun, 27 Dec 2020 01:51:19 -0800 (PST)","Date":"Sun, 27 Dec 2020 10:51:16 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20201227094756.26787-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201227094756.26787-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] Documentation: Fix Doxygen exclusion\n\tof details namespaces","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]