[{"id":14334,"web_url":"https://patchwork.libcamera.org/comment/14334/","msgid":"","date":"2020-12-27T10:10:12","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Remove\n\tthe unused configs_ variable","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Phi-Bang and Laurent,\n\nThanks for your work.\n\nOn 2020-12-24 16:19:04 +0200, Laurent Pinchart wrote:\n> From: Phi-Bang Nguyen \n> \n> Remove the unused configs_ member variable in SimpleCameraData.\n> \n> Signed-off-by: Phi-Bang Nguyen \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index b719171ab6d1..57bfb29094ff 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -85,7 +85,6 @@ public:\n> \tstd::list entities_;\n> \tV4L2VideoDevice *video_;\n> \n> -\tstd::vector configs_;\n> \tstd::map formats_;\n> };\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E88D8C0F1B\n\tfor ;\n\tSun, 27 Dec 2020 10:10:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 773B7615B0;\n\tSun, 27 Dec 2020 11:10:16 +0100 (CET)","from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC5B76031F\n\tfor ;\n\tSun, 27 Dec 2020 11:10:15 +0100 (CET)","by mail-lf1-x144.google.com with SMTP id o13so17934117lfr.3\n\tfor ;\n\tSun, 27 Dec 2020 02:10:15 -0800 (PST)","from localhost ([185.224.57.161]) by smtp.gmail.com with ESMTPSA id\n\ta11sm4967934lfl.22.2020.12.27.02.10.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 27 Dec 2020 02:10:14 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"g2NSbq4r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=1MC2UEgYcFcFsLr+XIRcGPu/zBGtsDnIG/GQvY5ERdk=;\n\tb=g2NSbq4rAGw3TdJUdJu/5ddaKYOJIARhp4gUzRhAg+y2xLQDOgr0S7b/d5WXdkXaRX\n\tUqpfz0+/Hahu7Ez6BB0ANZZxte6ZusPnPzkEG633N+43xR0/EtVy/ejHXDiDBOY5YAqv\n\tNclHhJgxXzoH01mgBAUqAWjHI/9HHIzAoIz61CxReLR2uQnFVgvJ6I1okJsvu7dq1800\n\t+TGn2hsIqbv2WhAIuDKIh2SOLS3rhGi/WLqO2L4NYK2u1bEI7T2rPw52/iEU1UUkO6zf\n\tchgiE3vNxpUKnwUTa0bJVEhnA3TXSMkvST7MvixmQ1ThK8hUDj9xKX4A0/1wTb0QJ9My\n\tpzpw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=1MC2UEgYcFcFsLr+XIRcGPu/zBGtsDnIG/GQvY5ERdk=;\n\tb=Er1bTZaBdP53qLwijgJYb9ngLER5Jv218J/wO3125+FUoOGpAXGNMFn/+rt2YPNVlW\n\teK356sVyT4jfJQ+lCqgcacFFha0DBjHA9W6MPLjxfsnZCdSM8BHtujcndFMQ5UZg3+HY\n\tIOKtp3RD8Pfj6t021BDl/4ss2B23AmgMo6TiilD20AhAXhzRBa3SaQtIFuw7MMOIwjso\n\t93k65YXH2DeG7k6PlvDEpR2EE4JL3XkHfUEF5NO1Gh06D8EXfmVcMJgXWp3ZqMF4K6uC\n\tfca5WSUfhOk5ib1RAfa0zh/De4mWRuUDKn/95CXKu2Uk/efwpYkAViPahxM+Rl5PhsT3\n\t46TA==","X-Gm-Message-State":"AOAM532UIj5LnZ0uWsh4KZPJzAvfuH8RPR9MQPgNYMYhXdg3f9FpZKHI\n\too/wPPNJzff1P6YpFUTsIiJTUsqS6rxhnQ==","X-Google-Smtp-Source":"ABdhPJyTr02LjFMuSUin/ShsQuuqOtorSzwgj51x1h6xYzHaV1AVUP3N6dOcU6f/rLffuneOA+HlMg==","X-Received":"by 2002:a2e:96d8:: with SMTP id\n\td24mr19236483ljj.62.1609063815134; \n\tSun, 27 Dec 2020 02:10:15 -0800 (PST)","Date":"Sun, 27 Dec 2020 11:10:12 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20201224141904.28503-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201224141904.28503-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Remove\n\tthe unused configs_ variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Phi-Bang Nguyen ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]