[{"id":14346,"web_url":"https://patchwork.libcamera.org/comment/14346/","msgid":"","date":"2020-12-27T10:51:51","subject":"Re: [libcamera-devel] [PATCH 8/8] utils: checkstyle.py: Add header\n\tadd checker","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for the new checker, if only I could create one for my bad \nspelling ;-P\n\nOn 2020-12-24 14:28:55 +0200, Laurent Pinchart wrote:\n> Add a commit checker that ensures that all header files added to the\n> libcamera includes (public or internal) are accompanied by a\n> corresponding update of the meson.build file in the same directory.\n> \n> Here's the output of the new checker when run against a commit that\n> forgot to update meson.build.\n> \n> $ ./utils/checkstyle.py b3383da79f1d\n> ---------------------------------------------------------------------------------\n> b3383da79f1d513b0d76db220a7104e1c1035e30 libcamera: buffer: Create a MappedBuffer\n> ---------------------------------------------------------------------------------\n> Header include/libcamera/internal/buffer.h added without corresponding update to include/libcamera/internal/meson.build\n> ---\n> 1 potential issue detected, please review\n> \n> In theory we could extend the checker to cover .cpp files too, but the\n> issue will be quite noticeable as meson won't build the file if\n> meson.build isn't updated. Header files are more tricky as problems\n> would only occur at when installing the headers (for public headers), or\n> would result in race conditions in the build. Both of those issues are\n> harder to catch.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> utils/checkstyle.py | 44 ++++++++++++++++++++++++++++++++++++++++++++\n> 1 file changed, 44 insertions(+)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index c0a6b7ab06cd..e618db937c2b 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -320,6 +320,50 @@ class CommitIssue(object):\n> self.msg = msg\n> \n> \n> +class HeaderAddChecker(CommitChecker):\n> + @classmethod\n> + def check(cls, commit, top_level):\n> + issues = []\n> +\n> + meson_files = [f for f in commit.files('M')\n> + if os.path.basename(f) == 'meson.build']\n> +\n> + for filename in commit.files('A'):\n> + if not filename.startswith('include/libcamera/') or \\\n> + not filename.endswith('.h'):\n> + continue\n> +\n> + meson = os.path.dirname(filename) + '/meson.build'\n> + header = os.path.basename(filename)\n> +\n> + issue = CommitIssue('Header %s added without corresponding update to %s' %\n> + (filename, meson))\n> +\n> + if meson not in meson_files:\n> + issues.append(issue)\n> + continue\n> +\n> + diff = commit.get_diff(top_level, meson)\n> + found = False\n> +\n> + for hunk in diff:\n> + for line in hunk.lines:\n> + if line[0] != '+':\n> + continue\n> +\n> + if line.find(\"'%s'\" % header) != -1:\n> + found = True\n> + break\n> +\n> + if found:\n> + break\n> +\n> + if not found:\n> + issues.append(issue)\n> +\n> + return issues\n> +\n> +\n> # ------------------------------------------------------------------------------\n> # Style Checkers\n> #\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4BC49C0F1A\n\tfor ;\n\tSun, 27 Dec 2020 10:51:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C5581615B0;\n\tSun, 27 Dec 2020 11:51:56 +0100 (CET)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC037615AC\n\tfor ;\n\tSun, 27 Dec 2020 11:51:54 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id s26so17993407lfc.8\n\tfor ;\n\tSun, 27 Dec 2020 02:51:54 -0800 (PST)","from localhost ([185.224.57.161]) by smtp.gmail.com with ESMTPSA id\n\tl13sm5988926lje.138.2020.12.27.02.51.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 27 Dec 2020 02:51:53 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"AoGJOymx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=rJI1ptq3JGtE5fHamTmahNgjfMJzoz0SOzfNXW1rSj8=;\n\tb=AoGJOymxTfeHsuwfqf6bFRiTRI3/+/kTLwDkl+Z0W63erU1btpRKt0XWkD/aw/cPXE\n\taIGrqzzLl/sggQFGgYXdvCIFGmPWzGgSlzZqJpZvK7zXH8wsIjHTty9P6B/ORHxPuPVD\n\tEiGmYQipUz8g1DTl/hNKYh2vbrvog1l+y/ClUJSrWyyGZyNrwNu9oNDreUWFXNETYdo8\n\t9Og56Pa1Hyb7hj+S1BQxik8gwH1v1lEpptAtBhE3ZSpuyWhq5oLnAR/1/kuWb/2xsVGP\n\tC1BAthPIM0WawjtTCCEa6apCPSGVQaiTJXv/1goDksxKD+aBGZEluCiITKWqphF0J9gW\n\tx5UQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=rJI1ptq3JGtE5fHamTmahNgjfMJzoz0SOzfNXW1rSj8=;\n\tb=iqx77mrleaEuSpuMqQqQx343DDMGCjqH4ALV/0NCcJMJELjnJvxlEieJdakCCydXfF\n\tX2fZzsMBXtjRzzm54ORT5B9MXxffmIhHYKtUrm5+XN9eJesnjUrB5k6oZxY50xCNt+P/\n\tuPykZTmr4znM5OAYIbGoeO9B2W8J8g2HQ3JZUaIOr/85aNjcqgHhSI2rFXELUzAIbWtD\n\tOGY6Cyc4R5v4KaOL15bn2/jzW+98yr+9iYnHQZLda/2moZb49SGno2+7FmM2pI1K8c3L\n\tdo1cxtUV+WbUrPJzCrzJVUdVNYsLXPW3W4MwiTEvuN9q1X7qTTQ6onfKveh9E+t6hSzM\n\tvQMQ==","X-Gm-Message-State":"AOAM5326ynspY9qJxyty5uKj+JPTPdV8j3oBCRP8DlxSiRZoDQ1Hh+sh\n\tSfPugJ37IASHZ0ZbC1tEyyrE0yP2IH1COQ==","X-Google-Smtp-Source":"ABdhPJxe0uuBJTQNoQweoVPr6lB/+NkBggvtepOGIMq8viLFlAqUj7P2HLPRQzts4OaNz5x1NsZoXg==","X-Received":"by 2002:a2e:9b0c:: with SMTP id\n\tu12mr20462804lji.466.1609066314240; \n\tSun, 27 Dec 2020 02:51:54 -0800 (PST)","Date":"Sun, 27 Dec 2020 11:51:51 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20201224122855.22200-1-laurent.pinchart@ideasonboard.com>\n\t<20201224122855.22200-9-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201224122855.22200-9-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 8/8] utils: checkstyle.py: Add header\n\tadd checker","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14396,"web_url":"https://patchwork.libcamera.org/comment/14396/","msgid":"","date":"2020-12-29T14:56:38","subject":"Re: [libcamera-devel] [PATCH 8/8] utils: checkstyle.py: Add header\n\tadd checker","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 27/12/2020 10:51, Niklas Söderlund wrote:\n> Hi Laurent,\n> \n> Thanks for the new checker, if only I could create one for my bad \n> spelling ;-P\n\nI started one,trying to use the python 'enchant' package, but the\nperformance was ... absolutely appalling :-(\n\nI look forward to the one you create ;-)\n\n--\nKieran\n\n\n\n> On 2020-12-24 14:28:55 +0200, Laurent Pinchart wrote:\n>> Add a commit checker that ensures that all header files added to the\n>> libcamera includes (public or internal) are accompanied by a\n>> corresponding update of the meson.build file in the same directory.\n>>\n>> Here's the output of the new checker when run against a commit that\n>> forgot to update meson.build.\n>>\n>> $ ./utils/checkstyle.py b3383da79f1d\n>> ---------------------------------------------------------------------------------\n>> b3383da79f1d513b0d76db220a7104e1c1035e30 libcamera: buffer: Create a MappedBuffer\n>> ---------------------------------------------------------------------------------\n>> Header include/libcamera/internal/buffer.h added without corresponding update to include/libcamera/internal/meson.build\n>> ---\n>> 1 potential issue detected, please review\n>>\n>> In theory we could extend the checker to cover .cpp files too, but the\n>> issue will be quite noticeable as meson won't build the file if\n>> meson.build isn't updated. Header files are more tricky as problems\n>> would only occur at when installing the headers (for public headers), or\n>> would result in race conditions in the build. Both of those issues are\n>> harder to catch.\n>>\n>> Signed-off-by: Laurent Pinchart \n> \n> Reviewed-by: Niklas Söderlund \n> \n>> ---\n>> utils/checkstyle.py | 44 ++++++++++++++++++++++++++++++++++++++++++++\n>> 1 file changed, 44 insertions(+)\n>>\n>> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n>> index c0a6b7ab06cd..e618db937c2b 100755\n>> --- a/utils/checkstyle.py\n>> +++ b/utils/checkstyle.py\n>> @@ -320,6 +320,50 @@ class CommitIssue(object):\n>> self.msg = msg\n>> \n>> \n>> +class HeaderAddChecker(CommitChecker):\n>> + @classmethod\n>> + def check(cls, commit, top_level):\n>> + issues = []\n>> +\n>> + meson_files = [f for f in commit.files('M')\n>> + if os.path.basename(f) == 'meson.build']\n>> +\n>> + for filename in commit.files('A'):\n>> + if not filename.startswith('include/libcamera/') or \\\n>> + not filename.endswith('.h'):\n>> + continue\n>> +\n>> + meson = os.path.dirname(filename) + '/meson.build'\n>> + header = os.path.basename(filename)\n>> +\n>> + issue = CommitIssue('Header %s added without corresponding update to %s' %\n>> + (filename, meson))\n>> +\n>> + if meson not in meson_files:\n>> + issues.append(issue)\n>> + continue\n>> +\n>> + diff = commit.get_diff(top_level, meson)\n>> + found = False\n>> +\n>> + for hunk in diff:\n>> + for line in hunk.lines:\n>> + if line[0] != '+':\n>> + continue\n>> +\n>> + if line.find(\"'%s'\" % header) != -1:\n>> + found = True\n>> + break\n>> +\n>> + if found:\n>> + break\n>> +\n>> + if not found:\n>> + issues.append(issue)\n>> +\n>> + return issues\n>> +\n>> +\n>> # ------------------------------------------------------------------------------\n>> # Style Checkers\n>> #\n>> -- \n>> Regards,\n>>\n>> Laurent Pinchart\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BBA0AC0F1C\n\tfor ;\n\tTue, 29 Dec 2020 14:56:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A454615B2;\n\tTue, 29 Dec 2020 15:56:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 857386031F\n\tfor ;\n\tTue, 29 Dec 2020 15:56:41 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D7AE698;\n\tTue, 29 Dec 2020 15:56:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DX5SH8oD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1609253801;\n\tbh=c8BDOHEbIQCgMndZ4tq3nQSshFIdyomgN8CV78Ou444=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=DX5SH8oD7Bw2HKx5RXl5lAAFuArA9HzLbEyaThSYlyt6EQb+cKxbBH84QzFoXpVhn\n\tKHh9gumTpEcvv6UndauenNOuvCwNFT/2ji3EZ10r6PJqzR3kFJrP+6pgsyUY+DtZsC\n\tOzhRxNlppHkwGz/8M2NSxnOFD/hHjzkDS0wPeF5w=","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tLaurent Pinchart ","References":"<20201224122855.22200-1-laurent.pinchart@ideasonboard.com>\n\t<20201224122855.22200-9-laurent.pinchart@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 29 Dec 2020 14:56:38 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 8/8] utils: checkstyle.py: Add header\n\tadd checker","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]