[{"id":1484,"web_url":"https://patchwork.libcamera.org/comment/1484/","msgid":"<20190419104352.GC7006@pendragon.ideasonboard.com>","date":"2019-04-19T10:43:52","subject":"Re: [libcamera-devel] [PATCH v7 1/8] libcamera: stream: Document\n\tprotected members","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Apr 19, 2019 at 12:18:32PM +0200, Jacopo Mondi wrote:\n> Since commit: 4e1dc9004fca (\"libcamera: stream: Make Stream inheritable\")\n> the private members of the Stream class have been turned into protected,\n> to allows subclasses to access them.\n> \n> As Doxygen generates documentation for protected members (but not for\n> private memebers), add documentation to the stream class for the\n> 'bufferMap_' and 'configuration_' members.\n> \n> Fixes: 4e1dc9004fca (\"libcamera: stream: Make Stream inheritable\")\n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/stream.cpp | 18 ++++++++++++++++++\n> 1 file changed, 18 insertions(+)\n> \n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index 85cd5256ee2f..aeb56fc1cadf 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -194,4 +194,22 @@ Stream::Stream()\n> * \\return The active configuration of the stream\n> */\n> \n> +/**\n> + * \\var Stream::bufferPool_\n> + * \\brief The pool of buffers associated with the stream\n> + *\n> + * The stream buffer pool is populated by the Camera class after a succesfull\n> + * stream configuration.\n> + */\n> +\n> +/**\n> + * \\var Stream::configuration_\n> + * \\brief The stream configuration\n> + *\n> + * The configuration for the stream is set by any successful call to\n> + * Camera::configureStreams() that includes the stream, and remains valid until\n> + * the next call to Camera::configureStreams() regardless of if it includes the\n> + * stream.\n> + */\n> +\n> } /* namespace libcamera */","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 693EC60B2E\n\tfor ;\n\tFri, 19 Apr 2019 12:44:10 +0200 (CEST)","from pendragon.ideasonboard.com (unknown\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D85E931A;\n\tFri, 19 Apr 2019 12:44:09 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1555670650;\n\tbh=I/Dkfdu/FBRdyLZbpDCeqffdMTo+3EhT+wCVJsKPW2g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CG5gAittWqcAbAYv5LrxO4AL0M4q4orYantlQOmeHtMZVrD58p4k44aZ0y4Yrpaaa\n\tEl1t/2F/cnN+rojCVedee+X4F8jZjbROBdxoOGluRhITyo+3C0W4YxWaUdfQea62ML\n\t1dHfoa4l5LzQMAdidbfz89dly93HAUjRXLR+Sct0=","Date":"Fri, 19 Apr 2019 13:43:52 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190419104352.GC7006@pendragon.ideasonboard.com>","References":"<20190419101839.10337-1-jacopo@jmondi.org>\n\t<20190419101839.10337-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190419101839.10337-2-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v7 1/8] libcamera: stream: Document\n\tprotected members","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 19 Apr 2019 10:44:10 -0000"}}]