[{"id":14339,"web_url":"https://patchwork.libcamera.org/comment/14339/","msgid":"","date":"2020-12-27T10:24:36","subject":"Re: [libcamera-devel] [PATCH 1/8] utils: checkstyle.py: Drop\n\targuments to super() when possible","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-12-24 14:28:48 +0200, Laurent Pinchart wrote:\n> The super() call is a shortcut syntax for super(__class__, ).\n> Drom the arguments when they match the default.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> utils/checkstyle.py | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index 7225cac47a4e..c04bf3850dcd 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -198,7 +198,7 @@ _style_checkers = []\n> \n> class StyleCheckerRegistry(type):\n> def __new__(cls, clsname, bases, attrs):\n> - newclass = super(StyleCheckerRegistry, cls).__new__(cls, clsname, bases, attrs)\n> + newclass = super().__new__(cls, clsname, bases, attrs)\n> if clsname != 'StyleChecker':\n> _style_checkers.append(newclass)\n> return newclass\n> @@ -387,7 +387,7 @@ _formatters = []\n> \n> class FormatterRegistry(type):\n> def __new__(cls, clsname, bases, attrs):\n> - newclass = super(FormatterRegistry, cls).__new__(cls, clsname, bases, attrs)\n> + newclass = super().__new__(cls, clsname, bases, attrs)\n> if clsname != 'Formatter':\n> _formatters.append(newclass)\n> return newclass\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03BEEC0F1A\n\tfor ;\n\tSun, 27 Dec 2020 10:24:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B763615D2;\n\tSun, 27 Dec 2020 11:24:40 +0100 (CET)","from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED75660525\n\tfor ;\n\tSun, 27 Dec 2020 11:24:39 +0100 (CET)","by mail-lf1-x143.google.com with SMTP id x20so17877073lfe.12\n\tfor ;\n\tSun, 27 Dec 2020 02:24:39 -0800 (PST)","from localhost ([185.224.57.161]) by smtp.gmail.com with ESMTPSA id\n\tf23sm4962065lfk.298.2020.12.27.02.24.38\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 27 Dec 2020 02:24:38 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"Im6E6TKT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=CkMczqS591jW1+GiraqrwzCjp7CTRXtd/Z3tvakNTMc=;\n\tb=Im6E6TKT+Pqjb1c+VOJ0Ie7DvtSeoNuWhHjzQrEk/06pwquPnIT46kf7MGfmGsoWyh\n\tDsU7P/OZwu4r/By2oyItA1PmKtvO4PAZ1nCXHkkkceF+3uSzz40HyhLDeRdXgZhNvAIu\n\trt5yyFtrIdzovZjHlmqQZkFNfHNP/HevbThr1gNVPTmQDto5CuaJycMGB1+RDgNs2s1u\n\tqxWBKOo9kreK1/Q55BfpL9Q00yexjqOQ4MSCdf2CaJPDCUnUJw/31s1I2RncmifjynWl\n\taBGh7kELWm9Qij7uvNWzLp/JCSzTsF4hmTfyYGtj/uaiAVXs8zlmKERvBJaXVS+Bk3YC\n\tfSEw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=CkMczqS591jW1+GiraqrwzCjp7CTRXtd/Z3tvakNTMc=;\n\tb=GG900Pi3BHnSXSEOeL/INXJaXCv7PGt+b9L0sPo3MepQpWhr4whaV80cDHampeA168\n\tvyNfG0fWlbq6efn8lo0Hpwg70N/UlE6szm0UZ+Ha/oHYmPkAlH2pz5WT/xtmZq4BxAEb\n\t8akXR+KGtt/xtnC6jeLlRWuSZV5Fd7C5pyZvU3tJQXUk8Bly/U0wVGuT9HH5ocPlfIAT\n\tRcV0d708DuQuInN+WvGsqdlSI66JR0U+O2Ur49giosxa6tE04+yXNLiacRrMBElzdsv0\n\tXUM3G1NjMKdPvbL/PK6AntbIbcrvnCVIC5wd+nN/73xS5LyqosHv10SJUAnXsKK0chQr\n\tyLXA==","X-Gm-Message-State":"AOAM532zF097znFBFG7rclQZGfV8OPstLzIGc/873tDFW1J0Xer8tyg2\n\tX/pq/3ENDfDbA8qf7Uw3vKZ4jQ==","X-Google-Smtp-Source":"ABdhPJwzTNQxKdQePM1AoS/JSqF/7chHl/1HMauf13oCDWFybkQxUmnIxifS1wZwSsdixyt6NHWaHQ==","X-Received":"by 2002:a19:7109:: with SMTP id\n\tm9mr14247576lfc.351.1609064679441; \n\tSun, 27 Dec 2020 02:24:39 -0800 (PST)","Date":"Sun, 27 Dec 2020 11:24:36 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20201224122855.22200-1-laurent.pinchart@ideasonboard.com>\n\t<20201224122855.22200-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201224122855.22200-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/8] utils: checkstyle.py: Drop\n\targuments to super() when possible","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14362,"web_url":"https://patchwork.libcamera.org/comment/14362/","msgid":"<20201228050336.GA1933@pyrite.rasen.tech>","date":"2020-12-28T05:03:36","subject":"Re: [libcamera-devel] [PATCH 1/8] utils: checkstyle.py: Drop\n\targuments to super() when possible","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Thu, Dec 24, 2020 at 02:28:48PM +0200, Laurent Pinchart wrote:\n> The super() call is a shortcut syntax for super(__class__, ).\n> Drom the arguments when they match the default.\n\ns/Drom/Drop\n\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> utils/checkstyle.py | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index 7225cac47a4e..c04bf3850dcd 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -198,7 +198,7 @@ _style_checkers = []\n> \n> class StyleCheckerRegistry(type):\n> def __new__(cls, clsname, bases, attrs):\n> - newclass = super(StyleCheckerRegistry, cls).__new__(cls, clsname, bases, attrs)\n> + newclass = super().__new__(cls, clsname, bases, attrs)\n> if clsname != 'StyleChecker':\n> _style_checkers.append(newclass)\n> return newclass\n> @@ -387,7 +387,7 @@ _formatters = []\n> \n> class FormatterRegistry(type):\n> def __new__(cls, clsname, bases, attrs):\n> - newclass = super(FormatterRegistry, cls).__new__(cls, clsname, bases, attrs)\n> + newclass = super().__new__(cls, clsname, bases, attrs)\n> if clsname != 'Formatter':\n> _formatters.append(newclass)\n> return newclass\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 82C6EC0F1B\n\tfor ;\n\tMon, 28 Dec 2020 05:03:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 09E1460525;\n\tMon, 28 Dec 2020 06:03:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C9BE36031B\n\tfor ;\n\tMon, 28 Dec 2020 06:03:44 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3C4EA25C;\n\tMon, 28 Dec 2020 06:03:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KgymvWbK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1609131824;\n\tbh=pT5osbUh8qp+sez4rXE5qAK01jVY4+i2x5WbsHUT9AA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KgymvWbKTQJoPhrc4S6I0Ofj1CXB/QQCit1BicYr9+VkomsWCmTfM7NeknK47XCM4\n\tlmsGvMaR+nuQGzCwB41Z0JY5zzyKRr9U+TRLl0+A5e27sIdSMa/xggOCa6xrEdze1R\n\tTdbQShEek7Yacy8FBzuY4IVlsY+KbyxsY9TUBSHY=","Date":"Mon, 28 Dec 2020 14:03:36 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20201228050336.GA1933@pyrite.rasen.tech>","References":"<20201224122855.22200-1-laurent.pinchart@ideasonboard.com>\n\t<20201224122855.22200-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201224122855.22200-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/8] utils: checkstyle.py: Drop\n\targuments to super() when possible","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]