[{"id":14372,"web_url":"https://patchwork.libcamera.org/comment/14372/","msgid":"<20201228082908.GI1933@pyrite.rasen.tech>","date":"2020-12-28T08:29:08","subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: ipu3: Register sensor\n\tcontrols","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Wed, Dec 23, 2020 at 07:45:16PM +0100, Jacopo Mondi wrote:\n> Register the sensor provided controls together with the pipeline\n> handler initialized controls.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 8a1918d5e4c5..fc5590aaf5a0 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -777,7 +777,12 @@ int PipelineHandlerIPU3::registerCameras()\n> \t\tdata->properties_ = cio2->sensor()->properties();\n> \n> \t\t/* Initialze the camera controls. */\n> -\t\tdata->controlInfo_ = IPU3Controls;\n> +\t\tControlInfoMap::Map controlsMap;\n> +\t\tfor (const auto &it : IPU3Controls)\n> +\t\t\tcontrolsMap[it.first] = it.second;\n> +\t\tfor (const auto &it : cio2->sensor()->controls())\n> +\t\t\tcontrolsMap[it.first] = it.second;\n> +\t\tdata->controlInfo_ = std::move(controlsMap);\n> \n> \t\t/**\n> \t\t * \\todo Dynamically assign ImgU and output devices to each\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88E50C0F1A\n\tfor ;\n\tMon, 28 Dec 2020 08:29:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5AA286159A;\n\tMon, 28 Dec 2020 09:29:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA5A46031E\n\tfor ;\n\tMon, 28 Dec 2020 09:29:14 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 89AF225C;\n\tMon, 28 Dec 2020 09:29:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"t/I9XV0G\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1609144154;\n\tbh=sMfTYQU/yIIZkKERbdGz000TRqolvAfq8FbUDWZWi0Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=t/I9XV0G1wnZ5Y0hAvE4T5C8sVYD8jXxi1DcnUKZWuXralDaLkPGput14WAC1+p97\n\tRjSDjX91U+UcLGO+nEcSKfG2Z9eWWfn494sTwEeYmx35IsEOr305tt83c2drIVEi42\n\tKCYgWS/gdYzEwoMsWJZ3oYlXmZIZi5ZTb+bQkq4Q=","Date":"Mon, 28 Dec 2020 17:29:08 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20201228082908.GI1933@pyrite.rasen.tech>","References":"<20201223184516.58791-1-jacopo@jmondi.org>\n\t<20201223184516.58791-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201223184516.58791-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: ipu3: Register sensor\n\tcontrols","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]