[{"id":14371,"web_url":"https://patchwork.libcamera.org/comment/14371/","msgid":"<20201228082843.GH1933@pyrite.rasen.tech>","date":"2020-12-28T08:28:43","subject":"Re: [libcamera-devel] [PATCH 4/5] libcamera: camera_sensor: Add\n\tcontrols() method","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Wed, Dec 23, 2020 at 07:45:15PM +0100, Jacopo Mondi wrote:\n> Add a controls() method to retrieve the map of libcamera controls\n> registered by the CameraSensor class.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/internal/camera_sensor.h | 1 +\n> src/libcamera/camera_sensor.cpp | 6 ++++++\n> 2 files changed, 7 insertions(+)\n> \n> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> index 841c7f4bef0f..10877b9d1d9d 100644\n> --- a/include/libcamera/internal/camera_sensor.h\n> +++ b/include/libcamera/internal/camera_sensor.h\n> @@ -62,6 +62,7 @@ public:\n> \tint setControls(ControlList *ctrls);\n> \n> \tconst ControlList &properties() const { return properties_; }\n> +\tconst ControlInfoMap &controls() const { return controls_; }\n> \tint sensorInfo(CameraSensorInfo *info) const;\n> \n> protected:\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index fa85484f6186..e95a254c03cc 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -652,6 +652,12 @@ ControlList CameraSensor::getControls(const std::vector &ids)\n> * \\return The list of camera sensor properties\n> */\n> \n> +/**\n> + * \\fn CameraSensor::controls()\n> + * \\brief Retrieve the camera sensor controls info\n> + * \\return The map of camera sensor controls info\n> + */\n> +\n> /**\n> * \\brief Write controls to the sensor\n> * \\param[in] ctrls The list of controls to write\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7698C0F1A\n\tfor ;\n\tMon, 28 Dec 2020 08:28:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B0FE4615B1;\n\tMon, 28 Dec 2020 09:28:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5883C6031E\n\tfor ;\n\tMon, 28 Dec 2020 09:28:51 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D949F25C;\n\tMon, 28 Dec 2020 09:28:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"td19xxOe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1609144131;\n\tbh=9y0hWK5Z++dx9wpm95A5nczz7+Tr/EmA5+zKjc61ZpQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=td19xxOec/G8weEu8nh4xZ44wKUo58i1qzAnG1v0IeFGzoBnLmS56rtMbnfqs1T1X\n\tmHdj2/tbRG8drSs5j/nRD8RTQoVYWU+5GK+3+yJnVLoSllYQd7iR/mL1mB08vaRBnt\n\t0JO3/sQMP1NowBiyJp5JrYhhV0I9hTo25zC5oUnI=","Date":"Mon, 28 Dec 2020 17:28:43 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20201228082843.GH1933@pyrite.rasen.tech>","References":"<20201223184516.58791-1-jacopo@jmondi.org>\n\t<20201223184516.58791-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201223184516.58791-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 4/5] libcamera: camera_sensor: Add\n\tcontrols() method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]