[{"id":14351,"web_url":"https://patchwork.libcamera.org/comment/14351/","msgid":"","date":"2020-12-27T11:09:19","subject":"Re: [libcamera-devel] [PATCH 6/6] android: camera_device: Simplify\n\tproperties.get()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Dec 23, 2020 at 06:47:09PM +0100, Jacopo Mondi wrote:\n> When accessing the value of a property by reading the properties\n> ControlList content with ControlList::get<>() it is not necessary to\n> specify the template type as it is already conveyed by the Control\n> instance provided as first argument.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 920baab254b6..fb4c8be34f95 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -853,7 +853,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t/* Sensor static metadata. */\n> \tif (properties.contains(properties::PixelArraySize)) {\n> \t\tconst Size &size =\n> -\t\t\tproperties.get(properties::PixelArraySize);\n> +\t\t\tproperties.get(properties::PixelArraySize);\n> \t\tstd::vector data{\n> \t\t\tstatic_cast(size.width),\n> \t\t\tstatic_cast(size.height),\n> @@ -872,7 +872,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \n> \tif (properties.contains(properties::PixelArrayActiveAreas)) {\n> \t\tconst Span &rects =\n> -\t\t\tproperties.get>(properties::PixelArrayActiveAreas);\n> +\t\t\tproperties.get(properties::PixelArrayActiveAreas);\n> \t\tstd::vector data{\n> \t\t\tstatic_cast(rects[0].x),\n> \t\t\tstatic_cast(rects[0].y),","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 58992C0F1A\n\tfor ;\n\tSun, 27 Dec 2020 11:09:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2B395615B4;\n\tSun, 27 Dec 2020 12:09:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54D1960526\n\tfor ;\n\tSun, 27 Dec 2020 12:09:29 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D736780B;\n\tSun, 27 Dec 2020 12:09:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"evgXaBjS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1609067369;\n\tbh=Owz0BfXJIkHJylFsVKXF+i/+/76ZBnC0aItNlAJR108=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=evgXaBjS1KuqQsvUGHgH4zB8B4uKcBaSPLY30bCSUWaPQYc91MFLQr7SVGRlFRzKC\n\txl066zfStLP1OoiWHQTIGiGEKhNXoj/UgiDh0NGosBZ2k+3bUfHgFDiyF2dhgoG8i/\n\t+lRCdKpAJxxbJInPgQsO66z9IsIIO51CfcTcJf/w=","Date":"Sun, 27 Dec 2020 13:09:19 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201223174709.45457-1-jacopo@jmondi.org>\n\t<20201223174709.45457-7-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201223174709.45457-7-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 6/6] android: camera_device: Simplify\n\tproperties.get()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14355,"web_url":"https://patchwork.libcamera.org/comment/14355/","msgid":"","date":"2020-12-27T11:15:33","subject":"Re: [libcamera-devel] [PATCH 6/6] android: camera_device: Simplify\n\tproperties.get()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-12-23 18:47:09 +0100, Jacopo Mondi wrote:\n> When accessing the value of a property by reading the properties\n> ControlList content with ControlList::get<>() it is not necessary to\n> specify the template type as it is already conveyed by the Control\n> instance provided as first argument.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 920baab254b6..fb4c8be34f95 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -853,7 +853,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t/* Sensor static metadata. */\n> \tif (properties.contains(properties::PixelArraySize)) {\n> \t\tconst Size &size =\n> -\t\t\tproperties.get(properties::PixelArraySize);\n> +\t\t\tproperties.get(properties::PixelArraySize);\n> \t\tstd::vector data{\n> \t\t\tstatic_cast(size.width),\n> \t\t\tstatic_cast(size.height),\n> @@ -872,7 +872,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \n> \tif (properties.contains(properties::PixelArrayActiveAreas)) {\n> \t\tconst Span &rects =\n> -\t\t\tproperties.get>(properties::PixelArrayActiveAreas);\n> +\t\t\tproperties.get(properties::PixelArrayActiveAreas);\n> \t\tstd::vector data{\n> \t\t\tstatic_cast(rects[0].x),\n> \t\t\tstatic_cast(rects[0].y),\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E815EC0F1B\n\tfor ;\n\tSun, 27 Dec 2020 11:15:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B75C662006;\n\tSun, 27 Dec 2020 12:15:46 +0100 (CET)","from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55F2C615B1\n\tfor ;\n\tSun, 27 Dec 2020 12:15:45 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id h205so18096844lfd.5\n\tfor ;\n\tSun, 27 Dec 2020 03:15:45 -0800 (PST)","from localhost ([185.224.57.161]) by smtp.gmail.com with ESMTPSA id\n\tn84sm4996098lfd.176.2020.12.27.03.15.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 27 Dec 2020 03:15:44 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"uuf9ifIE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=wv1segtfkTh9v4MTczNmPJOwkW4+XyfBf3CiLszXx7w=;\n\tb=uuf9ifIESEqA9onrpICFF2/4frT0x33/QTPO7tZ5Okk4b0M0tcLpcKEPHEa98FWHlk\n\tX1tNiAg/JDu8yxjIZoLa991Fbpl8OBwe+6aeGKmuWOnt3uh5yXJw/mr1+0p67CEFez5i\n\tIH849lwU0eZ3vXENSG+PdzCm8MNK4UOlLekU1aaQ8lNto/E6Wu5x5kAgbA0HbUWQQjIu\n\t13ZMPlS+v2KpS5CzdrdvI9lOOgLOXNr/kV/kund1smc2wYXYnoYp+yfJjM0kIankGYgr\n\t6T43xWN7gho4laYWeLOxOVeEwxRH0dFtVpxxEi/YMPQ1nUsJXT+CHRHIW3Mto/2rh+ol\n\tg38g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=wv1segtfkTh9v4MTczNmPJOwkW4+XyfBf3CiLszXx7w=;\n\tb=JUpOHAgt7wyUvM+/7V6S+OYCxM8C+dMWyTs0vHFvAcu5frMwjbKLYNZRc9Hlc16jxf\n\tzhYlL5evDwEJ5SLGw8MUSF6Blr0YiwVW93WfXPc6NGhQriwYWk+xE+5MZCvx5hxpoR0m\n\tBquvrrd7g6+fj4efXb9UoW/n+io63ArRgFlu+eMu9WYuydY0iwcKMZ2LhF5mgx3jRcdo\n\tCssqLj4xkOimdWtPWLkdk8vP2EXOsYVSfa5uskbrFoOikndX8OrjuvVi6zjAZgFJKRvP\n\tdZ0gBbhDYBfOljruTIuVzgWGMf7hmL4Za6+c99SwKov3Cc8bvhrNN1rVf2OuUdDjO0gX\n\t+jNg==","X-Gm-Message-State":"AOAM532amYAm/TLrS2WTSOJ25C6L362akJH+3IHETIUs7m9CjTFs5UGL\n\tFZjwjAazukdeU6cI+QBHD9Nwkw==","X-Google-Smtp-Source":"ABdhPJw+a1MsKnjGjsAZvNrMsuhdHbkHJp4B+WAJdvo8h16xpUjM7/k9WUDaEuyiQOtGBZRqn4DfVA==","X-Received":"by 2002:a2e:b4af:: with SMTP id\n\tq15mr18985521ljm.507.1609067744844; \n\tSun, 27 Dec 2020 03:15:44 -0800 (PST)","Date":"Sun, 27 Dec 2020 12:15:33 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201223174709.45457-1-jacopo@jmondi.org>\n\t<20201223174709.45457-7-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201223174709.45457-7-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 6/6] android: camera_device: Simplify\n\tproperties.get()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]