[{"id":14350,"web_url":"https://patchwork.libcamera.org/comment/14350/","msgid":"","date":"2020-12-27T11:08:30","subject":"Re: [libcamera-devel] [PATCH 5/6] android: camera_device: Report\n\tColorFilterArrangement","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Dec 23, 2020 at 06:47:08PM +0100, Jacopo Mondi wrote:\n> Conditionally report the ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT\n> property inspecting the draft property reported by the libcamera Camera.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 9 ++++++---\n> 1 file changed, 6 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index b4618a680f41..920baab254b6 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -897,9 +897,12 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_SENSITIVITY_RANGE,\n> \t\t\t\t &sensitivityRange, 2);\n> \n> -\tuint16_t filterArr = ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT_GRBG;\n> -\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT,\n> -\t\t\t\t &filterArr, 1);\n> +\t/* Report the color filter arrangement: default it to GRBG. */\n\nI think your forgot to update the comment, as there's no default\nanymore. The code itself is fine. With this addressed,\n\nReviewed-by: Laurent Pinchart \n\n> +\tif (properties.contains(properties::draft::ColorFilterArrangement)) {\n> +\t\tuint8_t filterArr = properties.get(properties::draft::ColorFilterArrangement);\n> +\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT,\n> +\t\t\t\t\t &filterArr, 1);\n> +\t}\n> \n> \tint64_t exposureTimeRange[] = {\n> \t\t100000, 200000000,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21BD0C0F1A\n\tfor ;\n\tSun, 27 Dec 2020 11:08:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 988C661FFA;\n\tSun, 27 Dec 2020 12:08:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F0FE760526\n\tfor ;\n\tSun, 27 Dec 2020 12:08:40 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7280080B;\n\tSun, 27 Dec 2020 12:08:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SG2yTBmR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1609067320;\n\tbh=RSXAuApE8hAfkcKkkI2oGyKdfgaY4ag1+BAonnVxyC4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SG2yTBmRbirdoJe4STMEl/9xc4xknREHnsUu3Ku1uxVuu238K0aatUiLCpCVcp5lf\n\tkM919/S5t4HwjXOUzcv7JM8BVDNYhSMvo9KXQy0Dhyfov1vfw3UM5JZqR9GkEm6ViL\n\t3Xofz/GOIBMGn7R08ds7tIfkZpftuH7TAEsD5iQI=","Date":"Sun, 27 Dec 2020 13:08:30 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201223174709.45457-1-jacopo@jmondi.org>\n\t<20201223174709.45457-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201223174709.45457-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 5/6] android: camera_device: Report\n\tColorFilterArrangement","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14354,"web_url":"https://patchwork.libcamera.org/comment/14354/","msgid":"","date":"2020-12-27T11:14:22","subject":"Re: [libcamera-devel] [PATCH 5/6] android: camera_device: Report\n\tColorFilterArrangement","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-12-23 18:47:08 +0100, Jacopo Mondi wrote:\n> Conditionally report the ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT\n> property inspecting the draft property reported by the libcamera Camera.\n> \n> Signed-off-by: Jacopo Mondi \n\nWith Laurent's comment about the default value in the comment addressed,\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 9 ++++++---\n> 1 file changed, 6 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index b4618a680f41..920baab254b6 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -897,9 +897,12 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_SENSITIVITY_RANGE,\n> \t\t\t\t &sensitivityRange, 2);\n> \n> -\tuint16_t filterArr = ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT_GRBG;\n> -\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT,\n> -\t\t\t\t &filterArr, 1);\n> +\t/* Report the color filter arrangement: default it to GRBG. */\n> +\tif (properties.contains(properties::draft::ColorFilterArrangement)) {\n> +\t\tuint8_t filterArr = properties.get(properties::draft::ColorFilterArrangement);\n> +\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT,\n> +\t\t\t\t\t &filterArr, 1);\n> +\t}\n> \n> \tint64_t exposureTimeRange[] = {\n> \t\t100000, 200000000,\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34A5AC0F1B\n\tfor ;\n\tSun, 27 Dec 2020 11:14:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0258F62009;\n\tSun, 27 Dec 2020 12:14:26 +0100 (CET)","from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 44B3A615B1\n\tfor ;\n\tSun, 27 Dec 2020 12:14:25 +0100 (CET)","by mail-lf1-x144.google.com with SMTP id m25so18025744lfc.11\n\tfor ;\n\tSun, 27 Dec 2020 03:14:25 -0800 (PST)","from localhost ([185.224.57.161]) by smtp.gmail.com with ESMTPSA id\n\ts16sm6004485ljj.34.2020.12.27.03.14.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 27 Dec 2020 03:14:24 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"l6szZKrc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=Mq3Moq5G2yF/n3mXru6BmN3njrJgv67Kf8G+qJUpMZg=;\n\tb=l6szZKrc+YHwLXVbCio0zP/D3XlDiE3QxxBqCP96aSGyRjRpsvCUxAP7vHCgr9J/Io\n\t9kb/EG+Dd/B2BhMAO4cz6pB0LGyy0unKJpWDdSpgzU+IAL4S1ZoBtqdZOqnK31P/bvm9\n\tUAm3l2VvhjBqBjjOEOouiyh85YjwQbQryMP1925OR5pGJ2SbCt4mfgivIBDrnEcCDjhU\n\tiqB8EYebh+oc12k7+CBQGDBevLLo4sFjRHTV5FqVuJ2ElleTo2ZFcsthXz2Gq19hamQ1\n\tDqR8BdH73/2uKEp2ftkX+8OcoeN8AifkqH0lTZ/lRy0zzDWtERsU0VSE5s0RCKdR8xqO\n\tXsvg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=Mq3Moq5G2yF/n3mXru6BmN3njrJgv67Kf8G+qJUpMZg=;\n\tb=k+pri2YdmZDMg2KxpSvER2RULtaPEUb/v3JR2i2S9oFLdqFjd/6HVZGAwllqiJjPls\n\tgxm4RZM46ah8oiKEkY1ybBtT7XVKouN4ueUCP2F0Fknw3eH39q6YNjwHJlpoOPVcpsuW\n\tpXCrWyPOvLdryxj3ZIWH7h+mz4sHsGGYFJDtzi2thHbj7BaWQknP5zFBR/CaZs4pX9Ji\n\tFIRG2UiZlBTEzKtpsDLu+sXUnlTnZSW71Rz/NNjoTIx1Ous3O2t0x/kMeCkRUHzZIVby\n\tfeUBA+7VapXW4eJJJOa4RQ7ovvbZ7d7HfDUTggKanXP0oVoRymH+7gRrmLX8LbRxr7F4\n\tTF3w==","X-Gm-Message-State":"AOAM53375Hyf47D1Jcpo0MC/GdUSgI4Ne5/CuLxLyMT04t7TjtF+f0tl\n\tgZO6iUqhHnIV6MAlXHQHRh+CEE1AB8oYww==","X-Google-Smtp-Source":"ABdhPJwVu8gPrzDxmeB8pQA+QBK2j3TO/rroYSp30pxJPQFjSX9Y9sWQMaTePTFNq2la5UrunC1Fgg==","X-Received":"by 2002:a19:81d5:: with SMTP id\n\tc204mr18909959lfd.366.1609067664782; \n\tSun, 27 Dec 2020 03:14:24 -0800 (PST)","Date":"Sun, 27 Dec 2020 12:14:22 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201223174709.45457-1-jacopo@jmondi.org>\n\t<20201223174709.45457-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201223174709.45457-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 5/6] android: camera_device: Report\n\tColorFilterArrangement","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]