[{"id":14349,"web_url":"https://patchwork.libcamera.org/comment/14349/","msgid":"","date":"2020-12-27T11:05:25","subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: properties:\n\tColorFilterArrangement draft property","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-12-23 18:47:05 +0100, Jacopo Mondi wrote:\n> Define the 'ColorFilterArrangement' draft property. The property is\n> currently identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/property_ids.yaml | 29 +++++++++++++++++++++++++++++\n> 1 file changed, 29 insertions(+)\n> \n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index 64e88f0361d6..7f0e9c87a408 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -678,4 +678,33 @@ controls:\n> \\todo Turn this property into a \"maximum control value\" for the\n> ScalerCrop control once \"dynamic\" controls have been implemented.\n> \n> + # ----------------------------------------------------------------------------\n> + # Draft properties section\n> +\n> + - ColorFilterArrangement:\n> + type: int32_t\n> + draft: true\n> + description: |\n> + The arrangement of color filters on sensor; represents the colors in the\n> + top-left 2x2 section of the sensor, in reading order. Currently\n> + identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> + enum:\n> + - name: RGGB\n> + value: 0\n> + description: RGGB color filter arrangement\n> + - name: GRBG\n> + value: 1\n> + description: GRBG color filter arrangement\n> + - name: GBRG\n> + value: 2\n> + description: GBRG color filter arrangement\n> + - name: BGGR\n> + value: 3\n> + description: BGGR color filter arrangement\n\nHow about mentioning that these are Bayer patterns? Something like,\n\n Sensor outputs a Bayer patter in BGGR color filter arrangement.\n\n> + - name: RGB\n> + value: 4\n> + description: |\n> + Sensor is not Bayer; output has 3 16-bit values for each pixel,\n> + instead of just 1 16-bit value per pixel.\n\nShould we mention the sample size here? Something like,\n\n Sensor outputs 3 samples for each pixel, one for each RGB color \n component.\n\n> +\n> ...\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E96DC0F1B\n\tfor ;\n\tSun, 27 Dec 2020 11:05:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 049DA61FFA;\n\tSun, 27 Dec 2020 12:05:30 +0100 (CET)","from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C84D460526\n\tfor ;\n\tSun, 27 Dec 2020 12:05:28 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id m25so18000259lfc.11\n\tfor ;\n\tSun, 27 Dec 2020 03:05:28 -0800 (PST)","from localhost ([185.224.57.161]) by smtp.gmail.com with ESMTPSA id\n\ts27sm5978599ljd.25.2020.12.27.03.05.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 27 Dec 2020 03:05:27 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"O5Q2uekJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=pWSkQrcWmpjCzCos5D2jeIjcIv1dIDLjkX2edV2HZUo=;\n\tb=O5Q2uekJVeErDXxBCXNTuc+4OMD35/1/U6/wNXUCBhZjSxJihey/fxJ38zEbyI/xum\n\t7JfRhSD2zDvtLJNoYmk7OFetoPu+1bpK5lpd2aXQVi/9a+48JWGWEN6uqu6hrflkt3VU\n\tyhek8vqMZ+/41JnOGUkAJ0o1xn3h2GdlnHrSNyIhoFeRGzbVvwKbbZKBxwoODVQOK6mP\n\tsUMQbUTmb2/rPK/rnHAn8w3yhRhgcl98yZW+ZhO+3dkxISc1cXVUIzH3Z7Gh3MkRk9xp\n\tfpSeAEbIS6/zUTXhDQvmJLpvyqLMTvQj8vw56W0fxlUnoFzhxkwrRI8tf0D5R/Wks6nJ\n\tgB+A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=pWSkQrcWmpjCzCos5D2jeIjcIv1dIDLjkX2edV2HZUo=;\n\tb=Sr7dmjVfDlXP9sHDCyn28tkUb8v5V0IqfPlsgEGI3nyDCw8mvEde+ctn1kqFuy+PuO\n\t7ynYkFpuIV1k4cJjZDm9ee2i9UGilNJ/yBdUK45gGTXE5Hsfms90z/pMoefKi6QEdNnu\n\tBtLEsYcvmS9h6pcBw95RbLBnSSizD/djne7wi6uVVnvzmxm0Wv0o2OOzjxIdJ3W0mCd+\n\tmRT+rEsUxT4ueq8ppmJzdxjuewFoXq5wBTLblQ5pawM9tITAX7AESk0JtIJt4P4m+OCT\n\t6XL+ATZc/rOwRe77B6PqGrphEgxUQ6HBUpeVTjWDk1agIIWrKURo+LrFrzTrXZO9BB1m\n\tHLqA==","X-Gm-Message-State":"AOAM531RnFyAtH0GIqLTg0gNd3CL2TICKS6tRSFFthe1YsyTPKSJcloN\n\t0pxDLntiRi8LxeLvK4udLJE6fVNX33ihjw==","X-Google-Smtp-Source":"ABdhPJyyjwdSXox0064Y98aCuco0NYGwqXU8XLzK8V8wtFidXto5q6UoDuR0IcT92Gp9wigD6DEF0g==","X-Received":"by 2002:ac2:5086:: with SMTP id\n\tf6mr16754766lfm.593.1609067128219; \n\tSun, 27 Dec 2020 03:05:28 -0800 (PST)","Date":"Sun, 27 Dec 2020 12:05:25 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201223174709.45457-1-jacopo@jmondi.org>\n\t<20201223174709.45457-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201223174709.45457-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: properties:\n\tColorFilterArrangement draft property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14382,"web_url":"https://patchwork.libcamera.org/comment/14382/","msgid":"<20201228163615.gf5ssil2nsr7fqih@uno.localdomain>","date":"2020-12-28T16:36:15","subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: properties:\n\tColorFilterArrangement draft property","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nI've lost your email, so I'll reply in-line here copying your\nquestions\n\nOn Wed, Dec 23, 2020 at 06:47:05PM +0100, Jacopo Mondi wrote:\n> Define the 'ColorFilterArrangement' draft property. The property is\n> currently identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n>\n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/property_ids.yaml | 29 +++++++++++++++++++++++++++++\n> 1 file changed, 29 insertions(+)\n>\n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index 64e88f0361d6..7f0e9c87a408 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -678,4 +678,33 @@ controls:\n> \\todo Turn this property into a \"maximum control value\" for the\n> ScalerCrop control once \"dynamic\" controls have been implemented.\n>\n> + # ----------------------------------------------------------------------------\n> + # Draft properties section\n> +\n> + - ColorFilterArrangement:\n> + type: int32_t\n> + draft: true\n> + description: |\n> + The arrangement of color filters on sensor; represents the colors in the\n> + top-left 2x2 section of the sensor, in reading order. Currently\n> + identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n> + enum:\n> + - name: RGGB\n> + value: 0\n> + description: RGGB color filter arrangement\n\nNiklas:\nHow about mentioning that these are Bayer patterns? Something like,\n Sensor outputs a Bayer patter in BGGR color filter arrangement.\n\nMe:\nTo be honest I found the concept of \"output a bayer pattern in some\nfilter arrangement\" not very precise. The filters arrangement is a\nsensor construction property, which defines how the samples are then\noutput. What about just \"RGGB Bayer pattern\" ?\n\n> + - name: GRBG\n> + value: 1\n> + description: GRBG color filter arrangement\n> + - name: GBRG\n> + value: 2\n> + description: GBRG color filter arrangement\n> + - name: BGGR\n> + value: 3\n> + description: BGGR color filter arrangement\n> + - name: RGB\n> + value: 4\n> + description: |\n> + Sensor is not Bayer; output has 3 16-bit values for each pixel,\n> + instead of just 1 16-bit value per pixel.\n\nNiklas:\nShould we mention the sample size here? Something like,\n Sensor outputs 3 samples for each pixel, one for each RGB color\n component.\n\nThis comes straight from Android definition, to which this property is\ncurrently identical. I would keep it as it is and decide what to do\nwhen we undraft it.\n\nThanks\n j\n\n> +\n\n\n> ...\n> --\n> 2.29.2\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5F198C0F1B\n\tfor ;\n\tMon, 28 Dec 2020 16:36:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD0C8615B2;\n\tMon, 28 Dec 2020 17:36:02 +0100 (CET)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8425F60111\n\tfor ;\n\tMon, 28 Dec 2020 17:36:01 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 38497200005\n\tfor ;\n\tMon, 28 Dec 2020 16:36:00 +0000 (UTC)"],"Date":"Mon, 28 Dec 2020 17:36:15 +0100","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20201228163615.gf5ssil2nsr7fqih@uno.localdomain>","References":"<20201223174709.45457-1-jacopo@jmondi.org>\n\t<20201223174709.45457-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201223174709.45457-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: properties:\n\tColorFilterArrangement draft property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]