[{"id":14338,"web_url":"https://patchwork.libcamera.org/comment/14338/","msgid":"","date":"2020-12-27T10:20:44","subject":"Re: [libcamera-devel] [PATCH] libcamera: bound_method: Fix\n\tenumerators documentation","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for dealing with Doxygen.\n\nOn 2020-12-23 19:45:35 +0200, Laurent Pinchart wrote:\n> The Doxygen documentation for enumerators of the ConnectionType\n> enumeration prefixes the enumerator name with the enumeration name. For\n> unscoped enumerations, this is incorrect. Drop the scope. This fixes\n> warnings produced by Doxygen when multiple enumerators with identical\n> names are defined in different scopes.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/bound_method.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/bound_method.cpp b/src/libcamera/bound_method.cpp\n> index 9993e5969aac..4965bb5e167b 100644\n> --- a/src/libcamera/bound_method.cpp\n> +++ b/src/libcamera/bound_method.cpp\n> @@ -26,22 +26,22 @@ namespace libcamera {\n> * between a sender and a receiver. It applies to Signal::emit() and\n> * Object::invokeMethod().\n> *\n> - * \\var ConnectionType::ConnectionTypeAuto\n> + * \\var ConnectionTypeAuto\n> * \\brief If the sender and the receiver live in the same thread,\n> * ConnectionTypeDirect is used. Otherwise ConnectionTypeQueued is used.\n> *\n> - * \\var ConnectionType::ConnectionTypeDirect\n> + * \\var ConnectionTypeDirect\n> * \\brief The receiver is invoked immediately and synchronously in the sender's\n> * thread.\n> *\n> - * \\var ConnectionType::ConnectionTypeQueued\n> + * \\var ConnectionTypeQueued\n> * \\brief The receiver is invoked asynchronously\n> *\n> * Invoke the receiver asynchronously in its thread when control returns to the\n> * thread's event loop. The sender proceeds without waiting for the invocation\n> * to complete.\n> *\n> - * \\var ConnectionType::ConnectionTypeBlocking\n> + * \\var ConnectionTypeBlocking\n> * \\brief The receiver is invoked synchronously\n> *\n> * If the sender and the receiver live in the same thread, this is equivalent to\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50209C0F1B\n\tfor ;\n\tSun, 27 Dec 2020 10:20:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3F3C615B1;\n\tSun, 27 Dec 2020 11:20:57 +0100 (CET)","from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 57CD560528\n\tfor ;\n\tSun, 27 Dec 2020 11:20:56 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id o19so17998624lfo.1\n\tfor ;\n\tSun, 27 Dec 2020 02:20:56 -0800 (PST)","from localhost ([185.224.57.161]) by smtp.gmail.com with ESMTPSA id\n\tn18sm4965819lfh.37.2020.12.27.02.20.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 27 Dec 2020 02:20:55 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"ccT9VTHa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=PBRo20NqMk6SlWD3PX2fII7yrFIspPfJvtwTQm2cOd8=;\n\tb=ccT9VTHaSOEmi1dLtclF4o4X+T9BKT8pSfQIlMlzvo2ETK12F/MPdkx0DjaaAlODOi\n\tujSq1Bo2n0UIhJDCulhdxpyOQoYQOJfYGhqz3M1ROOVx/867Ctvsos3ODs9Yx3vCtgEi\n\tKfTd/V9ShCx5vlnwlXEfK4HFr3hukMQTFj8Adn6waOYkozO62ww/Yk9xbt4r+uYUg7gF\n\t/OEgH326P4ty/qLPE7h9pFgJ+yxpp7i85YBk3cNYkfbqC1FCehAbIXfAw89OWT52mrS/\n\tlpZa3fBfhBc4C2h09Y/XcDpGiEU7M6TeNiQCxrmK7qzWXxSKsExSJUyhi41TZ3lny9hJ\n\t0MQw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=PBRo20NqMk6SlWD3PX2fII7yrFIspPfJvtwTQm2cOd8=;\n\tb=BfiTyj5jhHA71tgeIw4XdtnaFZYKHDRuFrUCmQ1iJnK/X6eDYbkxDhemTaXGDzeJmd\n\txnG5Yqg9OjXO/lcQWYlmbCQcICd3xrAOy8yFXJ/ePXNoRamhe5pTPR/S+3iWkcQlifLX\n\tPfw3/+wWYd/EYo7T/bOF8fS75hG5wR7GfnKTIfKkdFmb3YU6BN0KSBeBL6hwjHCZuZQN\n\t6MxHEiKGG/6iwx4JrxHk2ndh/LeSBXVcPa8GsB00EqBH9Co5nA95VtsQUsCJQ4OzyHAL\n\tf/qOhx3uTPDiiBTKxmppFKxCwaPFTtHS6Eq8QArsX+WnrGkSJ7qIXSzaU/KbWGZdchyc\n\t1wGA==","X-Gm-Message-State":"AOAM531/cBnQOWsl6E/YVeKtbPPvGenWfKnHlX+NYo7utTjIW9UYz0ow\n\tB3LvGcWzN9kPLUkRwdofKvmWTsMK+h2a2A==","X-Google-Smtp-Source":"ABdhPJzHUIAByJOHTVedqwJlFH/sHr+qA+sb+kyy9i38nteOb45sw27bGaWMbZ7V2kvOhhXoYfESYQ==","X-Received":"by 2002:a2e:98d9:: with SMTP id\n\ts25mr18274990ljj.476.1609064455768; \n\tSun, 27 Dec 2020 02:20:55 -0800 (PST)","Date":"Sun, 27 Dec 2020 11:20:44 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20201223174535.23977-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201223174535.23977-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: bound_method: Fix\n\tenumerators documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]