[{"id":14323,"web_url":"https://patchwork.libcamera.org/comment/14323/","msgid":"<20201223171840.dchxj7epazsdiiwc@uno.localdomain>","date":"2020-12-23T17:18:40","subject":"Re: [libcamera-devel] [PATCH] utils: gen-controls: Fix enumerators\n\tdocumentation","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Tue, Dec 22, 2020 at 06:15:26PM +0200, Laurent Pinchart wrote:\n> The Doxygen documentation for enumerators prefixes the enumerator name\n> with the enumeration name. For unscoped enumerations, this is incorrect.\n> Drop the scope. This fixes warnings produced by Doxygen when multiple\n> enumerators with identical names are defined in different scopes.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> utils/gen-controls.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> Jacopo, I believe this should fix the issue you've experienced in your\n> camera sensor database series.\n>\n\nIt does!\nHowever, why the heck the issue presented itself only with 4 letters\nidentifiers ?\n\nThe patch is however good!\n\nTested-by: Jacopo Mondi \n\nThanks\n j\n\n> diff --git a/utils/gen-controls.py b/utils/gen-controls.py\n> index 12a32eaaeee9..3f99b5e2ba7d 100755\n> --- a/utils/gen-controls.py\n> +++ b/utils/gen-controls.py\n> @@ -26,7 +26,7 @@ def generate_cpp(controls):\n> enum_doc_start_template = string.Template('''/**\n> * \\\\enum ${name}Enum\n> * \\\\brief Supported ${name} values''')\n> - enum_doc_value_template = string.Template(''' * \\\\var ${name}Enum::${value}\n> + enum_doc_value_template = string.Template(''' * \\\\var ${value}\n> ${description}''')\n> doc_template = string.Template('''/**\n> * \\\\var ${name}\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E5E0C0F1A\n\tfor ;\n\tWed, 23 Dec 2020 17:18:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 168E3615AC;\n\tWed, 23 Dec 2020 18:18:30 +0100 (CET)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E022A60527\n\tfor ;\n\tWed, 23 Dec 2020 18:18:28 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 5FB21FF803;\n\tWed, 23 Dec 2020 17:18:28 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 23 Dec 2020 18:18:40 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20201223171840.dchxj7epazsdiiwc@uno.localdomain>","References":"<20201222161526.13841-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201222161526.13841-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] utils: gen-controls: Fix enumerators\n\tdocumentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14324,"web_url":"https://patchwork.libcamera.org/comment/14324/","msgid":"","date":"2020-12-23T17:38:06","subject":"Re: [libcamera-devel] [PATCH] utils: gen-controls: Fix enumerators\n\tdocumentation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Wed, Dec 23, 2020 at 06:18:40PM +0100, Jacopo Mondi wrote:\n> On Tue, Dec 22, 2020 at 06:15:26PM +0200, Laurent Pinchart wrote:\n> > The Doxygen documentation for enumerators prefixes the enumerator name\n> > with the enumeration name. For unscoped enumerations, this is incorrect.\n> > Drop the scope. This fixes warnings produced by Doxygen when multiple\n> > enumerators with identical names are defined in different scopes.\n> >\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > utils/gen-controls.py | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > Jacopo, I believe this should fix the issue you've experienced in your\n> > camera sensor database series.\n> >\n> \n> It does!\n> However, why the heck the issue presented itself only with 4 letters\n> identifiers ?\n\nIt's not the length that matters, but the fact there's another enum with\nthe same enumerators (in the BayerFormat class).\n\n> The patch is however good!\n> \n> Tested-by: Jacopo Mondi \n> \n> > diff --git a/utils/gen-controls.py b/utils/gen-controls.py\n> > index 12a32eaaeee9..3f99b5e2ba7d 100755\n> > --- a/utils/gen-controls.py\n> > +++ b/utils/gen-controls.py\n> > @@ -26,7 +26,7 @@ def generate_cpp(controls):\n> > enum_doc_start_template = string.Template('''/**\n> > * \\\\enum ${name}Enum\n> > * \\\\brief Supported ${name} values''')\n> > - enum_doc_value_template = string.Template(''' * \\\\var ${name}Enum::${value}\n> > + enum_doc_value_template = string.Template(''' * \\\\var ${value}\n> > ${description}''')\n> > doc_template = string.Template('''/**\n> > * \\\\var ${name}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3D376C0F1B\n\tfor ;\n\tWed, 23 Dec 2020 17:38:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B0F7D615AC;\n\tWed, 23 Dec 2020 18:38:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6888460527\n\tfor ;\n\tWed, 23 Dec 2020 18:38:15 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DC48A9E6;\n\tWed, 23 Dec 2020 18:38:14 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DkDy+k9D\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608745095;\n\tbh=53/JI98C5U2Lr7TepdzH6t7m3jUCnoxDAhoE4465mYk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DkDy+k9DR5osit3436Hi+nuBudnYxEq5nBqzrEB5DKCKhlv/z641G2KT0cPjKYeEJ\n\t77gUSGrn427koZFHUm+S5sU17begqYylr7A2zMXvt8eYelwwcLvzh+lBtml4KjAvAI\n\tZaI8E8A71JOy+gHTVnH5GjFAtVxYxAEUs5/EAgHM=","Date":"Wed, 23 Dec 2020 19:38:06 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201222161526.13841-1-laurent.pinchart@ideasonboard.com>\n\t<20201223171840.dchxj7epazsdiiwc@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201223171840.dchxj7epazsdiiwc@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH] utils: gen-controls: Fix enumerators\n\tdocumentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14337,"web_url":"https://patchwork.libcamera.org/comment/14337/","msgid":"","date":"2020-12-27T10:16:59","subject":"Re: [libcamera-devel] [PATCH] utils: gen-controls: Fix enumerators\n\tdocumentation","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-12-22 18:15:26 +0200, Laurent Pinchart wrote:\n> The Doxygen documentation for enumerators prefixes the enumerator name\n> with the enumeration name. For unscoped enumerations, this is incorrect.\n> Drop the scope. This fixes warnings produced by Doxygen when multiple\n> enumerators with identical names are defined in different scopes.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> utils/gen-controls.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> Jacopo, I believe this should fix the issue you've experienced in your\n> camera sensor database series.\n> \n> diff --git a/utils/gen-controls.py b/utils/gen-controls.py\n> index 12a32eaaeee9..3f99b5e2ba7d 100755\n> --- a/utils/gen-controls.py\n> +++ b/utils/gen-controls.py\n> @@ -26,7 +26,7 @@ def generate_cpp(controls):\n> enum_doc_start_template = string.Template('''/**\n> * \\\\enum ${name}Enum\n> * \\\\brief Supported ${name} values''')\n> - enum_doc_value_template = string.Template(''' * \\\\var ${name}Enum::${value}\n> + enum_doc_value_template = string.Template(''' * \\\\var ${value}\n> ${description}''')\n> doc_template = string.Template('''/**\n> * \\\\var ${name}\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C7A7CC0F1A\n\tfor ;\n\tSun, 27 Dec 2020 10:17:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3DD23615B0;\n\tSun, 27 Dec 2020 11:17:06 +0100 (CET)","from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84E2A60525\n\tfor ;\n\tSun, 27 Dec 2020 11:17:05 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id s26so17893550lfc.8\n\tfor ;\n\tSun, 27 Dec 2020 02:17:05 -0800 (PST)","from localhost ([185.224.57.161]) by smtp.gmail.com with ESMTPSA id\n\tr16sm5996999ljj.52.2020.12.27.02.17.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 27 Dec 2020 02:17:04 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"yJRZAxdG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=VsQxfZsAlDBiUL94vZ1gjz88dZyyqB8fW7Uo4bex5Dk=;\n\tb=yJRZAxdGtVxxX3ThAXQISMvvS/0/wBtS9eU5p6G6iVqBd/UTjmwRQ6OnGi3GqO25tL\n\tBP8jYkJoe/4Xaa7ctU7KNfBHKDItOvDj9sDde/QQBiwsx4nYHHm0SOuRlAMuFsWZJNsA\n\tbFRPqG8L8Ieq8VJak2I0s/CccL/6/8qe95sawHIqOGr3GuvWp28oDb8tTa/k+sdc3NO5\n\tExrS0y4jslWS42xOygdLwCiwuiHqoC9is0PyYwg3JO3SXjZDwP9xUHl3xIwB65rAAlKc\n\tpRDRniHaQnDUOMc+q5EtkWxemZ9nqrxiG4vpNI+W01WK6NbXrv+bDiH3rH7zBRACY0uG\n\tGfhg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=VsQxfZsAlDBiUL94vZ1gjz88dZyyqB8fW7Uo4bex5Dk=;\n\tb=YJeGw6a56bryJSYu1acdozoAh83Nt5Oz3G1QjR1cxdJO7+OdegUIXGgjSDDjmfcAC1\n\txgui5WmXpVrSQV5bDLHCn7AfTl2hw36lMo5z8VLH02lKkmyc/TaRhYp+41Plk/EOmeAx\n\t9peVLzpZYZPISePXYRUgqt/DR/LQmHSCELci3PBrTc8baFdy1OTOWe5g2JWUC9opwaqP\n\toNIIyCckc3tXCZg7KGFtqEuk8F3U410H4Qybn7TFDZe4OoLRT594MMUWKrL6VrexeMBZ\n\t35MBX83mD3VvkBNHguvut/kPc0Ga+lo/quOU5e0wg4p7cYqULWtGCkaAXYt1FfB/12kq\n\te7Hg==","X-Gm-Message-State":"AOAM530fYmsgpayT3krL6V3heE/GigKQpJZKDQ/0H//YRe8vmgaefERU\n\tE43wDOwwBsaDQVNCNV0PPjNwNQL4XtA4Bg==","X-Google-Smtp-Source":"ABdhPJx+qAFLsU8lrWqWjZt7zg7UNOV0wbY5tdyEFqc3RpvOWjuTsgvYqcobDA9cpMM9R3Rt0BMGgg==","X-Received":"by 2002:a2e:9bda:: with SMTP id\n\tw26mr20876691ljj.332.1609064224952; \n\tSun, 27 Dec 2020 02:17:04 -0800 (PST)","Date":"Sun, 27 Dec 2020 11:16:59 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20201222161526.13841-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201222161526.13841-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] utils: gen-controls: Fix enumerators\n\tdocumentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]