[{"id":14309,"web_url":"https://patchwork.libcamera.org/comment/14309/","msgid":"","date":"2020-12-22T15:57:27","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: file: Check files\n\texist()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Dec 22, 2020 at 01:58:49PM +0000, Kieran Bingham wrote:\n> Ensure that when we check for existence with File() it will only\n> return if the path leads to a file, and not a directory.\n> \n> Device nodes which could still be opened by this class are still supported.\n\nSometimes I wonder if text editors also have their moments of\ninattention and forget to wrap some lines :-)\n\n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/file.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp\n> index 3a3f5bb63ffc..bce2b6138239 100644\n> --- a/src/libcamera/file.cpp\n> +++ b/src/libcamera/file.cpp\n> @@ -458,7 +458,8 @@ bool File::exists(const std::string &name)\n> \tif (ret < 0)\n> \t\treturn false;\n> \n> -\treturn true;\n> +\t/* Directories can not be handled here, even if they exist. */\n> +\treturn !S_ISDIR(st.st_mode);\n\nI initially thought that we would still return true for a symlink\npointing to a directory, but stat() dereferences symlinks, so I think\nwe're good.\n\nReviewed-by: Laurent Pinchart \n\n> }\n> \n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1693FC0F1B\n\tfor ;\n\tTue, 22 Dec 2020 15:57:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 723CF615AC;\n\tTue, 22 Dec 2020 16:57:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B4E860528\n\tfor ;\n\tTue, 22 Dec 2020 16:57:35 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E67D02CF;\n\tTue, 22 Dec 2020 16:57:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Bs6utaZu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608652655;\n\tbh=58gCGO4+Yv/amAvyUmJoKMuvRqOa7/eycHnPdDrQuYQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Bs6utaZucg48C/FWqtp80gJ3pOvH63DzVsN4dly818M/4XnXciM4NDUdyWOA2yoWn\n\tqR+FQt1oPAKjW1KYWRFgVX0lSn2zp3K0IhYUQAG0BrO1M+S+vM7rieXQcF0LKTruth\n\th5v9YZ+CtII/9ddERbUJWVkNqz1qwZoQ92B6usXE=","Date":"Tue, 22 Dec 2020 17:57:27 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20201222135849.38052-1-kieran.bingham@ideasonboard.com>\n\t<20201222135849.38052-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201222135849.38052-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: file: Check files\n\texist()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14311,"web_url":"https://patchwork.libcamera.org/comment/14311/","msgid":"<1b5db669-cafe-a240-981b-90b58dbfdec0@ideasonboard.com>","date":"2020-12-22T17:11:00","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: file: Check files\n\texist()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 22/12/2020 15:57, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Tue, Dec 22, 2020 at 01:58:49PM +0000, Kieran Bingham wrote:\n>> Ensure that when we check for existence with File() it will only\n>> return if the path leads to a file, and not a directory.\n>>\n>> Device nodes which could still be opened by this class are still supported.\n\nAh, I write most of my commit messages on the command line - git commit\n-m \"...\"\n\nI'll wrap before pushing.\n\nThanks\n\nKieran\n\n\n> \n> Sometimes I wonder if text editors also have their moments of\n> inattention and forget to wrap some lines :-)\n> \n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/libcamera/file.cpp | 3 ++-\n>> 1 file changed, 2 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp\n>> index 3a3f5bb63ffc..bce2b6138239 100644\n>> --- a/src/libcamera/file.cpp\n>> +++ b/src/libcamera/file.cpp\n>> @@ -458,7 +458,8 @@ bool File::exists(const std::string &name)\n>> \tif (ret < 0)\n>> \t\treturn false;\n>> \n>> -\treturn true;\n>> +\t/* Directories can not be handled here, even if they exist. */\n>> +\treturn !S_ISDIR(st.st_mode);\n> \n> I initially thought that we would still return true for a symlink\n> pointing to a directory, but stat() dereferences symlinks, so I think\n> we're good.\n> \n> Reviewed-by: Laurent Pinchart \n> \n>> }\n>> \n>> } /* namespace libcamera */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C887FC0F1B\n\tfor ;\n\tTue, 22 Dec 2020 17:11:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 534066158A;\n\tTue, 22 Dec 2020 18:11:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A6F6060528\n\tfor ;\n\tTue, 22 Dec 2020 18:11:04 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1CDBC9E6;\n\tTue, 22 Dec 2020 18:11:04 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SfjqecZn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608657064;\n\tbh=gPBF69rM1tTOFDxb02HRsxKzS7/o8B/1p6Zl46ks6Ao=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=SfjqecZnS3vsuBpDSFKcuKoouwODPVkSOT5c4hp/ZMauvRBpRWRCcmapNJbgSXrxP\n\tNTJSVNHxQZHpYOl85df/rD6H6oRaUdul0sr2fPARm4t1E0yXIoJdokGruTVbzenc4F\n\tmrJme6fOeZIPaW90OUMkqLk+BuYpVpVVzxnNbb6k=","To":"Laurent Pinchart ","References":"<20201222135849.38052-1-kieran.bingham@ideasonboard.com>\n\t<20201222135849.38052-3-kieran.bingham@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<1b5db669-cafe-a240-981b-90b58dbfdec0@ideasonboard.com>","Date":"Tue, 22 Dec 2020 17:11:00 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: file: Check files\n\texist()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14312,"web_url":"https://patchwork.libcamera.org/comment/14312/","msgid":"<20201222175516.5ut7zhtl2hifg5qf@basti.Speedport_W_724V_Typ_A_05011603_06_001>","date":"2020-12-22T17:55:16","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: file: Check files\n\texist()","submitter":{"id":73,"url":"https://patchwork.libcamera.org/api/people/73/","name":"Sebastian Fricke","email":"sebastian.fricke.linux@gmail.com"},"content":"On 22.12.2020 17:57, Laurent Pinchart wrote:\n>Hi Kieran,\n>\n>Thank you for the patch.\n>\n>On Tue, Dec 22, 2020 at 01:58:49PM +0000, Kieran Bingham wrote:\n>> Ensure that when we check for existence with File() it will only\n>> return if the path leads to a file, and not a directory.\n>>\n>> Device nodes which could still be opened by this class are still supported.\n>\n>Sometimes I wonder if text editors also have their moments of\n>inattention and forget to wrap some lines :-)\n\nI noticed that this can happen when I paste some long line from the\nsystem clipboard into VIM. In that case it doesn't automatically wrap\nthe text.\n\n>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/libcamera/file.cpp | 3 ++-\n>> 1 file changed, 2 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp\n>> index 3a3f5bb63ffc..bce2b6138239 100644\n>> --- a/src/libcamera/file.cpp\n>> +++ b/src/libcamera/file.cpp\n>> @@ -458,7 +458,8 @@ bool File::exists(const std::string &name)\n>> \tif (ret < 0)\n>> \t\treturn false;\n>>\n>> -\treturn true;\n>> +\t/* Directories can not be handled here, even if they exist. */\n>> +\treturn !S_ISDIR(st.st_mode);\n>\n>I initially thought that we would still return true for a symlink\n>pointing to a directory, but stat() dereferences symlinks, so I think\n>we're good.\n>\n>Reviewed-by: Laurent Pinchart \n>\n>> }\n>>\n>> } /* namespace libcamera */\n>\n>-- \n>Regards,\n>\n>Laurent Pinchart\n>_______________________________________________\n>libcamera-devel mailing list\n>libcamera-devel@lists.libcamera.org\n>https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60646C0F1A\n\tfor ;\n\tTue, 22 Dec 2020 17:55:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DEF5D615B0;\n\tTue, 22 Dec 2020 18:55:19 +0100 (CET)","from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1FE760528\n\tfor ;\n\tTue, 22 Dec 2020 18:55:18 +0100 (CET)","by mail-wm1-x32e.google.com with SMTP id k10so2552293wmi.3\n\tfor ;\n\tTue, 22 Dec 2020 09:55:18 -0800 (PST)","from localhost\n\t(p200300d1ff197700ac8d74e18e88e434.dip0.t-ipconnect.de.\n\t[2003:d1:ff19:7700:ac8d:74e1:8e88:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tn17sm27267753wmc.33.2020.12.22.09.55.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Dec 2020 09:55:18 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"MDZ9WGKW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=1oqAEkgrxcXo9ZoBIfCx+7vyYwrS39St010hJqUbvwc=;\n\tb=MDZ9WGKWFVf9bFbVr2t8OYXxaOkkAp11oytgcyQJTi+XoZaBp8y+xzw+c+dFgNKSDU\n\t9uWeikypOS2R9YSu7GQxS7CQhFsW+VIOpnLhelRg/fBUIsfkhT8YRaopvcFhnq203VjR\n\tGNNKzf7EsO0sg89Y7TCE0ZQ5tWook5FWFs3kLU/ciAnGMxUy2PjmN7Gf3KjmC0gxAzbk\n\tLCoLAYAD460F/GqxaMurA0v5zR7LsaYzyP+1kKwiZ+h+tt8kN9pIDKNLwUMYX3dW8npy\n\tAxY+KrG+LrVQbDehPZOmZ2099FCYFAKPpRSUiE9sPdDJvcO5IbF59BGzk10GRp88GSCJ\n\tzhFw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=1oqAEkgrxcXo9ZoBIfCx+7vyYwrS39St010hJqUbvwc=;\n\tb=Z74SkNRr5zLCBhuiOKDOPtZognC2PNRRAubv73ZXyTXZsLjMluEEE2INhN5GDntZYg\n\txqUleJnsu/XsxHmyl83W7QZ6oSigwbyeQ7VcjGaLW3RDTbQH8YL/SZQeRxxux+7nYnsp\n\tTDTf7yB65tEn/NNwx+I0UFSMVi3SdHp1xC2e35kRCEXmOJnZCt0w8CzTAzAHIgY2F79b\n\tr8YIdzgxMB1gkZHJZTQkpDkqE5Axd3gGNmCrp8dE1gIGGRvd9V41fmV0pez4Eh0El3eg\n\tVcGfxN5WDar7oqBcj+fsf9lV1uQvA/8wPdYEooSCq/aimuP7D66PoepInyc0kY40ek0i\n\tiSUA==","X-Gm-Message-State":"AOAM530iXxXMatevhFa0euDvIDGhRobb8gBhF0DPUFTdpTB1XpZOxl6C\n\tu/xQYOqOdrE6w8YDOZKe3VA=","X-Google-Smtp-Source":"ABdhPJwnTKp5DW1JzfMquPsYK9ZKobdNY7q9zYn5jFTaVd1dftLAeHYsJdOnyZp6DlArgcTr4VTnjA==","X-Received":"by 2002:a1c:9692:: with SMTP id\n\ty140mr16738558wmd.128.1608659718510; \n\tTue, 22 Dec 2020 09:55:18 -0800 (PST)","Date":"Tue, 22 Dec 2020 18:55:16 +0100","From":"Sebastian Fricke ","To":"Laurent Pinchart ","Message-ID":"<20201222175516.5ut7zhtl2hifg5qf@basti.Speedport_W_724V_Typ_A_05011603_06_001>","References":"<20201222135849.38052-1-kieran.bingham@ideasonboard.com>\n\t<20201222135849.38052-3-kieran.bingham@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: file: Check files\n\texist()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14348,"web_url":"https://patchwork.libcamera.org/comment/14348/","msgid":"","date":"2020-12-27T10:54:05","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: file: Check files\n\texist()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2020-12-22 13:58:49 +0000, Kieran Bingham wrote:\n> Ensure that when we check for existence with File() it will only\n> return if the path leads to a file, and not a directory.\n> \n> Device nodes which could still be opened by this class are still supported.\n> \n> Signed-off-by: Kieran Bingham \n\nWith the long line already pointed out fixed,\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/file.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp\n> index 3a3f5bb63ffc..bce2b6138239 100644\n> --- a/src/libcamera/file.cpp\n> +++ b/src/libcamera/file.cpp\n> @@ -458,7 +458,8 @@ bool File::exists(const std::string &name)\n> \tif (ret < 0)\n> \t\treturn false;\n> \n> -\treturn true;\n> +\t/* Directories can not be handled here, even if they exist. */\n> +\treturn !S_ISDIR(st.st_mode);\n> }\n> \n> } /* namespace libcamera */\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB506C0F1B\n\tfor ;\n\tSun, 27 Dec 2020 10:54:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A504D62006;\n\tSun, 27 Dec 2020 11:54:16 +0100 (CET)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B1A48615B0\n\tfor ;\n\tSun, 27 Dec 2020 11:54:15 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id h22so18095578lfu.2\n\tfor ;\n\tSun, 27 Dec 2020 02:54:15 -0800 (PST)","from localhost ([185.224.57.161]) by smtp.gmail.com with ESMTPSA id\n\tt4sm5019246lff.260.2020.12.27.02.54.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 27 Dec 2020 02:54:14 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"L1de1UUw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=xYx89LOl+uMv+bALYGg20mRtbhJJ3kK+D1+GCMAv18M=;\n\tb=L1de1UUwDRsjC0J3MFOtBA+o3gUyFBuDaY+4xZWP0C3XlUk7XRRuQQPj3pmsztkVvY\n\toXw+qgN97ydtpG172BLapTCaOPCXtkh/YPg4TGr682Gl2Wg89u98rX138EKr1p/qoVdV\n\tDUzdGIBTtASLeZ5m16vuMdL8GcJlJO9snUEFQudy6lUhMyT1FBQbO4XTPdGyWHr577Sy\n\te/uwXIMLcVK6YlpxwEzHK0MkezLnv3TkyuUjH+/GLpsf3rzEFTrl6Fuh7Dio6et2XynK\n\tvefMv7FXy3LJOvPi2ezRuFyc0j5pvwV+LwaCsHrNPk0lGgpSfFoMsiKqWET457gpGABG\n\tc5fQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=xYx89LOl+uMv+bALYGg20mRtbhJJ3kK+D1+GCMAv18M=;\n\tb=c9FxyMCa9veJ0umT8EYIoj+dy7QQMXqwO53Ihtv9onWquYzWKlbNMC02+2H161kpQK\n\txuLIYfmgZ265bNldcOfDhy0osaB6bnKpgk+NoML07z4IpTH5UJMWmo3mM4G/btrW+ADI\n\tVezgthTd32XgUzj7MnxXA+mEMpjKlKbT/HldIqHJZqdLS48kENGe+UZMlqbzCLHGheo4\n\teGfsV9q92tQu1MyQFFW9FvbiBzRpZ8U6JnbxIiSERysYS18WUZSbgXEzHHsNY/pfsYi4\n\tsU1ovsvoN9g+BZ+F/wSYzwvIFKV6VfKcyzxR53IX8BKel8SODg3mr3NrolOj94JKPW9C\n\tFXTA==","X-Gm-Message-State":"AOAM530TqfXm6hgbFuHlkZNjXyiitNbsrHOakMUbMovQNnzr2gqOu9yn\n\tkh/DBRyqheYXgLFiNZz2V2kL3euWZUXfpQ==","X-Google-Smtp-Source":"ABdhPJyHmtD1O6eQX4mOEhaIscjfwp/rAA0GawFGvGOMR0/sZnbQR4IEtMEPbVjW0viv91F0hmbfHA==","X-Received":"by 2002:a2e:9849:: with SMTP id\n\te9mr20410396ljj.319.1609066455233; \n\tSun, 27 Dec 2020 02:54:15 -0800 (PST)","Date":"Sun, 27 Dec 2020 11:54:05 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Message-ID":"","References":"<20201222135849.38052-1-kieran.bingham@ideasonboard.com>\n\t<20201222135849.38052-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201222135849.38052-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: file: Check files\n\texist()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]