[{"id":14308,"web_url":"https://patchwork.libcamera.org/comment/14308/","msgid":"","date":"2020-12-22T15:51:43","subject":"Re: [libcamera-devel] [PATCH 1/2] test: file: Check that\n\tdirectories are not treated as files","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Dec 22, 2020 at 01:58:48PM +0000, Kieran Bingham wrote:\n> Directories can not be opened as a file, so the exists() check should\n> not return true for a path which points to a directory.\n> \n> Directories are not handled by the File class.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/file.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/test/file.cpp b/test/file.cpp\n> index f458f355ccad..b80667ae5b2f 100644\n> --- a/test/file.cpp\n> +++ b/test/file.cpp\n> @@ -49,6 +49,11 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\tif (File::exists(\"/dev\")) {\n> +\t\t\tcerr << \"Directories should not be treated as files\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\t/* Test unnamed file. */\n> \t\tFile file;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E202C0F1A\n\tfor ;\n\tTue, 22 Dec 2020 15:51:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A80BE6158A;\n\tTue, 22 Dec 2020 16:51:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A23B160528\n\tfor ;\n\tTue, 22 Dec 2020 16:51:51 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F5CD2CF;\n\tTue, 22 Dec 2020 16:51:51 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OY6Xn+hy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608652311;\n\tbh=zVZ4OTp48xqPJsZB6tiHRjeJPYrNqOqVXxNqtbb/B6s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OY6Xn+hy5+koAmRYtjjY1CJO8ulkRq235aRQIwtt4UuP6rBb0M/cHMOcyzqZG0po7\n\tkNqX7040Ylv7rHDrue3xp751mD7ew30WB/MGlvIHZCPM6QaGvnHlYxAfFAEFcQ7+F0\n\tmagfVi6qhz7xjjKEOE65UsDex7r1LZ87zO+fWfiQ=","Date":"Tue, 22 Dec 2020 17:51:43 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20201222135849.38052-1-kieran.bingham@ideasonboard.com>\n\t<20201222135849.38052-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201222135849.38052-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] test: file: Check that\n\tdirectories are not treated as files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14347,"web_url":"https://patchwork.libcamera.org/comment/14347/","msgid":"","date":"2020-12-27T10:53:28","subject":"Re: [libcamera-devel] [PATCH 1/2] test: file: Check that\n\tdirectories are not treated as files","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2020-12-22 13:58:48 +0000, Kieran Bingham wrote:\n> Directories can not be opened as a file, so the exists() check should\n> not return true for a path which points to a directory.\n> \n> Directories are not handled by the File class.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> test/file.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/test/file.cpp b/test/file.cpp\n> index f458f355ccad..b80667ae5b2f 100644\n> --- a/test/file.cpp\n> +++ b/test/file.cpp\n> @@ -49,6 +49,11 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\tif (File::exists(\"/dev\")) {\n> +\t\t\tcerr << \"Directories should not be treated as files\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\t/* Test unnamed file. */\n> \t\tFile file;\n> \n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79DB0C0F1B\n\tfor ;\n\tSun, 27 Dec 2020 10:53:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 47DD4615B4;\n\tSun, 27 Dec 2020 11:53:32 +0100 (CET)","from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 93A00615AC\n\tfor ;\n\tSun, 27 Dec 2020 11:53:31 +0100 (CET)","by mail-lf1-x143.google.com with SMTP id m12so18020092lfo.7\n\tfor ;\n\tSun, 27 Dec 2020 02:53:31 -0800 (PST)","from localhost ([185.224.57.161]) by smtp.gmail.com with ESMTPSA id\n\tq13sm4985883lfk.251.2020.12.27.02.53.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 27 Dec 2020 02:53:29 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"eLkC7QnN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=S1eLsOYVIyg4rqTPDEjba/iN5z+y5Wa02f6QfW3Zyt0=;\n\tb=eLkC7QnNEIHS1WSxx1J8o2UXahovQ/M9swwWTAwxqTh1fBmBsGQ9sSN4Ep65HNKS09\n\tLO3InnbD6xbfeVWjxU9DJ/piZ1Go+/XnKfFibbgPU64Jin/VPOqgSpWJ5Jb4AZDceOD2\n\tunK4OVhCiENY3ikxETnDcxv+EAytXJwI45HvdpdKdgRKj1UXXsFO8qcJOEsaS9IYGOwm\n\tfRFL4COH6NHx3Gc7MDmn6yNKt5bL5S3eIchJ4NnMUmk0b3HzQEupBJ3/iu8gkYR8U9gB\n\tew4Suvg+iYBRYVqX8InKpxP10pWRs5bg1CNM4oQPiV/VN/eIg25YfO42yVh7maoGMyKV\n\tSctQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=S1eLsOYVIyg4rqTPDEjba/iN5z+y5Wa02f6QfW3Zyt0=;\n\tb=qUCD6AelCRi1Ev5CtJsEqPV1OHJ0mItbLoCRRdPMG9vmaSheGZKiSHHGtXbUvA4Ozp\n\tY6D3IplK1Q+t66XN3mIviFyjLqQlnXUDXr/FZqDprNcWF9RPbWxBRtMWhvp8QmSubz1Z\n\tSZ0EoJoELgxsHdiLyLHbULOLqFHWjzJIz1VrqV0Tdh1kWei9M3Yu7ZKgk6WSItfoAKfp\n\tuSQdu1qrkNKulcVztIBLSTH56oADLmuRg6DUrRkzpq7FQE5az0O9iKmRW2fhb3XcYkNY\n\txQOw2kUJkUhKGKD6dx9OQ8zLJulxlJ06pwCcMlojKcZyKBvlj9RQyZ+qrEV57IuR393/\n\tM7Ng==","X-Gm-Message-State":"AOAM531tEA8YEJVffaRIq9R29uxf8j2ShNh8FoE5wfh9zV65sTl+rf6k\n\tNFlpzMQcWyQYjSMYX9T2DcaDRw==","X-Google-Smtp-Source":"ABdhPJz1OYT3yxx9sm+ou+7O5LT0XVJnqsqWE6CplCll3GIuEZu6g0DqO11v0HW7LfzUNKN9AWNkgw==","X-Received":"by 2002:a2e:81cb:: with SMTP id\n\ts11mr19663206ljg.377.1609066411120; \n\tSun, 27 Dec 2020 02:53:31 -0800 (PST)","Date":"Sun, 27 Dec 2020 11:53:28 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Message-ID":"","References":"<20201222135849.38052-1-kieran.bingham@ideasonboard.com>\n\t<20201222135849.38052-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201222135849.38052-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] test: file: Check that\n\tdirectories are not treated as files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]