[{"id":14303,"web_url":"https://patchwork.libcamera.org/comment/14303/","msgid":"","date":"2020-12-22T07:55:45","subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: pipeline_handler:\n\tRemove Camera pointer from CameraData","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Dec 22, 2020 at 12:53:45AM +0100, Niklas Söderlund wrote:\n> There are no users left of this field, drop it.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/internal/pipeline_handler.h | 1 -\n> src/libcamera/pipeline_handler.cpp | 11 -----------\n> 2 files changed, 12 deletions(-)\n> \n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index 5f9a26be1f7a9e9e..0748f86346084e2d 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -42,7 +42,6 @@ public:\n> \t}\n> \tvirtual ~CameraData() = default;\n> \n> -\tCamera *camera_;\n> \tPipelineHandler *pipe_;\n> \tstd::list queuedRequests_;\n> \tControlInfoMap controlInfo_;\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 26d6c07d2d6e69e9..c2604d4561124186 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -60,16 +60,6 @@ LOG_DEFINE_CATEGORY(Pipeline)\n> * exists.\n> */\n> \n> -/**\n> - * \\var CameraData::camera_\n> - * \\brief The camera related to this CameraData instance\n> - *\n> - * The camera_ pointer provides access to the Camera object that this instance\n> - * is related to. It is set when the Camera is registered with\n> - * PipelineHandler::registerCamera() and remains valid until the CameraData\n> - * instance is destroyed.\n> - */\n> -\n> /**\n> * \\var CameraData::pipe_\n> * \\brief The pipeline handler related to this CameraData instance\n> @@ -493,7 +483,6 @@ void PipelineHandler::completeRequest(Request *request)\n> void PipelineHandler::registerCamera(std::shared_ptr camera,\n> \t\t\t\t std::unique_ptr data)\n> {\n> -\tdata->camera_ = camera.get();\n> \tcameraData_[camera.get()] = std::move(data);\n> \tcameras_.push_back(camera);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5EFADC0F1B\n\tfor ;\n\tTue, 22 Dec 2020 07:55:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D8408615AC;\n\tTue, 22 Dec 2020 08:55:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1749E60111\n\tfor ;\n\tTue, 22 Dec 2020 08:55:53 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8C9BE9E6;\n\tTue, 22 Dec 2020 08:55:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KMmEcBvr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608623752;\n\tbh=apMNEO39bu066qO96r7reAlrvrvPUfoUi576V2L7Oxc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KMmEcBvrGuL39emunt7IN4gWpj7W6L3K+TBmYlifVZ1xT95XxABUzhHKe38cufU5l\n\tngpqjUqkeSbmRQoMzpDX9MV7npTQsFP72+PGWfkmSbMe/7yj6hcq+4EmjXGtaS7vpS\n\tZpvatbxJPXn6sbicP5UTuVOGmOf7LGMT/Cs8lcWY=","Date":"Tue, 22 Dec 2020 09:55:45 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"","References":"<20201221235345.1965878-1-niklas.soderlund@ragnatech.se>\n\t<20201221235345.1965878-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201221235345.1965878-3-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: pipeline_handler:\n\tRemove Camera pointer from CameraData","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14305,"web_url":"https://patchwork.libcamera.org/comment/14305/","msgid":"<20201222112127.fobxpjpcqum5edns@uno.localdomain>","date":"2020-12-22T11:21:27","subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: pipeline_handler:\n\tRemove Camera pointer from CameraData","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Tue, Dec 22, 2020 at 12:53:45AM +0100, Niklas Söderlund wrote:\n> There are no users left of this field, drop it.\n>\n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> include/libcamera/internal/pipeline_handler.h | 1 -\n> src/libcamera/pipeline_handler.cpp | 11 -----------\n> 2 files changed, 12 deletions(-)\n>\n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index 5f9a26be1f7a9e9e..0748f86346084e2d 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -42,7 +42,6 @@ public:\n> \t}\n> \tvirtual ~CameraData() = default;\n>\n> -\tCamera *camera_;\n> \tPipelineHandler *pipe_;\n> \tstd::list queuedRequests_;\n> \tControlInfoMap controlInfo_;\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 26d6c07d2d6e69e9..c2604d4561124186 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -60,16 +60,6 @@ LOG_DEFINE_CATEGORY(Pipeline)\n> * exists.\n> */\n>\n> -/**\n> - * \\var CameraData::camera_\n> - * \\brief The camera related to this CameraData instance\n> - *\n> - * The camera_ pointer provides access to the Camera object that this instance\n> - * is related to. It is set when the Camera is registered with\n> - * PipelineHandler::registerCamera() and remains valid until the CameraData\n> - * instance is destroyed.\n> - */\n> -\n> /**\n> * \\var CameraData::pipe_\n> * \\brief The pipeline handler related to this CameraData instance\n> @@ -493,7 +483,6 @@ void PipelineHandler::completeRequest(Request *request)\n> void PipelineHandler::registerCamera(std::shared_ptr camera,\n> \t\t\t\t std::unique_ptr data)\n> {\n> -\tdata->camera_ = camera.get();\n> \tcameraData_[camera.get()] = std::move(data);\n> \tcameras_.push_back(camera);\n>\n> --\n> 2.29.2\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6792C0F1B\n\tfor ;\n\tTue, 22 Dec 2020 11:21:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 47E676158A;\n\tTue, 22 Dec 2020 12:21:18 +0100 (CET)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 74BD960528\n\tfor ;\n\tTue, 22 Dec 2020 12:21:16 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id C6D65C0006;\n\tTue, 22 Dec 2020 11:21:15 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Tue, 22 Dec 2020 12:21:27 +0100","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20201222112127.fobxpjpcqum5edns@uno.localdomain>","References":"<20201221235345.1965878-1-niklas.soderlund@ragnatech.se>\n\t<20201221235345.1965878-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201221235345.1965878-3-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: pipeline_handler:\n\tRemove Camera pointer from CameraData","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]